Add left-handed spherical and cylindrical billboards by PranavSenthilnathan · Pull Request #109605 · dotnet/runtime

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

PranavSenthilnathan · 2024-11-07T04:30:36Z

Adds the left-handed CreateBillboard and CreateConstrainedBillboard variants. The code gen and perf for the new variants are very similar to the existing right-handed versions.

Closes#93046

ghost · 2024-11-07T04:30:41Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

ghost · 2024-11-07T04:30:42Z

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

jeffhandley · 2024-11-07T07:37:25Z

 => (value1.AsImpl() + value2.AsImpl()).AsM4x4();

- /// <summary>Creates a spherical billboard that rotates around a specified object position.</summary>
+ /// <summary>Creates a right-handed spherical billboard matrix that rotates around a specified object position.</summary>


Once this is merged, please also follow up with a PR to update Matrix4x4.xml (dotnet/dotnet-api-docs). Once seeded from the original comments, we don't automatically flow changes over to the API docs repo.

PranavSenthilnathan · 2024-11-18T20:47:27Z

@tannergooding or @michaelgsharp PTAL when you get a chance

tannergooding · 2024-11-19T22:12:05Z

+ expected.M44 = +1.0f;
+
+ Matrix4x4 actual = CreateLookAt(cameraPosition, cameraTarget, cameraUpVector);
+ Assert.True(MathHelper.Equal(expected, actual), $"{CreateLookAtMethodName} did not return the expected value.");


nit: We have existing AssertExtensions.Equal(expected, actual, allowedVariance); helper that will provide better diagnostic messages in the case of failure.

I've updated this and used 1e-5 for the variance (matches MathHelper.Equals). I think we can can use tighter errors in some cases where we have numbers with abs < 1 and having 6 sigfigs, but I'll just leave it for now.

tannergooding

LGTM. Couple small nits that would be nice to cleanup, but don't feel the need to block merging on getting them resolved

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

Add left handed spherical and cyclindrical billboards
d1e9328

ghost added area-System.Numerics new-api-needs-documentation labels Nov 7, 2024

dotnet-policy-serviceBot assigned PranavSenthilnathan Nov 7, 2024

jeffhandley added this to the 10.0.0 milestone Nov 7, 2024

jeffhandley requested review from michaelgsharp and tannergooding November 7, 2024 06:54

build-analysisBot mentioned this pull request Nov 7, 2024
tailcall_v4/hijacking/hijacking.cmd Timed Out #106134
Closed

jeffhandley reviewed Nov 7, 2024
View reviewed changes

stephentoub reviewed Nov 8, 2024
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.Impl.cs

build-analysisBot mentioned this pull request Nov 10, 2024
restarted. Azure DevOps can't recover from restarts. dotnet/dnceng#3879
Closed
3 tasks

jeffhandley changed the title ~~Add left handed spherical and cyclindrical billboards~~Add left-handed spherical and cylindrical billboardsNov 11, 2024

tannergooding reviewed Nov 19, 2024
View reviewed changes

Comment threadsrc/libraries/System.Numerics.Vectors/tests/Matrix4x4LeftHandChangedBasisTests.cs Outdated

tannergooding reviewed Nov 19, 2024
View reviewed changes

Comment threadsrc/libraries/System.Numerics.Vectors/tests/Matrix4x4OrientationAwareTests.cs Outdated

tannergooding reviewed Nov 19, 2024
View reviewed changes

Comment threadsrc/libraries/System.Numerics.Vectors/tests/Matrix4x4RightHandTests.cs Outdated

tannergooding reviewed Nov 19, 2024
View reviewed changes

Comment threadsrc/libraries/System.Private.CoreLib/src/System/Numerics/Matrix4x4.Impl.cs

Address comments
d972c39

PranavSenthilnathan requested a review from tannergooding November 22, 2024 03:16

PranavSenthilnathan added 2 commits January 21, 2025 13:26

revert to old test structure
a4a2f29

Merge branch 'main' into lh-matrix-create
0674250

tannergooding reviewed Jan 24, 2025
View reviewed changes

Comment threadsrc/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs Outdated

tannergooding reviewed Jan 24, 2025
View reviewed changes

Comment threadsrc/libraries/System.Numerics.Vectors/tests/Matrix4x4Tests.cs Outdated

tannergooding approved these changes Jan 24, 2025
View reviewed changes

pr comments
7ba1f60

build-analysisBot mentioned this pull request Jan 24, 2025
Test failure: baseservices/exceptions/stackoverflow/stackoverflowtester/stackoverflowtester.cmd #110173
Open

PranavSenthilnathan merged commit 6e2d394 into dotnet:mainJan 24, 2025

github-actionsBot locked and limited conversation to collaborators Feb 24, 2025