JIT: Don't run `optSetBlockWeights` when we have PGO data by amanasifkhalid · Pull Request #111764 · dotnet/runtime

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

amanasifkhalid · 2025-01-23T22:23:30Z

Part of #107749. For PGO scenarios, we plan to rely entirely on profile synthesis to propagate profile-derived weights throughout the flowgraph. This is the first step in transitioning away from the existing weight propagation heuristics. We want to keep these around for non-PGO scenarios for now, though ideally, we'll eventually be able to replace these entirely with profile synthesis (plus branch prediction heuristics when we don't have profile data), and consolidate how the profile is maintained for PGO and non-PGO scenarios.

This had few diffs locally, as optSetBlockWeights already avoids modifying profile-derived weights. The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

dotnet-policy-service · 2025-01-23T22:24:03Z

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

AndyAyersMS · 2025-01-24T01:37:10Z

The diffs seem to stem from BBF_PROF_WEIGHT not being propagated to all blocks when we have profile data (such as during inlining). This doesn't seem concerning, since the next profile repair pass (which I've yet to add) will propagate the flag as needed.

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

amanasifkhalid · 2025-01-24T04:18:35Z

I would rather see us strive to get these flags set properly by each phase that manipulates flow. So yet another aspect of pgo post phase checks: if root method has PGO, all blocks must have BBF_PROF_WEIGHT

That sounds like a better plan. I suppose a reasonable goal is to enable BBF_PROF_WEIGHT propagation up to optSetBlockWeights to make this PR zero-diff, then get this checked in (while progressing the flag checks in tandem)?

) Part of #107749. Prerequisite to #111764 (comment). Add a post-phase check that ensures BBF_PROF_WEIGHT is set for every reachable block when we have profile data. This check revealed only one site -- when incorporating an inlinee's blocks -- where we couldn't rely on normal flow propagation to set the flag.

amanasifkhalid · 2025-01-25T13:57:26Z

Diffs are smaller this time around; some of these are probably from the bbNum dependency we still have in fgUpdateFlowGraph, since we're skipping block renumbering when we have PGO data.

* main: (22 commits) Clean up Stopwatch a bit (dotnet#111834) JIT: Fix embedded broadcast simd size (dotnet#111638) Revert potential UB due to aliasing + more WB removals (dotnet#111733) re-enable acceleration of Vector512<long>.op_Multiply (dotnet#111832) Handle OSSL 3.4 change to SAN:othername formatting JIT: Fix stack allocated arrays for NativeAOT (dotnet#111827) JIT: enhance RBO inference for similar compares to constants (dotnet#111766) JIT: Don't run optSetBlockWeights when we have PGO data (dotnet#111764) [Android] Make sure RuntimeFlavor=CoreCLR when clr subset is specified (dotnet#111821) Change empty subject test certificate to include a critical SAN. Fix reversed code offsets in GcInfo (dotnet#111792) Swap some libraries areas between leads (dotnet#111816) Add left-handed spherical and cylindrical billboards (dotnet#109605) JIT: revise `optRelopImpliesRelop` to always set `reverseSense` (dotnet#111803) Fix Zip64ExtraField handling (dotnet#111802) Add build support for Android+CoreCLR (dotnet#110471) arm64: Add bic(s) compact encoding (dotnet#111452) JIT: Ensure `BBF_PROF_WEIGHT` flag is set when we have PGO data (dotnet#111780) Add support for AVX10.2, Add AVX10.2 API surface and template tests (dotnet#111209) JIT: Preliminary for enabling inlining late devirted calls (dotnet#111782) ...

…111873) Part of #107749. Follow-up to #111764. fgComputeMissingBlockWeights doesn't modify anything when we have profile data, and fgCalledCount can be derived from the entry block's weight quite simply.

Don't run optSetBlockWeights when we have PGO data
519718b

ghost added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Jan 23, 2025

dotnet-policy-serviceBot assigned amanasifkhalid Jan 23, 2025

build-analysisBot mentioned this pull request Jan 24, 2025
The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008
Open
3 tasks

amanasifkhalid mentioned this pull request Jan 24, 2025
JIT: Ensure BBF_PROF_WEIGHT flag is set when we have PGO data #111780
Merged

Merge branch 'main' into skip-optSetBlockWeights
7d6c334

AndyAyersMS approved these changes Jan 24, 2025
View reviewed changes

amanasifkhalid merged commit 38b1419 into dotnet:mainJan 25, 2025

amanasifkhalid deleted the skip-optSetBlockWeights branch January 25, 2025 13:58

amanasifkhalid mentioned this pull request Jan 27, 2025
JIT: Skip fgComputeMissingBlockWeights when we have profile data #111873
Merged

amanasifkhalid mentioned this pull request Jan 30, 2025
JIT: Flowgraph Modernization and Improved Block Layout in .NET 10 #107749
Closed
45 tasks

github-actionsBot locked and limited conversation to collaborators Feb 25, 2025