A Basic Solution Structure to Enable Infrastructure Development by natidea · Pull Request #3 · dotnet/sdk

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea · 2016-08-02T06:06:55Z

This basic solution includes an empty placeholder project for the PackageDependencyResolution task. (I left out the source of the task because that is a longer review.) This PR is the minimal layout we need to start working on infrastructure tasks (Jenkins, Microbuild etc.). More detailed build.cmd, Settings.targets etc can be fleshed out later.

/cc @333fred @srivatsn @dotnet/project-system

eerhardt · 2016-08-02T15:22:45Z

+ <ProjectGuid>{DF7D2697-B3B4-45C2-8297-27245F528A99}</ProjectGuid>
+ <OutputType>Library</OutputType>
+ <AppDesignerFolder>Properties</AppDesignerFolder>
+ <RootNamespace>Microsoft.PackageDependencyResolution.Tasks</RootNamespace>


How many "tasks" libraries do we expect to have in this repo? This name seems very specific, and not many tasks will be able to live in this assembly.
For example, my next task is to add the tasks for "Generate .deps.json" and "Generate .runtimeconfig.json" files. I don't think they would belong in an assembly named Microsoft.PackageDependencyResolution.Tasks.

👍 with @eerhardt

OK, we could explore a rename

As we discussed offline, checking this in to unblock Jenkins work

Importing the publish profiles from the package.

# This is the 1st commit message: tool-install: Avoid duplicate sources # This is the commit message #2: tool-install: Use hashset for LoadDefaultSources # This is the commit message #3: Check for duplicate source uris rather than objects as they might have different names

…l.json resolver, list improvements - Create shared UpdateWorkflow and UninstallWorkflow (#4A) - Refactor SdkUpdateCommand and SdkUninstallCommand to thin wrappers (#4B) - Fix uninstall error message to use actual source filter (dotnet#2) - Fix GC deletion assumption with targeted installation snapshot (dotnet#3) - Include channel/spec in update status messages (dotnet#8) - Create RuntimeUpdateCommand and RuntimeUninstallCommand (#4C) - Wire runtime update/uninstall in parsers (#4D) - Implement GlobalJsonChannelResolver and use in GC RefreshGlobalJsonSpecs (dotnet#16) - List command now shows both install specs and installed versions (dotnet#12) - Fix SourceOption naming/syntax for System.CommandLine compatibility Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

natidea added 3 commits August 1, 2016 21:51

Initial checkin package dependency resolution task
d31fed1

Redirect binaries to top level bin dir and import Settings.targets
13391e7

Add build script
53edbe4

eerhardt reviewed Aug 2, 2016
View reviewed changes

natidea merged commit fdfa7f9 into dotnet:masterAug 2, 2016

nguerrera pushed a commit that referenced this pull request Oct 10, 2016
Merge pull request#3from natidea/packageDeps
7438406
As we discussed offline, checking this in to unblock Jenkins work

mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
Merge pull requestdotnet#3from aspnet/ContentPath
6731e48
Importing the publish profiles from the package.

JanKrivanek referenced this pull request in JanKrivanek/sdk Oct 26, 2022
Tests#3
0c399ad

JanKrivanek referenced this pull request in JanKrivanek/sdk Oct 26, 2022
Test#3
576a4e0

olgaark mentioned this pull request Jul 10, 2024
MSBuild SDK support for C++/CLI #42078
Open

yngndrw mentioned this pull request Apr 17, 2025
dotnet build performance - Windows Vs MacOS Vs Linux #48541
Closed

McPherran mentioned this pull request Jun 6, 2025
terminal logger prevents output messages #43293
Open

baronfel mentioned this pull request Jun 19, 2025
Update --cli-schema output for consistency #49500
Open

mmitche added a commit that referenced this pull request Mar 17, 2026
Trigger CI build#3- streak: 2/25
cdf5d19
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcpopMSFT mentioned this pull request Mar 24, 2026
SDK PR Build Performance Analysis #53578
Open

superedit-art mentioned this pull request Jun 1, 2026
[WPF .NET 10] Multiple regressions in SDK 10.0.202: Single File crash, folder-name sensitive startup failure, and build error with custom AssemblyName dotnet/wpf#11678
Open

Evangelink mentioned this pull request May 26, 2026
Forward terminal logger arguments to MSBuild during dotnet test#54310
Merged

jonathanpeppers mentioned this pull request Jun 5, 2026
Add dotnet test --list-devices support for MAUI #54565
Merged

OvesN mentioned this pull request Jun 15, 2026
Migrate FindAssembliesWithReferencesTo to IMultiThreadableTask #54748
Merged

PureWeen mentioned this pull request Jun 15, 2026
[Preview 6 regression] GenerateStaticWebAssetEndpointsManifest throws Sequence contains more than one element when a MAUI Blazor Hybrid project references a Razor class library and the BlazorWebView package #54779
Open