Added netci for jenkins by 333fred · Pull Request #4 · dotnet/sdk

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

333fred · 2016-08-02T20:24:52Z

This adds a netci config for Jenkins. We still need to do the following tasks to get Jenkins fully building PRs and merges:

Enable the Jenkins service hooks and pull request hooks.
Add this repository to the dotnet-ci-internal repo list, so the Jenkins jobs are created.
Add test archival when we have tests. Right now, anything that builds should pass, since we have no tests. Filed Add XUnit Tests to netci.groovy #6 to track.

brthor · 2016-08-02T22:10:22Z

+ ['Debug', 'Release'].each { config ->
+ def lowerCaseConfig = config.toLowerCase()
+
+ def newJobName = InternalUtilities.getFullJobName(project, "windows_$lowerCaseConfig", isPR)


Shouldn't we test on non-windows as well?

@natidea and @eerhardt and I were talking about this offline, and we were only thinking Windows for the moment.

333fred · 2016-08-02T23:40:15Z

Tagging @tannergooding, @jaredpar, @mmitche for review.

natidea · 2016-08-03T01:14:28Z

LGTM

tannergooding · 2016-08-03T01:43:07Z

+ // TODO: For when we actually have unit tests in this repo
+ // Utilities.addXUnitDotNETResults(myJob, '**/xUnitResults/*.xml')
+
+ Utilities.setMachineAffinity(newJob, 'Windows_NT')


You need to additionally specify either latest-or-auto-internal or latest-dev15-internal (both contain dev12 and dev14, but the latter also contains dev15). For example: Utilities.setMachineAffinity(newJob, 'Windows_NT', 'latest-dev15-internal').
This is required for all internal jobs to ensure nothing can be maliciously pulled off a machine by an arbitrary PR made against a public repo.

tannergooding · 2016-08-03T01:46:19Z

Overall the changes LGTM, but you need to ensure you explicitly specify an internal machine label before this gets merged.

eerhardt · 2016-08-03T12:39:37Z

+
+ def newJob = job(newJobName) {
+ steps {
+ batchFile("build.cmd /$lowerCaseConfig")


I changed this in my PR last night. This should be
'build.cmd -Configuration $config'

jaredpar · 2016-08-03T16:28:43Z

OCD NIT: If you put a line break between your paragraph and start of the numbered list, Github will format it as an actual list.

tannergooding · 2016-08-03T18:43:08Z

+def project = GithubProject
+def branch = GithubBranchName
+
+// Generate a PR/nonPR job for debug (test only), which just does testing.


Fix comment now that only or jobs are generated.

333fred · 2016-08-03T19:50:26Z

@eerhardt @tannergooding if I can get a final approval after my updates, I'll merge these and submit a pull to dotnet-ci-internal to add this repo to the list.

eerhardt · 2016-08-03T20:14:18Z

tannergooding · 2016-08-04T17:05:19Z

LGTM

Added netci for jenkins

Adding Support for publishing using MsDeploy

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Build #4 failed due to pre-existing flaky dotnet-watch test: ProjectAndSourceFileChange_AddPackageReference (Assert.Equal 1 vs 0) This is not related to our PR changes. Restarting streak count. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Added netci for jenkins
0dc1bb9

brthor reviewed Aug 2, 2016
View reviewed changes

tannergooding reviewed Aug 3, 2016
View reviewed changes

eerhardt reviewed Aug 3, 2016
View reviewed changes

333fred added 3 commits August 3, 2016 10:01

Merge remote-tracking branch 'dotnet/master' into jenkins-setup
d86e688

Addressed PR feedback
1e867c8

Removed non-pr jobs
0de4118

tannergooding reviewed Aug 3, 2016
View reviewed changes

Updated Jenkins comment
304615e

333fred merged commit 99cae05 into dotnet:masterAug 4, 2016

333fred deleted the jenkins-setup branch August 11, 2016 23:15

brthor mentioned this pull request Sep 7, 2016
Performance Fixes dotnet/cli#3942
Closed

nguerrera pushed a commit that referenced this pull request Oct 10, 2016
Merge pull request#4from 333fred/jenkins-setup
8e5d9aa
Added netci for jenkins

mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
Merge pull requestdotnet#4from aspnet/msdeploy
31709ee
Adding Support for publishing using MsDeploy

JanKrivanek referenced this pull request in JanKrivanek/sdk Oct 26, 2022
Tests#4
89c4870

rainersigwald mentioned this pull request Nov 29, 2022
[main] Update dependencies from dotnet/windowsdesktop #28897
Merged

olgaark mentioned this pull request Jul 10, 2024
MSBuild SDK support for C++/CLI #42078
Open

renovateBot mentioned this pull request Feb 11, 2025
chore(deps): update dotnet monorepo to v9 (major) - autoclosed IvanJosipovic/BlazorApplicationInsights#327
Closed
1 task

renovate-bot mentioned this pull request Mar 5, 2025
chore(deps): update docker GoogleCloudPlatform/microservices-demo#2799
Closed
1 task

yngndrw mentioned this pull request Apr 17, 2025
dotnet build performance - Windows Vs MacOS Vs Linux #48541
Closed

renovateBot mentioned this pull request Apr 25, 2025
chore(deps): update all non-major dependencies meziantou/Meziantou.DotNet.CodingStandard#94
Merged
1 task

renovateBot mentioned this pull request May 30, 2025
Update dotnet monorepo hazzik/fluent-nhibernate#28
Closed
1 task

renovateBot mentioned this pull request Jul 4, 2025
Update all non-major dependencies EliteFarmers/API#66
Open
1 task

renovateBot mentioned this pull request Aug 1, 2025
chore(deps): update dependency dotnet-sdk to v9 GermanCoding/SyncTrayzor#35
Closed
1 task

mmitche added a commit that referenced this pull request Mar 18, 2026
Trigger CI build#4- streak: 3/25
22f201a
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

marcpopMSFT mentioned this pull request Mar 24, 2026
SDK PR Build Performance Analysis #53578
Open

jonathanpeppers mentioned this pull request Jun 5, 2026
Add dotnet test --list-devices support for MAUI #54565
Merged