Generate a nupkg for Microsoft.DotNet.Core.Sdk. by eerhardt · Pull Request #9 · dotnet/sdk

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt · 2016-08-03T23:43:43Z

This adds a project that will generate .nupkgs for us. I copied some stuff from the roslyn-project-system. Some I made up (ex. using XPlat NuGet to pack the nuspec).

@davkean @natidea @333fred @brthor @livarcocc @piotrpMSFT

eerhardt · 2016-08-04T15:25:46Z

Ok, I have the NuGet package being created as part of "build.cmd". This is ready to be reviewed.

brthor · 2016-08-04T17:32:47Z

RebuildNuGetPackages [](start = 75, length = 20)
Why do you need build and rebuild, they appear to do the same things here.

Build calls the "Build" target.
Rebuild calls the "Rebuild" target.
The "Rebuild" target calls "Clean;Build".
"Clean" deletes the existing assets.
So they don't do the same things. Rebuild ensures you don't do incremental build (because it deleted all the built assets).

333fred · 2016-08-04T19:47:17Z

@dotnet-bot test Windows Debug

333fred · 2016-08-04T20:10:51Z

Same here. We should add a \ between them, just in case DOTNET_INSTALL_DIR is set to something without a trailing \. Doesn't hurt anything, and potentially breaks builds otherwise.

eerhardt · 2016-08-04T21:51:24Z

Thanks for the feedback. I've responded to all current feedback. PTAL.

Generate a nupkg for Microsoft.DotNet.Core.Sdk.

Add .NET Standard support matrix

Removing the msbuild version 15.1 from the project

Changes include: - Rename 'managed installations' to 'tracked installations' (dotnet#10) - Fix '.metadata' -> 'metadata' folder name (dotnet#18) - Include component type in error/warning messages (dotnet#11) - Remove component spec from runtime update (dotnet#12) - Remove GetInstallations wrapper (dotnet#6) - ScopedMutex throws TimeoutException on failure (dotnet#22) - Make InstallResult.Install non-nullable (dotnet#17) - Remove ComponentFilesExist shortcut (dotnet#19) - Wire up InstallSource enum (dotnet#21) - ListCommand: enum types, narrowed mutex, read-only verify, spacing (dotnet#3,dotnet#4,dotnet#5,#1) - Show global.json path in list output (dotnet#15) - Add doc comments to ListData types (dotnet#7) - Move SourceOption to CommonOptions, remove alias fields (dotnet#9) - Remove ResolveChannelFromGlobalJson test hook wrapper (dotnet#14) - Root 'dotnetup update' updates all components (dotnet#16) - GlobalJsonChannelResolver: support rollForward policy (dotnet#13) - Error when installing to unmanaged dotnet root (dotnet#20) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Changes include: - UpdateWorkflow.Execute returns non-zero exit code on failure (#1) - InfoCommand JSON output includes InstallSpecs (dotnet#2) - Wire --update-global-json through SdkUpdateCommand to UpdateWorkflow (dotnet#3) - Implement DotnetInstallManager.UpdateGlobalJson using Utf8JsonReader (dotnet#3) - Fix ResolveEntryDestPath to use normalized entry name (dotnet#4) - Fix test: MajorMinor test uses correct channel '9.0' (dotnet#5) - Fix test: LTS assertion checks Major instead of Minor (dotnet#6) - Fix ScopedMutex.Dispose to not leak mutex on ReleaseMutex throw (dotnet#7) - Make CommonOptions fields static readonly (dotnet#9) - Remove unused --no-progress from uninstall parsers (dotnet#10) - GarbageCollector catches Exception instead of just IOException (dotnet#11) - Capitalize 'SDK' in SdkCommandParser description (dotnet#12) - Eliminate redundant manifest reads in InstallerOrchestratorSingleton (dotnet#13) - Fix STS test error message to say 'major' not 'minor' (dotnet#14) - Make DotnetupUtilities.ExeSuffix readonly (dotnet#16) - Fix FormatBytes to use floating-point with one decimal (dotnet#17) - Remove dead ReleaseManifest variable in DotnetInstaller (dotnet#18) - Make UpdateChannel.Name immutable (dotnet#19) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

eerhardt force-pushed the CreateNupkg branch from 5df9086 to 3ebf67bCompare August 4, 2016 15:25

brthor reviewed Aug 4, 2016
View reviewed changes

eerhardt added 2 commits August 4, 2016 14:51

Generate a nupkg for Microsoft.DotNet.Core.Sdk.
d444343

Add build.proj file that is able to build the .sln and the NuGet.proj.
8aba4a0

333fred reviewed Aug 4, 2016
View reviewed changes

eerhardt added 2 commits August 4, 2016 16:30

Add Directory.Build.props to contain common build properties.
66b3fa8

Respond to PR feedback.
babe271

eerhardt force-pushed the CreateNupkg branch from 3ebf67b to babe271Compare August 4, 2016 21:48

eerhardt merged commit 967fc75 into dotnet:masterAug 5, 2016

eerhardt deleted the CreateNupkg branch August 5, 2016 13:48

nguerrera pushed a commit that referenced this pull request Oct 10, 2016
Merge pull request#9from eerhardt/CreateNupkg
168adfd
Generate a nupkg for Microsoft.DotNet.Core.Sdk.

sbomer pushed a commit to sbomer/sdk that referenced this pull request Sep 19, 2017
Merge pull requestdotnet#9from dotnet/terrajobst/support-matrix
fc19f3f
Add .NET Standard support matrix

mmitche pushed a commit to mmitche/sdk that referenced this pull request Jun 5, 2020
Merge pull requestdotnet#9from aspnet/MsBuildVersion
c875c05
Removing the msbuild version 15.1 from the project

KathleenDollard mentioned this pull request Feb 2, 2026
Help output for dotnet build appears misleading #52770
Open