[video_player_android] Platform view support by FirentisTFW · Pull Request #8466 · flutter/packages

FirentisTFW · 2025-01-21T13:27:38Z

This PR adds support for platform views on Android as a way of displaying a video. When creating a video, it's now possible to choose between texture view approach (rendered using Texture widget on the Flutter side) and platform view approach (rendered on the native side, using SurfaceView).

VideoPlayer class now has nothing to do with texture. The texture-related code was moved from it to TextureVideoPlayer - a subclass of VideoPlayer that adds texture functionality. There's also PlatformViewVideoPlayer - a subclass of VideoPlayer that adds platform view functionality. In the plugin class (create method) we create either the platform view version or the texture version based on the parameter (viewType) passed in from Flutter side.

The functionality is not yet exposed in the app-facing package (only in the example app) - it will be done in a separate PR. The PR does not introduce breaking changes.

Related issues:

#86613 - this issue requests platform view support for iOS. Here we also add it for the Android, so that it works on both mobile platforms.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…upport

matanlurey

Mostly LG.

Holding off on approval so @camsim99 can also take a look. Thanks for addressing the comments!

matanlurey

LGTM.

camsim99

The other changes look reasonable to me, thanks!!

FirentisTFW · 2025-03-04T14:25:17Z

@stuartmorgan @camsim99 @matanlurey Thanks for the review! I did some lasts manual tests on a couple of devices and everything seems to be working fine. I'll go ahead and merge this one.

…s#8466)

flutter/packages@9e4684e...abba683 2025-03-05 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 1 (flutter/packages#8698) 2025-03-04 57854043+CaoGiaHieu-dev@users.noreply.github.com [go_router_builder]: Fix `The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737) 2025-03-04 pawel.jakubowski@leancode.pl [video_player_android] Platform view support (flutter/packages#8466) 2025-03-04 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request` (flutter/packages#8766) 2025-03-03 engine-flutter-autoroll@skia.org Manual roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8775) 2025-03-03 engine-flutter-autoroll@skia.org Roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8774) 2025-03-03 reidbaker@google.com [flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (flutter/packages#8760) 2025-03-03 neilself@gmail.com [google_sign_in] Add Android account name field as optional (platform interface changes) (flutter/packages#8735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

This PR adds support for platform views as on optional way of displaying a video (as an alternative to Flutter's `Texture` widget). Texture-based approach is still the default setting when creating a new player. Platform interface was updated in #8453 Platform implementations were added in these PRs: - iOS: #8237 - Android: #8466 Closes [flutter/issues/86613](flutter/flutter#86613).

This PR adds support for platform views on Android as a way of displaying a video. When creating a video, it's now possible to choose between texture view approach (rendered using `Texture` widget on the Flutter side) and platform view approach (rendered on the native side, using `SurfaceView`). `VideoPlayer` class now has nothing to do with texture. The texture-related code was moved from it to `TextureVideoPlayer` - a subclass of `VideoPlayer` that adds texture functionality. There's also `PlatformViewVideoPlayer` - a subclass of `VideoPlayer` that adds platform view functionality. In the plugin class (`create` method) we create either the platform view version or the texture version based on the parameter (`viewType`) passed in from Flutter side. The functionality is not yet exposed in the app-facing package (only in the example app) - it will be done in a separate PR. The PR does not introduce breaking changes. Related issues: - [#86613](flutter/flutter#86613) - this issue requests platform view support for iOS. Here we also add it for the Android, so that it works on both mobile platforms.

This PR adds support for platform views as on optional way of displaying a video (as an alternative to Flutter's `Texture` widget). Texture-based approach is still the default setting when creating a new player. Platform interface was updated in flutter#8453 Platform implementations were added in these PRs: - iOS: flutter#8237 - Android: flutter#8466 Closes [flutter/issues/86613](flutter/flutter#86613).

This PR adds support for platform views on Android as a way of displaying a video. When creating a video, it's now possible to choose between texture view approach (rendered using `Texture` widget on the Flutter side) and platform view approach (rendered on the native side, using `SurfaceView`). `VideoPlayer` class now has nothing to do with texture. The texture-related code was moved from it to `TextureVideoPlayer` - a subclass of `VideoPlayer` that adds texture functionality. There's also `PlatformViewVideoPlayer` - a subclass of `VideoPlayer` that adds platform view functionality. In the plugin class (`create` method) we create either the platform view version or the texture version based on the parameter (`viewType`) passed in from Flutter side. The functionality is not yet exposed in the app-facing package (only in the example app) - it will be done in a separate PR. The PR does not introduce breaking changes. Related issues: - [#86613](flutter/flutter#86613) - this issue requests platform view support for iOS. Here we also add it for the Android, so that it works on both mobile platforms.

This PR adds support for platform views as on optional way of displaying a video (as an alternative to Flutter's `Texture` widget). Texture-based approach is still the default setting when creating a new player. Platform interface was updated in flutter#8453 Platform implementations were added in these PRs: - iOS: flutter#8237 - Android: flutter#8466 Closes [flutter/issues/86613](flutter/flutter#86613).

This PR adds support for platform views on Android as a way of displaying a video. When creating a video, it's now possible to choose between texture view approach (rendered using `Texture` widget on the Flutter side) and platform view approach (rendered on the native side, using `SurfaceView`). `VideoPlayer` class now has nothing to do with texture. The texture-related code was moved from it to `TextureVideoPlayer` - a subclass of `VideoPlayer` that adds texture functionality. There's also `PlatformViewVideoPlayer` - a subclass of `VideoPlayer` that adds platform view functionality. In the plugin class (`create` method) we create either the platform view version or the texture version based on the parameter (`viewType`) passed in from Flutter side. The functionality is not yet exposed in the app-facing package (only in the example app) - it will be done in a separate PR. The PR does not introduce breaking changes. Related issues: - [#86613](flutter/flutter#86613) - this issue requests platform view support for iOS. Here we also add it for the Android, so that it works on both mobile platforms.

This PR adds support for platform views as on optional way of displaying a video (as an alternative to Flutter's `Texture` widget). Texture-based approach is still the default setting when creating a new player. Platform interface was updated in flutter#8453 Platform implementations were added in these PRs: - iOS: flutter#8237 - Android: flutter#8466 Closes [flutter/issues/86613](flutter/flutter#86613).

FirentisTFW added 9 commits January 21, 2025 12:27

Add platform interface changes
15a0d09

Add platform view support for Android
25520fc

Rearrange native unit tests after merge
28d38c5

Remove a todo in web implementation
0d3a753

Set initial value of nextNonTexturePlayerId to Long.MAX_VALUE
ea16d63

Use player provider instead of modifiable list
25425ca

Remove empty line
ce2aa51

Check player view states in Dart unit tests
8aeca10

Restore previous formatting for comments
209f34f

github-actionsBot added platform-android p: video_player labels Jan 21, 2025

FirentisTFW added 11 commits January 21, 2025 14:41

Add missing licenses
42cb659

Format files
690ec54

Fix linting issues
6db9e6d

Rename textureId to playerId in platform interace methods
277bff7

Rename textureId to playerId in Android Dart files
5aca5db

Rename textureId to playerId in Android native code
751d529

Add an ignore to UI test (it times out on Firebase Test Lab)
e6f856b

Merge branch 'main' into feature/video-player-android-platform-view-s…
b752b4c
…upport

Bump platform interface dependency to 6.3.0
8fc1fa0

Remove resolved todo and fix dartdocs
b745dcc

Add missing import
773cfc1

FirentisTFW force-pushed the feature/video-player-android-platform-view-support branch from 1bd40ac to 773cfc1Compare January 28, 2025 11:37

FirentisTFW added 4 commits January 28, 2025 12:45

Format test file
89dfcea

Add more context to class names for native views
f59463a

Add missing docs for Android
650cc21

Format file
18463e7

FirentisTFW requested a review from stuartmorgan-g January 28, 2025 14:38

FirentisTFW marked this pull request as ready for review January 28, 2025 14:38

FirentisTFW requested a review from camsim99 as a code owner January 28, 2025 14:38

FirentisTFW added 2 commits February 26, 2025 01:08

Add a todo to decouple identifiers in the future
6c17ebc

Format file
9895676

matanlurey reviewed Feb 26, 2025
View reviewed changes

FirentisTFW added 3 commits February 26, 2025 09:29

Resolve lint issues
da1b78d

Inline method
ae4bfae

Format file
371c462

matanlurey approved these changes Feb 26, 2025
View reviewed changes

camsim99 approved these changes Mar 3, 2025
View reviewed changes

FirentisTFW added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 4, 2025

auto-submitBot merged commit 1995a0e into flutter:mainMar 4, 2025

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2025
1995a0e[video_player_android] Platform view support (flutter/package…
da62b26
…s#8466)

engine-flutter-autoroll mentioned this pull request Mar 4, 2025
Roll Packages from 9e4684e58d15 to 1995a0e318e8 (6 revisions) flutter/flutter#164549
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 4, 2025
1995a0e[video_player_android] Platform view support (flutter/package…
5dd8425
…s#8466)

engine-flutter-autoroll mentioned this pull request Mar 4, 2025
Roll Packages from 9e4684e58d15 to 1995a0e318e8 (6 revisions) flutter/flutter#164560
Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2025
1995a0e[video_player_android] Platform view support (flutter/package…
6f7a577
…s#8466)

engine-flutter-autoroll mentioned this pull request Mar 5, 2025
Roll Packages from 9e4684e58d15 to abba683067fb (8 revisions) flutter/flutter#164630
Merged

This was referenced Mar 5, 2025
[video_player] Incorrect colors in HDR playback on iOS flutter/flutter#91241
Closed
Video Player HDR Problem media-kit/media-kit#615
Open

FirentisTFW mentioned this pull request Mar 6, 2025
[video_player] Platform view support #8810
Merged
11 tasks

stuartmorgan-g mentioned this pull request May 6, 2025
[video_player_android] isBuffering flag always return true after calling seekTo method - fixed #9198
Merged
9 tasks

Navigation Menu

Uh oh!

[video_player_android] Platform view support - #8466

[video_player_android] Platform view support#8466
auto-submit[bot] merged 60 commits into
flutter:mainfrom
leancodepl:feature/video-player-android-platform-view-support

FirentisTFW commented Jan 21, 2025•
edited
Loading

Uh oh!

matanlurey left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matanlurey left a comment

Uh oh!

camsim99 left a comment

Uh oh!

FirentisTFW commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

FirentisTFW commented Jan 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

matanlurey left a comment

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

FirentisTFW commented Mar 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

FirentisTFW commented Jan 21, 2025•
edited
Loading