Uh oh!
There was an error while loading. Please reload this page.
[webview_flutter_wkwebview] Fixes crash with nil WKFrameInfo.request - #8766
Merged
auto-submit[bot] merged 6 commits intoMar 4, 2025
Merged
Conversation
WKFrameInfo.requestLinXunFeng added a commit
to LinXunFeng/packages
that referenced
this pull request
Mar 4, 2025
* main: [webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request` (flutter#8766) # Conflicts: # packages/webview_flutter/webview_flutter_wkwebview/CHANGELOG.md
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 4, 2025
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2025
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2025
flutter/packages@9e4684e...abba683 2025-03-05 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 1 (flutter/packages#8698) 2025-03-04 57854043+CaoGiaHieu-dev@users.noreply.github.com [go_router_builder]: Fix `The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737) 2025-03-04 pawel.jakubowski@leancode.pl [video_player_android] Platform view support (flutter/packages#8466) 2025-03-04 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request` (flutter/packages#8766) 2025-03-03 engine-flutter-autoroll@skia.org Manual roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8775) 2025-03-03 engine-flutter-autoroll@skia.org Roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8774) 2025-03-03 reidbaker@google.com [flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (flutter/packages#8760) 2025-03-03 neilself@gmail.com [google_sign_in] Add Android account name field as optional (platform interface changes) (flutter/packages#8735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
11 tasks
auto-submitBot
pushed a commit
that referenced
this pull request
May 28, 2025
…9330) This test was introduced in #8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
androidseb pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
flutter#8766) I manually verified with the example provided in the issue below that the `WKFrameInfo.request` also returns nil with the old Objective-C implementation. This crash seems to be caused by the Swift code crashing when it encounters a nil value that should be nonnull. Fixesflutter/flutter#163549
FMorschel pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
flutter#8766) I manually verified with the example provided in the issue below that the `WKFrameInfo.request` also returns nil with the old Objective-C implementation. This crash seems to be caused by the Swift code crashing when it encounters a nil value that should be nonnull. Fixesflutter/flutter#163549
FMorschel pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…lutter#9330) This test was introduced in flutter#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Jyndigo pushed a commit
to uesp/webview_flutter_x
that referenced
this pull request
Jun 24, 2025
…(#9330) This test was introduced in flutter/packages#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Ortes pushed a commit
to Ortes/packages
that referenced
this pull request
Jun 25, 2025
…lutter#9330) This test was introduced in flutter#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Jyndigo pushed a commit
to uesp/webview_flutter_x
that referenced
this pull request
Apr 15, 2026
…(#9330) This test was introduced in flutter/packages#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
flutter#8766) I manually verified with the example provided in the issue below that the `WKFrameInfo.request` also returns nil with the old Objective-C implementation. This crash seems to be caused by the Swift code crashing when it encounters a nil value that should be nonnull. Fixesflutter/flutter#163549
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#9330) This test was introduced in flutter#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
flutter#8766) I manually verified with the example provided in the issue below that the `WKFrameInfo.request` also returns nil with the old Objective-C implementation. This crash seems to be caused by the Swift code crashing when it encounters a nil value that should be nonnull. Fixesflutter/flutter#163549
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…lutter#9330) This test was introduced in flutter#8766 to fix a crash when `WKFrameInfo.request` returned nil. It appears that macOS 15.5 fixed `WKFrameInfo.request` so it no longer returns nil and instead returns an empty `URLRequest`. This updates the test to accept either `nil` or an empty `URLRequest`. Fixesflutter/flutter#169511. ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I manually verified with the example provided in the issue below that the
WKFrameInfo.requestalso returns nil with the old Objective-C implementation. This crash seems to be caused by the Swift code crashing when it encounters a nil value that should be nonnull.Fixesflutter/flutter#163549
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.