Uh oh!
There was an error while loading. Please reload this page.
[go_router_builder]: Fix The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' on path and query params - #8737
Merged
Conversation
The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' on path and query params| HotdogRouteWithEverything( | ||
| _$boolConverter(state.pathParameters['ketchup']!)!, | ||
| state.uri.queryParameters['mustard'], | ||
| state.uri.queryParameters['mustard']!, |
There was a problem hiding this comment.
Since mustard is optional, I believe it should not be asserted as non-null.
This issue is caused by the fact that the _stateValueAccess function uses element.isRequired as the condition for non-null assertion.
As in the PR I submitted, the condition should be !element.type.isNullableType && !element.hasDefaultValue.
ContributorAuthor
There was a problem hiding this comment.
@Karibash you right . im gonna update this . thanks for your comment
Closed
11 tasks
chunhtai
approved these changes
Mar 3, 2025
chunhtai
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just one minor comment
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com>
engine-flutter-autoroll added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 5, 2025
…e assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737)
github-merge-queueBot
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 5, 2025
flutter/packages@9e4684e...abba683 2025-03-05 robert.odrowaz@leancode.pl [camera_avfoundation] Tests backfilling - part 1 (flutter/packages#8698) 2025-03-04 57854043+CaoGiaHieu-dev@users.noreply.github.com [go_router_builder]: Fix `The argument type 'String?' can't be assigned to the parameter type 'String' because 'String?' ` on path and query params (flutter/packages#8737) 2025-03-04 pawel.jakubowski@leancode.pl [video_player_android] Platform view support (flutter/packages#8466) 2025-03-04 10687576+bparrishMines@users.noreply.github.com [webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request` (flutter/packages#8766) 2025-03-03 engine-flutter-autoroll@skia.org Manual roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8775) 2025-03-03 engine-flutter-autoroll@skia.org Roll Flutter from 842db35 to 04d3934 (4 revisions) (flutter/packages#8774) 2025-03-03 reidbaker@google.com [flutter_plugin_android_lifecycle] Uses flutter.compileSdkVersion, bumps minimum flutter version to 3.27 (flutter/packages#8760) 2025-03-03 neilself@gmail.com [google_sign_in] Add Android account name field as optional (platform interface changes) (flutter/packages#8735) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit
to androidseb/packages
that referenced
this pull request
Jun 8, 2025
…ed to the parameter type 'String' because 'String?' ` on path and query params (flutter#8737) Impact of this pr flutter#8405 , params with required enum cannot parse Fixed : flutter/flutter#164354
FMorschel pushed a commit
to FMorschel/packages
that referenced
this pull request
Jun 9, 2025
…ed to the parameter type 'String' because 'String?' ` on path and query params (flutter#8737) Impact of this pr flutter#8405 , params with required enum cannot parse Fixed : flutter/flutter#164354
creatorpiyush pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…ed to the parameter type 'String' because 'String?' ` on path and query params (flutter#8737) Impact of this pr flutter#8405 , params with required enum cannot parse Fixed : flutter/flutter#164354
bisor0627 pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
…ed to the parameter type 'String' because 'String?' ` on path and query params (flutter#8737) Impact of this pr flutter#8405 , params with required enum cannot parse Fixed : flutter/flutter#164354
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Impact of this pr #8405 , params with required enum cannot parse
Fixed : flutter/flutter#164354
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.