Skip to content

[camera_avfoundation] Tests backfilling - part 1 - #8698

Merged
auto-submit[bot] merged 7 commits into
flutter:mainfrom
leancodepl:feature/camera-tests-backfilling
Mar 5, 2025
Merged

[camera_avfoundation] Tests backfilling - part 1#8698
auto-submit[bot] merged 7 commits into
flutter:mainfrom
leancodepl:feature/camera-tests-backfilling

Conversation

@RobertOdrowaz

@RobertOdrowazRobertOdrowaz commented Feb 25, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

Backfills tests for the CameraPlugin class as part of flutter/flutter#119109

There are 3 new test files:

  • CameraPluginCreateCameraTests contains tests for the createCamera(withName) method
  • CameraPluginInitializeCameraTests contains tests for the initializeCamera method
  • CameraPluginForwardingMethodTests contains tests for all methods that only forward to the FLTCam instance without any (or almost any for startVideoRecording) logic extracted to separate PR

I've also added minimumExposureOffset and maximumExposureOffset to FLTCam to make both easier to mock and more consistent. Before the CameraPlugin class used the CaptureDevice methods directly by accessing the captureDevice field of the FLTCam class.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-tests-backfilling branch 2 times, most recently from cead82f to 1ad685dCompareFebruary 28, 2025 11:59
@RobertOdrowaz
RobertOdrowaz marked this pull request as ready for review February 28, 2025 12:11
hellohuanlin
hellohuanlin reviewed Feb 28, 2025
View reviewed changes

@hellohuanlinhellohuanlin left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i didn't finish reviewing. can you split the PR into multiple smaller PRs so it's easier to review? thanks

Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/AvailableCamerasTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift Outdated
Comment threadpackages/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginCreateCameraTests.swift Outdated
Comment thread...s/camera/camera_avfoundation/example/ios/RunnerTests/CameraPluginForwardingMethodTests.swift Outdated
@RobertOdrowaz
RobertOdrowazforce-pushed the feature/camera-tests-backfilling branch from 1ad685d to 72edba6CompareMarch 3, 2025 08:48
@RobertOdrowaz

RobertOdrowaz commented Mar 3, 2025

Copy link
Copy Markdown
ContributorAuthor

@hellohuanlin thanks for the review. I extracted the forwarding method tests from this PR and resolved most of the comments

@RobertOdrowazRobertOdrowaz added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 5, 2025
@auto-submit
auto-submitBot merged commit abba683 into flutter:mainMar 5, 2025
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
abba683[camera_avfoundation] Tests backfilling - part 1 (flutter/pac…
14a5783
…kages#8698)
@engine-flutter-autorollengine-flutter-autoroll mentioned this pull request Mar 5, 2025
Merged
github-merge-queueBot pushed a commit to flutter/flutter that referenced this pull request Mar 5, 2025
@engine-flutter-autoroll
Roll Packages from9e4684etoabba683(8 revisions) (#164630)
5ca20d8
flutter/packages@9e4684e...abba683
2025-03-05 robert.odrowaz@leancode.pl [camera_avfoundation] Tests
backfilling - part 1 (flutter/packages#8698)
2025-03-04 57854043+CaoGiaHieu-dev@users.noreply.github.com
[go_router_builder]: Fix `The argument type 'String?' can't be assigned
to the parameter type 'String' because 'String?' ` on path and query
params (flutter/packages#8737)
2025-03-04 pawel.jakubowski@leancode.pl [video_player_android] Platform
view support (flutter/packages#8466)
2025-03-04 10687576+bparrishMines@users.noreply.github.com
[webview_flutter_wkwebview] Fixes crash with nil `WKFrameInfo.request`
(flutter/packages#8766)
2025-03-03 engine-flutter-autoroll@skia.org Manual roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8775)
2025-03-03 engine-flutter-autoroll@skia.org Roll Flutter from
842db35 to 04d3934 (4 revisions) (flutter/packages#8774)
2025-03-03 reidbaker@google.com [flutter_plugin_android_lifecycle] Uses
flutter.compileSdkVersion, bumps minimum flutter version to 3.27
(flutter/packages#8760)
2025-03-03 neilself@gmail.com [google_sign_in] Add Android account name
field as optional (platform interface changes) (flutter/packages#8735)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.
To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
androidseb pushed a commit to androidseb/packages that referenced this pull request Jun 8, 2025
@RobertOdrowaz@androidseb
[camera_avfoundation] Tests backfilling - part 1 (flutter#8698)
e097b7e
Backfills tests for the `CameraPlugin` class as part of flutter/flutter#119109
There are 3 new test files:
- CameraPluginCreateCameraTests contains tests for the `createCamera(withName)` method
- CameraPluginInitializeCameraTests contains tests for the `initializeCamera` method
- ~CameraPluginForwardingMethodTests contains tests for all methods that only forward to the `FLTCam` instance without any (or almost any for `startVideoRecording`) logic~ extracted to separate PR
I've also added `minimumExposureOffset` and `maximumExposureOffset` to `FLTCam` to make both easier to mock and more consistent. Before the `CameraPlugin` class used the `CaptureDevice` methods directly by accessing the `captureDevice` field of the `FLTCam` class.
FMorschel pushed a commit to FMorschel/packages that referenced this pull request Jun 9, 2025
@RobertOdrowaz@FMorschel
[camera_avfoundation] Tests backfilling - part 1 (flutter#8698)
a029397
Backfills tests for the `CameraPlugin` class as part of flutter/flutter#119109
There are 3 new test files:
- CameraPluginCreateCameraTests contains tests for the `createCamera(withName)` method
- CameraPluginInitializeCameraTests contains tests for the `initializeCamera` method
- ~CameraPluginForwardingMethodTests contains tests for all methods that only forward to the `FLTCam` instance without any (or almost any for `startVideoRecording`) logic~ extracted to separate PR
I've also added `minimumExposureOffset` and `maximumExposureOffset` to `FLTCam` to make both easier to mock and more consistent. Before the `CameraPlugin` class used the `CaptureDevice` methods directly by accessing the `captureDevice` field of the `FLTCam` class.
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@RobertOdrowaz
[camera_avfoundation] Tests backfilling - part 1 (flutter#8698)
12d79c1
Backfills tests for the `CameraPlugin` class as part of flutter/flutter#119109
There are 3 new test files:
- CameraPluginCreateCameraTests contains tests for the `createCamera(withName)` method
- CameraPluginInitializeCameraTests contains tests for the `initializeCamera` method
- ~CameraPluginForwardingMethodTests contains tests for all methods that only forward to the `FLTCam` instance without any (or almost any for `startVideoRecording`) logic~ extracted to separate PR
I've also added `minimumExposureOffset` and `maximumExposureOffset` to `FLTCam` to make both easier to mock and more consistent. Before the `CameraPlugin` class used the `CaptureDevice` methods directly by accessing the `captureDevice` field of the `FLTCam` class.
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@RobertOdrowaz
[camera_avfoundation] Tests backfilling - part 1 (flutter#8698)
1d908ac
Backfills tests for the `CameraPlugin` class as part of flutter/flutter#119109
There are 3 new test files:
- CameraPluginCreateCameraTests contains tests for the `createCamera(withName)` method
- CameraPluginInitializeCameraTests contains tests for the `initializeCamera` method
- ~CameraPluginForwardingMethodTests contains tests for all methods that only forward to the `FLTCam` instance without any (or almost any for `startVideoRecording`) logic~ extracted to separate PR
I've also added `minimumExposureOffset` and `maximumExposureOffset` to `FLTCam` to make both easier to mock and more consistent. Before the `CameraPlugin` class used the `CaptureDevice` methods directly by accessing the `captureDevice` field of the `FLTCam` class.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hellohuanlinhellohuanlinhellohuanlin approved these changes
@stuartmorgan-gstuartmorgan-gAwaiting requested review from stuartmorgan-g

Assignees

No one assigned

Labels

autosubmitMerge PR when tree becomes green via auto submit Appp: cameraplatform-iosplatform-macos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RobertOdrowaz@hellohuanlin