Uh oh!
There was an error while loading. Please reload this page.
chore(trace): move trace types into isomorphic/trace/versions - #42444
chore(trace): move trace types into isomorphic/trace/versions#42444Dmitry Gozman (dgozman) wants to merge 2 commits into
Conversation
- move `trace.ts` to `isomorphic/trace/versions/traceV9.ts`, inlining `snapshot.ts` - move `har.ts` next to it, and inline it into `traceV8.ts` - add `isomorphic/trace/trace.ts` re-exporting the latest version, use it everywhere - drop the now empty `packages/trace` and its `@trace` alias - fold `_normalizeResourceReferences` into `_modernize_8_to_9`
- rename `VideoTraceEvent.timestampOrigin` to `timestamp`, add `pageId` - add `pageId` and `timestamp` to `ScreenshotTraceEvent` and `AriaSnapshotTraceEvent` - adjust the new timestamps in `adjustMonotonicTime()`
Test results for "tests 1"5 flaky51248 passed, 1240 skipped Merge workflow run. |
Test results for "MCP"4 failed 8255 passed, 1361 skipped Merge workflow run. |
🟢 CI is clear — both failures are pre-existing flakesHi, I'm the Playwright bot and I took a first look at the CI failures here. This PR moves trace types around ( DetailsOverall: the "tests 1" report is green (5 within-run flakes, no failures). The "MCP" report has 4 reds, which collapse into 2 stories once grouped across OS/browser. Both are established, bimodal flakes. Pre-existing flake / infra
Each square is one run attempt (oldest → newest); 🟩 passed, 🟧 rescued on retry, 🟥 failed. Triaged by the Playwright bot - agent run |
Summary
packages/trace/src/trace.tstopackages/isomorphic/trace/versions/traceV9.ts, inliningsnapshot.ts; movehar.tsnext to it and inline it intotraceV8.ts.packages/isomorphic/trace/trace.tsthat re-exports the latest version, and use it across the codebase.packages/traceand the@tracealias are gone._normalizeResourceReferences()into_modernize_8_to_9(), since trace-relative paths were introduced in v9.VideoTraceEvent.timestampOrigintotimestampand addpageId; addpageIdandtimestamptoScreenshotTraceEventandAriaSnapshotTraceEvent.