Initial commit! :tada: by codito · Pull Request #1 · microsoft/testfx

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

codito · 2016-08-26T06:15:39Z

No description provided.

…WP specific APIs.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

The PR's recent introduction of `MockableReflectionOperations` (which implements the new generic interface methods by filtering results from `mock.Object.GetCustomAttributes(Assembly, typeof(Attribute))`) plus a couple of test-only mistakes left the Windows CI runs red on .NET FX 4.8, net8.0 and net9.0. This commit addresses both the failures and the two remaining unresolved Copilot review comments. Test fixes: - `TestAssemblySettingsProviderTests` (4 tests): the existing setups use `Setup(ro => ro.GetCustomAttributes(It.IsAny<Assembly>(), typeof(ParallelizeAttribute)))` but `MockableReflectionOperations` always passes `typeof(Attribute)` (matching production's `NotCachedReflectionAccessor` for assemblies), so those setups never matched and the tests saw a default `Workers = -1`. Switch the setups to `typeof(Attribute)`. - `ReflectionOperationsTests` (4 `GetTestPropertiesAsTraits*` tests): switched from `Should().Equal(new[] { new Trait(...) })` to `Should().BeEquivalentTo(new[] { new Trait(...) }, options => options.WithStrictOrdering())`. `Trait` does not override `Equals`, so the previous `Equal()` call performed reference comparison and always failed even when values matched. Review comment #2 (`TestableExtendedTestMethod` declared public in the global namespace): the type is already in the file-scoped `MSTestAdapter.PlatformServices.UnitTests.Services` namespace (the reviewer's claim about the global namespace is not accurate with the file-scoped namespace declaration), but it does not need to be public — made it `internal`. Review comment #1 (`AttributeMockingHelper` treating class providers as `TypeInfo` rather than `Type`): investigated and confirmed the premise is incorrect. On all supported runtimes (.NET Framework 4.5+ and .NET Core 1.0+), `RuntimeType` derives from `TypeInfo`, so `typeof(Foo) is TypeInfo` is `true` and the class-level branch in `AttributeMockingHelper.GetCustomAttributesNotCached` is reachable. Verified locally with a small repro on net8.0. No change needed. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…t globs Root cause of the broken main build: the acceptance source-gen build harness let a multi-project asset's leftover reflection outputs pollute the later source-gen build. TestAssetFixtureBase builds each asset twice in the same directory: first the reflection build (default bin/Release), then the source-gen build (bin/obj redirected to a *SourceGen sub-folder). For a multi-project asset (e.g. AssemblyFixtureProviderAcceptance, whose test project references ProviderLibrary), the reflection build leaves ProviderLibrary/bin/Release/<tfm>/*.dll on disk. When the source-gen build then evaluates the host project, the SDK's default item globs pulled those stray DLLs in as None items, and RAR treated a wrong-TFM copy (a net10.0 MSTest.TestFramework.Extensions.dll, assembly version 9.0.0.0) as a candidate for the net8.0 leg -> MSB3277, which MSBuildTreatWarningsAsErrors promotes to an error, failing the fixture's ClassInitialize. The injected props already re-excluded bin/obj, but only at the asset root (bin/**;obj/**), which does not match the nested ProviderLibrary/bin/**. Broaden the re-exclusion to **/obj/**;**/bin/** so a referenced project's leftover reflection outputs stay out of the source-gen build's globs. The reflection build (#1) is unaffected because at its evaluation time the referenced project's bin is still empty; only the later source-gen build (#2) runs in a directory polluted by #1. This is the proper harness fix; the AssemblyFixtureProvider opt-out is no longer needed, so the asset is restored to source-gen coverage. Verified by running the AssemblyFixtureProvider acceptance tests (reflection + source-gen builds) green across net462/net8.0/net10.0. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Arun Mahapatra added 6 commits August 25, 2016 20:54

Initial commit.
7b18e11

Add scripts directory.
fe0998b

Remove object model source code.
c33c295

Build unit tests.
bc5bac1

Port WindowsPhone platform services to Profile259 since there are no …
7638aec
…WP specific APIs.

Remove template projects.
5cba0a7

codito merged commit 73f7ced into masterAug 26, 2016

codito deleted the dev branch August 26, 2016 06:16

Jayarani garg (jayaranigarg) mentioned this pull request Dec 14, 2018
Test Adapter: parametrized tests are discovered/logged to data collector as 1 test (no information about specific parameters) #340
Closed

Medeni Baykal (Haplois) added a commit to Haplois/testfx that referenced this pull request Nov 24, 2020
PR fixes batchmicrosoft#1
869f4ea

BKQc (bkqc) mentioned this pull request Aug 6, 2021
Empty string is passed as null with DataRowAttribute and DynamicData #938
Closed

Amaury Levé (Evangelink) mentioned this pull request Mar 3, 2026
MSTEST0037: Does not detect Assert.IsTrue(collection.Contains(item)) when Contains is a LINQ extension method #7486
Closed

github-actionsBot mentioned this pull request Apr 25, 2026
[Lean Squad] feat(fv): Task 2 — informal spec for CommandLineParser.TryUnescape #7830
Closed

This was referenced May 16, 2026
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed
RFC 014 - Command-line option mappings #8501
Merged
perf: reduce TreeNodeFilter allocations via IReadOnlyList and ReadOnlySpan #8238
Closed

This was referenced May 27, 2026
MSTEST0005: Stop reporting on fields of type TestContext #8629
Merged
Read CLI options from testconfig.json via IConfiguration (#6349) #8664
Merged

This was referenced Jun 16, 2026
RFC 018: Artifact post-processing for dotnet test (MTP) #9187
Merged
Add source NuGet package for the dotnet test wire contract (follow-up to #9218) #9231
Merged

This was referenced Jul 5, 2026
Resolve source-host anchor assemblies by name (Phase 6e-4c1) #9630
Merged
Drop the ObjectModel package reference from PlatformServices (Phase 7 capstone) #9633
Merged

Amaury Levé (Evangelink) mentioned this pull request Jul 9, 2026
Fix #9762: share RunSettings/TestRunParameters provider logic between MSTest adapter and VSTestBridge via dependency-free linked source #9775
Merged

This was referenced Jul 9, 2026
Remove duplicated #if NETCOREAPP / #else primitives in BaseSerializer #9776
Merged
Make DynamicData trimming/NativeAOT-safe via DynamicallyAccessedMembers #9832
Merged
Allow IPC named pipe directory to be overridden on Unix #9846
Merged

Amaury Levé (Evangelink) mentioned this pull request Jul 27, 2026
Add parallel-safety audit agentic workflow for MSTest test suites (⚠️ requires lock generation on aligned toolchain) #10252
Merged

github-actionsBot mentioned this pull request Aug 26, 2026
Use generated descriptors for MTP discovery #10777
Merged