Changes to move to Om 11.0 nuget pacakge. by AbhitejJohn · Pull Request #5 · microsoft/testfx

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:36Z

Changes to move to OM 11.0 nuget pacakge.
Ensured that few tests which are not getting discovered are discovered now.

- Ensured that few tests which are not getting discovered are discovered now.

Abhitej John (AbhitejJohn) · 2016-09-01T15:03:48Z

Jayarani garg (@jayaranigarg)

Jayarani garg (jayaranigarg) · 2016-09-02T08:15:00Z

Looks good

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…osoft#5) The two source-location tests hard-coded the physical line numbers of their throw statements (line=19/40) and relied on the real repo checkout + SystemFileSystem, so any edit above the throws or a relocated/packaged layout would break them. - Compute the throw line dynamically via a CaptureException helper + [CallerLineNumber] so edits elsewhere in the file no longer shift a hard-coded expectation. - Inject a mock IFileSystem (every file "exists") so resolution no longer depends on the source file physically being present. - Assert the resolved file suffix / line / escaping instead of a full checkout-coupled absolute path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

- Changes to move to Om 11.0 nuget pacakge.
43798ff
- Ensured that few tests which are not getting discovered are discovered now.

Fixing merge conflicts.
58b0d22

Abhitej John (AbhitejJohn) merged commit 5068aab into microsoft:masterSep 2, 2016

Abhitej John (AbhitejJohn) deleted the omnugetmigrateandtestfix branch September 2, 2016 08:27

This was referenced May 11, 2026
[Lean Squad] feat(fv): Task 2 + Task 9 — CommandLineOptionsValidator informal spec & CI simplification #8105
Merged
Brainstorm on ideas for more AzDO extensions in MTP #5951
Closed

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Aug 2, 2026
Split TerminalTestReporter.Summary.cs into focused partial files #10387
Merged

Azat Mukhametshin (azat-msft) mentioned this pull request Aug 18, 2026
Show failure details in GitHub Actions step-summary collapsible sections #10633
Merged

Uh oh!

Conversation

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Jayarani garg (jayaranigarg) commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Jayarani garg (jayaranigarg) commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Jayarani garg (jayaranigarg) commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Jayarani garg (jayaranigarg) commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Abhitej John (AbhitejJohn) commented Sep 1, 2016

Uh oh!

Jayarani garg (jayaranigarg) commented Sep 2, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants