Bug Fix#233637 : DataSource tests name is not getting appended by "(Data Row *)" by jayaranigarg · Pull Request #7 · microsoft/testfx

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) · 2016-09-06T11:13:33Z

No description provided.

Abhitej John (AbhitejJohn) · 2016-09-06T13:09:55Z

How would this work for tests adorned with a DataRow?

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:41Z

 {
 this.Outcome = testFailedException.Outcome;
 this.ErrorMessage = testFailedException.Message;
+ DatarowIndex = -1;


nit: Just call the default constructor with a this() for this ctor and the next.

Abhitej John (AbhitejJohn) · 2016-09-06T13:59:54Z

👍

Add test script to run unit tests using local vstest.console runner.

- Fix#1: Replace hardcoded 'Expected all elements...' with AllMatchPredicateFailNew resource - Fix#2: Remove 11 dead resource strings (ContainsFail, StartsWithFail, EndsWithFail, IsMatchFail, IsNotMatchFail, DoesNotEndWithFail, DoesNotStartWithFail, AssertThatFailedFormat, AssertThatMessageFormat, AssertThatDetailsPrefix, CollectionEqualReason) - Fix#3: Replace bare catch with catch (Exception) in TryEvaluateFormatted - Fix#5: Type-check StartsWith/EndsWith/Contains to only match string methods - Fix#6: Add explicit ellipsis sentinel handling in FormatCallSite - Fix#7: Fix grammar 'Both collection contain same elements' -> 'Both collections contain the same elements'

…ask 3) 🔬 Lean Squad — formal verification artifact Target: TreeNodeFilter.MatchFilterPattern (Target #7, Phase 2→3) File: formal-verification/lean/FVSquad/TreeNodeFilter.lean ## What's included - FilterExpr inductive type modelling the C# FilterExpression hierarchy (leaf/nop/and/or/not/withProps constructors) - Mutual recursive evaluators: evalFilter, evalFilterAll, evalFilterAny mirroring the MatchFilterPattern switch statement - 12 definitional @[simp] equation lemmas (proved via rw [*.eq_def]) - 2 De Morgan helper lemmas (proved by induction on List FilterExpr) - 12 Boolean-algebra theorems B1-B12 from the informal spec (all proved, no sorry) - 7 additional structural properties (proved) ## Proof status All 21 theorems are proved. No sorry. lake build passes clean. ## Approximations - matchesGlob is an opaque Bool-valued axiom (real impl uses Regex) - Property matching abstracted as String -> Bool inside withProps - MatchesFilter (public entry) not modelled in this PR ## Infrastructure changes - lakefile.toml: removed Mathlib dependency (firewall blocks cache) - lean-toolchain: updated v4.14.0 -> v4.29.1 (stable) - FVSquad.lean: root module file created Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Fix stale 21-dimension references throughout the doc now that the count is 22 (lines: 'Assess all 21 dimensions...', batching math '4 batches for 21 dimensions, last batch has 3' -> 'last batch has 4', summary table denominator 'N/21' -> 'N/22', example footers '19/21' and '21/21' updated, MSBuild supplemental section now says it is 'not a 23rd dimension'). * Perf rule #7: clarify the cross-TFM-safe fix. `MemoryMarshal.CreateReadOnlySpan(ref ch, 1)` with the `ReadOnlySpan<char>` overload of `Encoding.GetBytes` is not universally available, and `ref ch` cannot be applied to a `foreach` iteration variable. Recommend a single `char[1]` declared outside the loop (works on every TFM), with `stackalloc char[1]` + Span overload as the net6+ alternative. * Split former rule #8 in two: #8 (PowerShell ` += `) and #9 (C# `result = result.Concat(page).ToArray()`). The reviewer correctly noted that `array +=` is PowerShell-specific and lumping both forms under one rule confuses C#-only reviewers. * IPC rule #5: add the explicit bounds checks (`charCount > 0 && charCount < input.Length`) before indexing `input[charCount - 1]`. Without them the rule's own recommended fix would throw on truncate-to-zero inputs. * PowerShell rule #6: stop suggesting `catch { \$failures += '...' }` which reintroduces the O(n^2) accumulation defect called out by rule #2. Recommend a `List[string]` + `.Add()` instead. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…iew microsoft#7) GitHubActionsReporter previously implemented only ITestSessionLifetimeHandler and emitted ::endgroup:: unconditionally, relying purely on registration order. Mirror the deliberate engineering of AzureDevOpsLogGroupReporter: - Also implement IDataConsumer with a no-op ConsumeAsync so OnTestSessionFinishingAsync runs in the consumer phase (after producer-only handlers), and register it last as a data consumer so the closing ::endgroup:: wraps all other reporters' output. - Add a _groupOpened flag so ::endgroup:: is only emitted when a matching ::group:: was opened, and wrap both lifecycle callbacks in try/catch + LogWarning. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jayarani garg (jayaranigarg) added 5 commits August 31, 2016 15:15

Bug Fix #258333 with UT
255a16b

Correcting UT
86f8d13

Editing UT
6ce370b

Bug Fix #233637 with UT
9cd135f

Resolving merge conflicts
d3471e7

Jayarani garg (jayaranigarg) assigned Abhitej John (AbhitejJohn)Sep 6, 2016

Resolving merge conflicts
39a0423

AbhitejJohn reviewed Sep 6, 2016
View reviewed changes

Addressing PR comments
97d3eb9

Jayarani garg (jayaranigarg) merged commit 56ec30e into microsoft:masterSep 6, 2016

Jayarani garg (jayaranigarg) deleted the bug branch September 6, 2016 14:11

Sarabjot Singh (singhsarab) pushed a commit to singhsarab/testfx that referenced this pull request Apr 8, 2019
Merge pull requestmicrosoft#7from codito/test
3e52716
Add test script to run unit tests using local vstest.console runner.

CopilotAI mentioned this pull request Apr 29, 2026
[Lean Squad] feat(fv): Task 2 — informal spec for CommandLineParser.ParseOptionAndSeparators #7919
Merged

Amaury Levé (Evangelink) mentioned this pull request May 7, 2026
[Lean Squad] feat(fv): Task 3+9 — Lean 4 formal spec for TreeNodeFilter.MatchFilterPattern + CI fix #8054
Closed

This was referenced May 22, 2026
Localized file check-in by OneLocBuild Task: Build definition ID 1218: Build ID 2981612 #8486
Merged
Localized file check-in by OneLocBuild Task: Build definition ID 1218: Build ID 2982331 #8510
Merged

CopilotAI mentioned this pull request Jun 7, 2026
[expert-reviewer] Add PowerShell hygiene dimension + threading/perf/IPC clarifications #8898
Merged

Amaury Levé (Evangelink) mentioned this pull request Jun 8, 2026
Add Microsoft.Testing.Extensions.CtrfReport extension (CTRF reporter) #8903
Merged