Uh oh!
There was an error while loading. Please reload this page.
Restore TerminalResources translations wiped by OneLocBuild (#9254) - #9261
Conversation
OneLocBuild check-in #9254 (commit 2b13b0d) regressed all 13 TerminalResources.*.xlf files, resetting every translated entry from state="translated" back to state="new" with English targets. This is the same regression #9248 caused, previously fixed by #9252. As a result the localized test-run summary (e.g. French 'Résumé de série de tests : Réussite!') rendered in English, failing the acceptance LocalizationTests / LocalizationFailingTests on every TFM on both Linux and Windows (build 3004049 on main). Restore the 13 xlf files to their pre-#9254 state (2b13b0d^). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
Restores localized terminal reporter strings for Microsoft.Testing.Platform by reverting the TerminalResources.*.xlf satellite translation files from the OneLocBuild-regressed “English + state=new” content back to their translated targets, unblocking LocalizationTests/LocalizationFailingTests acceptance runs.
Changes:
- Restore translated
<target state="translated">…</target>entries across the 13TerminalResources.*.xlffiles. - Revert the OneLocBuild regression that caused terminal summary text to fall back to English for non-English locales.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.cs.xlf | Restores Czech terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.de.xlf | Restores German terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.es.xlf | Restores Spanish terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.fr.xlf | Restores French terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.it.xlf | Restores Italian terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ja.xlf | Restores Japanese terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ko.xlf | Restores Korean terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.pl.xlf | Restores Polish terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.pt-BR.xlf | Restores Portuguese (Brazil) terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ru.xlf | Restores Russian terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.tr.xlf | Restores Turkish terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.zh-Hans.xlf | Restores Chinese (Simplified) terminal-resource translations for terminal reporter output. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.zh-Hant.xlf | Restores Chinese (Traditional) terminal-resource translations for terminal reporter output. |
Copilot's findings
- Files reviewed: 13/13 changed files
- Comments generated: 13
| <file datatype="xml" source-language="en" target-language="cs" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="de" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="es" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="fr" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="it" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="pt-BR" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="ru" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="tr" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="zh-Hans" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
| <file datatype="xml" source-language="en" target-language="zh-Hant" original="../TerminalResources.resx"> | ||
| <body> | ||
| <trans-unit id="Aborted"> | ||
| <trans-unit id="Aborted"> |
Amaury Levé (Evangelink)
left a comment
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
Expert Review — 22-Dimension Analysis
This PR restores 13 TerminalResources.*.xlf files to their pre-#9254 state, changing 481 translation entries across all language files from state="new" (English fallback) back to state="translated" (proper localized text). The remaining 7 state="new" entries per file are genuinely new/untranslated strings (e.g. TerminalAnsiOptionDescription, TerminalProgressHeartbeat, TerminalProgressSlowTest), which is correct.
Verdict Table
| # | Dimension | Severity | Status | Notes |
|---|---|---|---|---|
| 1 | Algorithmic Correctness | MAJOR | ✅ Clean | Correctly targets root cause symptom (481 state+content entries changed; 7 genuinely new strings left as-is per file). Byte-for-byte revert to last CI-passing state is verified. |
| 2 | Threading & Concurrency | BLOCKING | ➡️ N/A | No code changes. |
| 3 | Security & IPC Contract Safety | BLOCKING | ➡️ N/A | XLF files introduce no security surface. |
| 4 | Public API & Binary Compatibility | BLOCKING | ➡️ N/A | No API surface changes; satellite assemblies are rebuilt by MSBuild. |
| 5 | Performance & Allocations | MAJOR | ➡️ N/A | No code changes. |
| 6 | Cross-TFM Compatibility | MAJOR | ✅ Clean | Satellite assemblies generated from XLF work across all TFMs; the pre-regression behavior is restored. |
| 7 | Resource & IDisposable Management | MAJOR | ➡️ N/A | No code changes. |
| 8 | Defensive Coding at Boundaries | MAJOR | ➡️ N/A | No code changes. |
| 9 | Localization & Resources | MAJOR | See detailed analysis below. | |
| 10 | Test Isolation | MAJOR | ➡️ N/A | No test code changes. |
| 11 | Assertion Quality | MAJOR | ➡️ N/A | No test code changes. |
| 12 | Flakiness Patterns | BLOCKING | ➡️ N/A | No test code changes. |
| 13 | Test Completeness & Coverage | MAJOR | ✅ Clean | Existing LocalizationTests / LocalizationFailingTests acceptance tests cover the fixed behavior end-to-end. |
| 14 | Data-Driven Test Coverage | MODERATE | ➡️ N/A | No test changes. |
| 15 | Code Structure & Simplification | MODERATE | ➡️ N/A | XML content only. |
| 16 | Naming & Conventions | MINOR | ➡️ N/A | N/A for XLF files. |
| 17 | XML/JSON/YAML Configuration | MODERATE | ✅ Clean | Valid XLIFF 1.2 structure; all <trans-unit> elements are well-formed. |
| 18 | Error Messages & Diagnostics | MODERATE | ➡️ N/A | No new user-facing strings introduced. |
| 19 | Changelog / Release Notes | MINOR | ✅ Clean | Acceptable to skip CHANGELOG for a CI-hotfix/revert. |
| 20 | Follow-up TODOs | MINOR | No tracking issue referenced for the recurring OneLocBuild regression. See below. | |
| 21 | Documentation | MINOR | ➡️ N/A | No public API changes. |
| 22 | PowerShell Script Quality | MINOR | ➡️ N/A | No .ps1 changes. |
Dimension 9 — Localization & Resources (detailed)
Emergency exception to the "never manually edit XLF" rule is appropriate here. The automated OneLocBuild pipeline is the regression source, not a developer editing the wrong file. Running dotnet msbuild /t:UpdateXlf would have been insufficient because it regenerates from the .resx (which was not regressed) — it does not know which translation targets were previously correct. The byte-for-byte revert to a CI-passing commit is the only reliable fix path.
The restoration is semantically correct:
- 37
state="translated"entries per file (481 total across 13 files), all with appropriate localized text verified against the pre-#9254 commit. - 7
state="new"entries per file remain — these are genuinely newer strings (TerminalAnsiOptionDescription,TerminalNoProgressOptionDescription,TerminalProgressHeartbeat,TerminalProgressHeartbeatActiveSuffix,TerminalProgressOptionDescription,TerminalProgressOptionInvalidArgument,TerminalProgressSlowTest) that have not yet been through the localization cycle, and leaving them asstate="new"is correct.
Minor: indentation inconsistency. The restored files use 12-space indentation for <trans-unit> opening tags (e.g. <trans-unit id="Aborted">) whereas the OneLocBuild-generated content used 6 spaces. This is cosmetic and does not affect XML parsing or satellite assembly generation, but it means the next OneLocBuild PR will produce additional indentation noise in the diff alongside any genuine translation updates.
Dimension 20 — Recurring OneLocBuild Regression (follow-up)
This is the second occurrence of the exact same regression: #9248 (OneLocBuild) → fixed by #9252; then #9254 (OneLocBuild) → fixed by this PR.
The root cause — OneLocBuild resetting state="translated" entries to state="new" with English targets — has not been addressed. Without a systemic fix, the pattern will recur on the next OneLocBuild check-in. Recommended follow-ups:
- Open a tracking issue for the OneLocBuild pipeline configuration that causes it to overwrite valid translations. The issue should be shared with the OneLocBuild/localization team to investigate why the pipeline degrades previously-translated entries.
- Consider a CI guard: a repo lint step (e.g. a PowerShell or bash check in the build pipeline) that asserts "no
TerminalResources.*.xlffile may contain a<target state="new">value that exactly matches its<source>value unless the source was genuinely never translated." This would detect OneLocBuild regressions automatically before they reachmain.
Recommendation
LGTM as a targeted emergency hotfix. The change is correct, minimal in scope, and the emergency exception to the XLF editing rule is fully justified. The one actionable follow-up is opening a tracking issue for the systemic OneLocBuild regression so it does not happen a third time.
Problem
The
microsoft-testfxrolling build onmain(build 3004049) failed with persistent acceptance-test failures across every TFM on both Linux and Windows:LocalizationTests.Execution_WithFrenchLocale_OutputContainsTranslatedSummaryLocalizationTests.Execution_WithSpanishLocale_OutputContainsTranslatedSummaryLocalizationTests.Execution_WithTestingPlatformUILanguage_TakesPrecedenceOverDotnetCLILocalizationFailingTests.Execution_WithFailingTest_OutputContainsTranslatedFailureSummaryThe test host emitted the English summary (
Test run summary: Passed!) instead of the localized one (e.g. FrenchRésumé de série de tests : Réussite!), so the assertions failed and the test suite failed all 4 retry attempts.Root cause
OneLocBuild check-in #9254 (commit
2b13b0d2d) regressed all 13TerminalResources.*.xlffiles, resetting every entry fromstate="translated"(with real translations likeÉchec/Réussite) back tostate="new"with English targets.TerminalTestReporterreads these strings, so the rendered summary fell back to English.This is the exact same regression that #9248 caused and #9252 fixed.
Fix
Restore the 13
TerminalResources.*.xlffiles to their pre-#9254 state (2b13b0d2d^). The change is byte-for-byte identical to the last known-good (CI-passing) state, and thestate="new"count matches the pre-regression baseline (only genuinely-untranslated strings remain).Microsoft.Testing.Platformbuilds clean (0 warnings) with valid satellite assemblies.