Uh oh!
There was an error while loading. Please reload this page.
Restore TerminalResources translations wiped by OneLocBuild (#9262) - #9288
Merged
Conversation
OneLocBuild check-in #9262 reset every translated TerminalResources xlf entry back to state="new" with English targets, breaking LocalizationTests and LocalizationFailingTests on main (build 3004243). Restore the 13 xlf files to their known-good state from d2ed2f8 (post-#9261). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restores Microsoft.Testing.Platform Terminal reporter localization by reverting the TerminalResources.*.xlf satellite translation files from an unintended OneLocBuild reset (translated entries reverted to state="new" with English targets), which was breaking localization-focused test runs.
Changes:
- Restores translated
<target state="translated">…</target>values across 13TerminalResources.*.xlffiles so localized terminal output no longer falls back to English. - Reverts OneLocBuild-introduced translation-state regressions that caused
LocalizationTests/LocalizationFailingTestsfailures.
Show a summary per file
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.cs.xlf | Restores Czech terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.de.xlf | Restores German terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.es.xlf | Restores Spanish terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.fr.xlf | Restores French terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.it.xlf | Restores Italian terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ja.xlf | Restores Japanese terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ko.xlf | Restores Korean terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.pl.xlf | Restores Polish terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.pt-BR.xlf | Restores Portuguese (Brazil) terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.ru.xlf | Restores Russian terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.tr.xlf | Restores Turkish terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.zh-Hans.xlf | Restores Chinese (Simplified) terminal resource translations. |
| src/Platform/Microsoft.Testing.Platform/OutputDevice/Terminal/xlf/TerminalResources.zh-Hant.xlf | Restores Chinese (Traditional) terminal resource translations. |
Copilot's findings
- Files reviewed: 13/13 changed files
- Comments generated: 13
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Přerušeno</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Abgebrochen</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Anulado</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Abandonné</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Operazione interrotta</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Anulado</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Прервано</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">Durduruldu</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">已中止</target> | ||
| <note /> | ||
| </trans-unit> |
Comment on lines
+5
to
9
| <trans-unit id="Aborted"> | ||
| <source>Aborted</source> | ||
| <target state="new">Aborted</target> | ||
| <target state="translated">已中止</target> | ||
| <note /> | ||
| </trans-unit> |
Amaury Levé (Evangelink)
left a comment
MemberAuthor
There was a problem hiding this comment.
Note
🤖 Automated review by GitHub Copilot. Posted via a maintainer's GitHub token, so it appears under their account — the account owner did not write or approve this content personally. Generated by the Expert Code Review workflow. To request a follow-up action, reply by tagging @copilot directly.
This PR only changes 13 .xlf files (pure translation restoration). Dimensions 1–8, 10–22 are all N/A — no C# code, no public API, no tests, no build infrastructure, no scripts were touched. Two dimensions have notes:
| # | Dimension | Verdict |
|---|---|---|
| 9 | Localization & Resources | 🟡 1 MODERATE (noted below) |
| 21 | Scope & PR Discipline | 🟡 1 MODERATE (noted below) |
✅ 20/22 dimensions clean.
Dimension 9 — Localization & Resources: valid exception to the "never hand-edit XLF" policy
The repository policy says never manually edit *.xlf files — they are generated by dotnet msbuild /t:UpdateXlf. This PR does hand-edit them, which normally would be flagged. However, this is the only correct response to a OneLocBuild automation regression:
UpdateXlfgenerates XLF entries from the English.resxsource — it cannot recover lost translations.- The OneLocBuild check-in (#9262 / commit
a890307f6) reset every entry tostate="new"with English targets, discarding all translator work. - The only recovery path is to restore from a known-good commit (
d2ed2f853), which is exactly what this PR does. - The PR description confirms the
.resxwas unchanged between the good commit and the wipe, so the restored XLF stays in sync. - All 481
state="new"lines are removed; all 481state="translated"lines are added — the restoration is structurally complete and internally consistent across all 13 language files.
This is a necessary, well-documented exception. No action needed on this PR; it is the correct fix.
Dimension 21 — Scope & PR Discipline: recurring regression warrants a tracking issue
The PR description notes this is the third occurrence of this same OneLocBuild regression pattern (#9248/#9254 → fixed by #9252/#9261; now #9262 → fixed by this PR). Each fix requires a manual rescue operation. To prevent a fourth recurrence, consider opening a tracking issue for one of:
- Fix the OneLocBuild pipeline configuration so it does not reset entries with existing translations back to
state="new"with English targets. - Add a CI gate (e.g., a check that fails if any XLF file in the PR contains
state="new"entries paired with a target that matches the English source verbatim) so future OneLocBuild regressions are caught before merge.
If such an issue already exists, linking it here would close the loop. If not, opening one would be a good follow-up to this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OneLocBuild check-in #9262 (commit a890307) reset every translated TerminalResources xlf entry back to
state="new"with English targets. This brokeLocalizationTestsandLocalizationFailingTestsonmain(build 3004243).Same regression previously seen in #9248/#9254 and fixed by #9252/#9261.
This PR restores the 13
TerminalResources.*.xlffiles to their known-good state from d2ed2f8. The owningTerminalResources.resxwas unchanged between the good commit and the wipe, so the restored xlf stay in sync.