fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName - #14575

Merged
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation
Sep 2, 2026
Merged

fix(lint): consolidate did-you-mean suggestion helpers into object-graph's shared nearestName#14575
baozhoutao merged 4 commits into
mainfrom
claude/issue-14268-lint-suggest-consolidation

Conversation

@claude

@claudeclaudeBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Fixes#14268

What changed

Four hand-copied "Did you mean?" helpers in packages/lint/src are now one shared helper. object-graph.ts's already-exported nearestName/suggestName gained the containment pre-pass that validate-widget-bindings.ts's private didYouMean carried, and the three private copies were deleted:

  • validate-object-references.ts — deleted its private suggest/distance, imports suggestName from ./object-graph.
  • validate-sortable-fields.ts — same.
  • validate-widget-bindings.ts — deleted its private didYouMean/levenshtein/suggest, imports suggestName from ./object-graph.
  • object-graph.tsnearestName now checks containment first (matching c.length/target.length when one contains the other, scored by length delta) before falling back to Levenshtein distance within the existing max(2, floor(len/3)) budget; suggestName and the private distance (the one surviving edit-distance body) are unchanged. Docblock rewritten to describe the now-shared behaviour instead of pointing at the "consolidating the three copies is recorded as a follow-up" note this card resolves.

This is the ruling's decision (comment 5502887598 on #14268): the containment pre-pass becomes nearestName's behaviour for every caller, including object-graph.ts's own two describeFieldPathVerdict call sites (:325/:342, both already routed through suggestName).

Hints newly supplied

None. A/B comparison on the same base tree (commit fed4fa409, no test file touched): the full @objectstack/lint suite run with the four files at their origin/main state (93 files / 2812 tests passed, 5 skipped) and again with the port applied — byte-identical pass/fail results. No existing suggestion assertion needed a hint text change; the containment pre-pass is additive but none of the three rules' current test fixtures happen to exercise a containment-eligible typo the edit-distance budget didn't already catch. Re-run on the final merged tree (after picking up unrelated upstream commits) also passes clean: 93 files / 2817 tests passed, 0 skipped (the skip-count change is from unrelated upstream work, not this PR).

Verification

$ git grep -n "function suggest\|function distance\|function levenshtein\|function didYouMean" \
packages/lint/src/validate-object-references.ts \
packages/lint/src/validate-sortable-fields.ts \
packages/lint/src/validate-widget-bindings.ts
# zero hits
  • pnpm --filter @objectstack/lint build — clean (dist emitted, no dangling references to the deleted functions).
  • pnpm --filter @objectstack/lint typecheck — clean (tsc --noEmit + check:test-typecheck).
  • pnpm --filter @objectstack/lint test — 93 files / 2817 tests passed on the final merged tree (commit referenced below).
  • pnpm lint narrowed to the 5 touched files (--format json): 0 errors, 1 informational warning (.changeset/*.md has no ESLint config — expected, not a finding). The repo's eslint.config.mjs enables no type-aware linting (no parserOptions.project anywhere), so this diff cannot move any untouched file's verdict — the narrowed run is a complete reading of this diff's lint surface, not a partial one.
  • Dispatch-gates union (28 commands derived from the touched-file surface) — all green except two expected NOT MEASURED (both require artifacts this local run cannot produce, not repo-scoped to this PR): check-test-completeness.mjs (needs a saved turbo run test log CI produces) and check:dual-build-cjs-loads (needs a full monorepo pnpm build, ~78 packages).

Changeset

.changeset/lint-suggest-name-consolidation.md@objectstack/lint: patch.

Out of scope

Per the ruling and the claim comment, the following private "did you mean?" copies in packages/lint/src are not touched by this PR — filed as follow-ups, listed in the report below with file:line for the PM to route:

  • validate-action-name-refs.ts:84 (distance) / :101 (suggest)
  • validate-ai-tool-references.ts:70 (distance) / :87 (suggest)
  • validate-chart-bindings.ts:83 (distance) / :100 (suggest)
  • validate-searchable-fields.ts:275 (suggest) / :289 (distance)
  • validate-translation-references.ts:159 (distance) / :186 (suggest)
  • validate-react-page-props.ts:167 (nearestKnown)
  • validate-rule-schema-formats.ts:266 (nearestRegisteredFormat)

Generated by Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

📓 Docs Drift Check

This PR changes 1 package(s): @objectstack/lint, touching 5 documentable anchor(s).

2 release-owned page(s) name something this change touched. These are read-only:

  • content/docs/releases/v16.mdx(via validateWidgetBindings (symbol, a top-level function))
  • content/docs/releases/v17.mdx(via validateWidgetBindings (symbol, a top-level function))

content/docs/releases/ is RELEASE-OWNED (AGENTS.md "Documentation Guardrails"): release
notes are written centrally at release time, and a code PR that edits them is the exact PR
that guardrail exists to stop. They are still audited — read-only. If one of them is actually
wrong, file an issue or open a dedicated docs-only PR; do not edit it here.

What this run could not see
  • 3 name(s) were too generic to anchor anything (single lowercase words)
  • the SDK route bridge reached 47 of 219 client-bound route-ledger rows — the other 172 have no registrar path: tail to select them, so pages documenting THEIR client methods cannot appear above, on this or any run. Of those 172: 14 are remediable by widening that discovery convention (an in-repo file declares the path; the convention did not scan it); 56 are structural — on a ledger where NOT ONE row is declared in-repo, so no discovery change reaches them at any price; 102 are undecided (no in-repo declaration, on a ledger that has other in-repo registrars — absence and an unreadable spelling are not distinguishable here). The rows themselves: node scripts/docs-audit/affected-docs.mjs --bridge-coverage
  • a page that states a rule by its inputs shares no identifier with the emitter that implements the rule, so an emitter-only diff cannot list it — not on this run and not on any run. Measured on fix(driver-sql): emit varchar(maxLength) for a text field a declared index keys on #11430: content/docs/protocol/objectql/types.mdx documents the text-family column mapping by the ObjectQL type names it maps FROM (text / textarea / html) while the diff changed createColumn; it went unlisted, and it was the page that diff falsified, in four places. No shared token exists to detect this on, so a rule your change carries has to be re-read by hand in the pages that restate it.

Coarse fallback — 5 page(s) merely mention a changed package (the pre-#9192 predicate, kept for the deliberately-wide backstop): node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1adpackageMentionDocs.

Which tree this was computed on

This run read content/docs from 9facf49a1b39d1800a237487f10ab7b34c4780de — the merge of head 17d9e56a01ced2fc12b588399641aebe3c34aafa into base 7286dd58e806ed321cbdfc23a1c455db8f80b1ad, which is what actions/checkout gives a pull_request run. Not the PR head.

A worktree cut from an older main holds a different content/docs, so re-deriving there can legitimately return a different list — that is a different tree, not a wrong row. To answer on the same tree:

# while this PR is open — GitHub drops the merge commit once it closes
git fetch origin 9facf49a1b39d1800a237487f10ab7b34c4780de && git checkout 9facf49a1b39d1800a237487f10ab7b34c4780de
# afterwards, rebuild it from the two parents, which stay fetchable
git fetch origin 7286dd58e806ed321cbdfc23a1c455db8f80b1ad 17d9e56a01ced2fc12b588399641aebe3c34aafa && git checkout -B drift-repro 7286dd58e806ed321cbdfc23a1c455db8f80b1ad && git merge --no-ff 17d9e56a01ced2fc12b588399641aebe3c34aafa
node scripts/docs-audit/affected-docs.mjs --json 7286dd58e806ed321cbdfc23a1c455db8f80b1ad

⚠️ That checkout carried uncommitted changes, so the commit above does not fully identify what was read.

Advisory only, and a precision-first one (#9192): a page is listed because it names a
symbol, wire route or SDK method this diff touched — not because it mentions a changed
package. Each row says which anchor put it there, so a wrong row is reportable rather than
merely annoying. To re-verify, run the docs-accuracy-audit workflow scoped to these files:
node scripts/docs-audit/affected-docs.mjs 7286dd58e806ed321cbdfc23a1c455db8f80b1ad → pass the list as
args.docs, on the commit named under Which tree this was computed on.

@github-actionsgithub-actionsBot added documentation Improvements or additions to documentation tooling labels Sep 2, 2026
@baozhoutao
baozhoutao marked this pull request as ready for review September 2, 2026 13:46
@baozhoutao
baozhoutao added this pull request to the merge queueSep 2, 2026
Merged via the queue into main with commit d754829Sep 2, 2026
35 checks passed
@baozhoutao
baozhoutao deleted the claude/issue-14268-lint-suggest-consolidation branch September 2, 2026 14:13
baozhoutao pushed a commit that referenced this pull request Sep 2, 2026
…suggestName
Follow-up to #14268/#14575. Five more validate-*.ts rules in packages/lint
carried a private suggest/distance pair, byte-for-byte re-deriving the
edit-distance-only budget object-graph.ts already exports as suggestName.
Tier 1 (validate-action-name-refs, validate-chart-bindings,
validate-searchable-fields): delete the private pair, import suggestName.
Tier 2 (validate-ai-tool-references, validate-translation-references): keep
the rule's own one-line pre-pass (the action_<name> tool-family prefix, and a
snake_case namespace-segment match — rule-local knowledge), then delegate the
fallback to suggestName instead of a private Levenshtein copy.
object-graph.ts's helper is untouched (#14268 already ruled it).
validate-react-page-props.ts and validate-rule-schema-formats.ts stay fenced
out — both are a different contract on purpose per #14577's triage.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentationImprovements or additions to documentationsize/mtooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[finding] suggest / distance ("did you mean?") is hand-copied four times across packages/lint — the same shape #4330 already fixed for SYSTEM_FIELDS

2 participants

@baozhoutao@claude