Uh oh!
There was an error while loading. Please reload this page.
docs(i18n): name the measurement-widening race in check-i18n-coverage's header - #14799
Merged
baozhoutao merged 1 commit intoSep 3, 2026
Merged
Conversation
…'s header The DOWN-direction remedy read as "your diff improved something" when the usual cause was "main moved under you" — a PR that widens what this ratchet measures races every in-flight PR that changes what is measured, invisibly, because the instrument does not exist on main. Append one sentence to the remedy pointing the reader at merging main first, and name the class generally in the file's own header, alongside the campaign observation and the forward-looking exposure (app-crm, app-todo, bulkActions, datasets). Fixes#14729 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
baozhoutao
marked this pull request as ready for review
September 3, 2026 02:58
baozhoutao
enabled auto-merge
September 3, 2026 02:58
Contributor
Contributor
Contributor
Uh oh!
There was an error while loading. Please reload this page.
baozhoutao
deleted the
claude/issue-14729-i18n-coverage-ratchet-race-header
branch
September 3, 2026 04:51
This was referenced Sep 3, 2026
This was referenced Sep 3, 2026
This was referenced Sep 3, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#14729
What changed
scripts/check-i18n-coverage.mjsonly, two additions, adopted as filed bytriage (comment 5518536856) — no baseline split, no dropped DOWN direction,
no computed number.
1. One sentence on the DOWN-direction remedy (was
:1340-1341)Before:
After:
2. One header paragraph naming the class generally
Appended at the end of the file's header (which already opens with the #3370
narrative), stating the property in general form — not i18n-specific — plus
the campaign observation (the two collisions were not independent draws) and
the forward-looking exposure as of
224f8ea:app-showcase0 untranslatedrule messages remaining (that leg is finished);
app-crm5,app-todo4;bulkActions18 anddatasets62 nobody is currently working — any of thosestarting to move will race this gate the same way.
Diff
One file, comment/string additions only — no logic change, no baseline
movement.
Tests
pnpm check:i18n-coverage(self-test + real run) at674bb4afe8:check-i18n-coverage: OK (13 config(s), 691 baselined untranslated string(s), none new).— same 691 total as the issue's forward-exposure snapshot; no movement from
this comment/string-only edit.
node scripts/pm/dispatch-gates.mjs --repo objectstack-ai/objectstack --commands scripts/check-i18n-coverage.mjsderived 18 runnable gates for this file surface; all 18 ran, 17 green,
1 NOT MEASURED (
check-test-completeness.mjs— its own text: "PREREQUISITENOT MET… no local log… not a red, nothing here to fix").
needed updating.
Excluded (binding, per triage)
scripts/i18n-coverage-baseline.jsonuntouchedpackages/cli/**untouched ([finding]check:i18n-coveragecounts one untranslated action key more than once — 70 of the 691 baselined units are byte-identical duplicate findings #14728, separatedomain:clidefect)🤖 Generated with Claude Code
https://claude.ai/code/session_01WLJQhde67SeTccsmnBVarV
Generated by Claude Code