perf(clients): lease sidebar status by visibility

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.

[StiensWout]

Mounted sidebar rows kept VCS streams and linked pull request refreshes alive for five minutes, even after the rows left the viewport. With many unique worktrees, idle rows continued doing Git and provider work. This is item 07 of the performance opportunity audit.

Web and desktop rows now lease live status only while active or within 160 px of the sidebar viewport. Active and highlighted search rows always stay live. Mobile keeps its existing list virtualization and now preserves the last pull request badge separately while the shared live atom expires. VCS streams get a 10-second scroll grace and linked pull request detail queries get a 5-second idle TTL.

Measurements

Measured with the same isolated 50-row, 50-worktree fixture on the pre-change commit (b883fc066) and this commit. Scope counts come from the server's background-policy snapshot after the browser settled. The after run scrolled from row 01 to row 50, waited past the grace period, and selected row 50.

Metric	Before	After	Change
Live fixture VCS scopes	50	11	78% fewer
VCS idle retention	300 s	10 s	96.7% shorter
Linked PR detail idle retention	300 s	5 s	98.3% shorter

In this fixture, the change releases 39 offscreen VCS streams. That removes unnecessary Git status work and server/client subscription bookkeeping, while offscreen linked PR polling can stop after 5 seconds instead of remaining eligible for 5 minutes. The 78% figure is a measured live-scope reduction, not a CPU reduction claim.

Proof

The native-resolution sidebar GIF drives the real web client through the 50-row fixture, scrolls the full list, and opens row 50.

Verification

• pnpm exec vp test run packages/client-runtime/src/state/vcs.test.ts packages/client-runtime/src/state/pullRequests.test.ts apps/web/src/components/Sidebar.logic.test.ts apps/web/src/components/ThreadStatusIndicators.test.ts apps/mobile/src/features/threads/threadListV2.test.ts (192 tests)
• pnpm --filter @t3tools/client-runtime typecheck
• pnpm --filter @t3tools/web typecheck
• pnpm --filter @t3tools/mobile typecheck
• targeted lint and diff checks

Changes and PR text by GPT-5.6 Sol in T3 Code with the Codex harness.

---

Note

Low Risk
Performance-focused subscription gating with retained UI snapshots; no auth or data-model changes, though off-screen rows may show slightly stale PR/git badges until scrolled back into range.

Overview
Sidebar thread rows no longer keep live VCS status and linked PR detail subscriptions for every mounted row. A new visibility lease (useSidebarRowSubscriptionLease) turns those queries on only when the row is active or within 160px of the scroll viewport; useRetainedValue keeps the last git/PR values so PR badges and branch metadata do not flash empty when the lease drops.

Client-runtime shortens idle teardown for off-lease consumers: VCS status streams use a 10s idle TTL (was the default 5 min), and linked PR detail queries use 5s.

Mobile adds a bounded (500 entry) thread PR snapshot atom so virtualized list rows can show the last PR presentation while shared live atoms expire, without one atom per thread forever.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Lease sidebar VCS and linked-PR status queries by viewport visibility

• Adds useSidebarRowSubscriptionLease to gate VCS status and linked-PR queries on active or near-viewport rows (160px overscan via IntersectionObserver, with a fallback that keeps leases alive)
• Adds useRetainedValue so rows continue rendering the last non-null status keyed by environment and checkout identity while their live query is disabled
• Adds threadPrSnapshotsAtom, a 500-entry bounded cache on mobile that persists thread PR presentations across unmount/remount, with eviction of the oldest entries
• Adds idle TTLs to client-runtime atom families: 10s for VCS status (createVcsEnvironmentAtoms) and 5s for linked-PR detail (createLinkedPullRequestDetailAtomFamily)
• Behavioral Change: rows outside the active/near-viewport lease stop polling live git and linked-PR status and display retained snapshots instead; useThreadPr on mobile clears cached entries on definitive null results

^{Macroscope summarized 4faaad4.}

[macroscopeapp]

Both findings are about the new "keep the last status we rendered" behavior that backs the lease gating: the legacy row retains a snapshot that is not keyed to the PR it describes, and the V2 rows retain nothing at all, so the two sidebars now behave differently for the same lease transition.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This change alters production subscription lifecycles and gates VCS/pull-request status work on sidebar visibility across multiple clients, with retained snapshots masking unloaded state. An unresolved concrete identity-handling concern in the legacy sidebar also warrants human review.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Rebased onto main and pushed one commit on top of yours (4faaad4).

• Web: the three copies of the identity-keyed retention block in Sidebar.tsx and LegacySidebar.tsx now share one useRetainedValue hook in Sidebar.logic.ts. Same behavior, one place.
• Mobile: useThreadPr reads the shared snapshot map through a per-thread selector. Before, every row re-rendered when any row wrote its snapshot.

I verified the lease path: one IntersectionObserver per row, scoped to the scroll-area viewport with a 160 px rootMargin, callbacks only on intersection changes, disconnected on unmount. Active rows skip the observer. When the atom idles out, the registry's TTL sweep unmounts it, the RPC client sends Interrupt, and the server's Stream.ensuring(release) in VcsStatusBroadcaster drops the remote poller. Will merge when checks are green.

[cursor]

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[cursor]

Legacy sidebar uses strict null check for optional field

Low Severity

The retention key for visibleLinkedPullRequestStatus uses thread.linkedPullRequest === null (strict equality), but the display path at line 479 uses thread.linkedPullRequest == null (loose equality). Since linkedPullRequest is Schema.optional(Schema.NullOr(ThreadLinkedPullRequest)), it can be undefined. When undefined, the strict check is false, producing a non-null retention key (JSON.stringify([envId, undefined]) → '["envId",null]') for a thread that the display logic correctly treats as having no linked PR. This inconsistency breaks the identity contract — the key computation diverges from the display branch.

^{Reviewed by Cursor Bugbot for commit 4faaad4. Configure here.}

[t3dotgg]

Agent comment posted on behalf of @t3dotgg by Claude Fable 5.1.

Checked against source. No behavior difference. When linkedPullRequest is undefined, useLinkedThreadPullRequest returns null, so nothing is ever stored under the ["env",null] key, and the display branch on the next line takes the == null path and never reads visibleLinkedPullRequestStatus. A relink from a PR to undefined changes the key, so the old PR's badge and URL cannot leak. Leaving as is.