fix(web): keep generated muted foreground dimmer than entered text

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}

[flamboh]

Note

🤖 GPT-5.6 Sol on behalf of Oliver

Problem

Vivid generated themes used the primary-text solver for mutedForeground, so an already readable text color stayed unchanged. In dark themes, this made the attach icon, context-window meter icon, and "Context Window" popover heading as bright as primary text.

This is a follow-up to #9104, which corrected the same behavior for placeholders.

Fix

One line now generates mutedForeground with readableThemeText, matching managed themes and choosing the quietest mix that still clears the contrast minimum.

	Hex	Contrast vs canvas	Contrast vs muted
Before	#edecff	14.09:1	11.78:1
After	#9593aa	5.49:1	4.59:1

UI changes

Before

(note that the before shows old placeholder text because latest nightly hasn't rolled out with the changes from #9104)

After

Verification

• cd apps/web && npx vitest run src/themePalette.test.ts src/vscodeThemeImport.test.ts — passed, 2 files and 49 tests.
• vp lint apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed.
• vp fmt --check apps/web/src/themePalette.ts apps/web/src/themePalette.test.ts — passed, 2 files.
• cd apps/web && vp run typecheck — passed with tsgo --noEmit.

Changes prepared by GPT-5.6 Sol through Codex in T3 Code.

Note

Fix mutedForeground in createVividThemeColors to stay dimmer than primary text

Replaces the foregroundOn(mutedRgb) derivation of mutedForeground with readableThemeText(mutedRgb, textRgb, 1, 4.6), then converts the result via themeRgbToThemeColor. This keeps mutedForeground accessible on the muted surface while ensuring it has lower contrast than the primary text color on that surface. Adds a test in themePalette.test.ts asserting the contrast ordering.

• Risk: any consumers relying on the old surface-dependent mutedForeground lightness value will see a different color; verify in-tree usages in apps/web/src.

^{Macroscope summarized 68211cf.}

[macroscopeapp]

Approvability

Verdict: Approved at 68211cf

Macroscope's review found this PR approvable — This is a focused two-file fix that adjusts only the derived muted foreground color for generated themes and adds coverage for the intended contrast ordering. The change preserves accessibility constraints without altering default palettes, APIs, or broader runtime workflows.

^{You can add or adjust custom eligibility rules. Learn more.}