Uh oh!
There was an error while loading. Please reload this page.
fix(web): preserve panel state across workspace refreshes - #8968
Conversation
Uh oh!
There was an error while loading. Please reload this page.
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe diff view now separates file identity from content versioning and stabilizes file loading callbacks. The file browser now reconciles tree paths incrementally, including recursive subtree removal. ChangesDiff reconciliation
File tree reconciliation
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk:⚪ Minimal · up to This change preserves diff collapse state and incrementally updates the file tree during workspace refreshes; no actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains what changed, why it changed, verification performed, and UI evidence. It omits the template headings and checklist, but it provides the required information and is substantially complete.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused web bug fix that preserves existing file-tree and diff-panel state during refreshes using localized reconciliation and per-file rendering versions. The changes are self-contained, tested, and introduce no schema, security, billing, deployment, or static-analysis configuration impact. You can add or adjust custom eligibility rules. Learn more. |
cbb0b3d to
ad8549aCompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ad8549a. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
ad8549a to
6ead33dCompareDismissing prior approval to re-evaluate 6ead33d
Uh oh!
There was an error while loading. Please reload this page.
Conflict resolutions: - Claude $skill: adopt upstream's last-block dispatch (pingdotgg#9128). Drop the fork's in-place $→/ rewrite on the Claude send path so the dispatcher still sees $ tokens. Ultrathink wrapping a leading $skill is now safe (prefix in the leading text block, command block still starts with /name). Keep the Grok $→/ rewrite. - Mobile composer menus: keep cwd-scoped composerSkills; apply upstream's user-invocable filter and dedupe on that list. Path search now imports from state/queries (upstream deleted the dedicated hook). - Files surface: keep lazy explorer listDirectory/readDirectoryChildren; adopt upstream's expandHomePathWith. Legacy (non-lazy) tree uses incremental path updates (pingdotgg#8968) plus the fork's symlink badges and ignored git status. - Tilde paths: skip ~/ inline-code candidates in the shared markdownLinks helper upstream extracted from web. Pre-sync fork: backup/upstream-test-drive-pre-sync-20260902 (d4f79f8).
## What's Changed * perf(client-runtime): keep turn and checkpoint refs stable while streaming by @t3dotgg in pingdotgg/t3code#9145 * perf(clients): lease sidebar status by visibility by @StiensWout in pingdotgg/t3code#9052 * fix(desktop): show newest changes in nightly previews by @t3dotgg in pingdotgg/t3code#9138 * fix(settings): sync auto-settle and other shared preferences across environments by @t3dotgg in pingdotgg/t3code#9147 * fix(server): prevent accidental service downgrades by @t3dotgg in pingdotgg/t3code#5302 * fix(server): keep attachments until the command commits by @t3dotgg in pingdotgg/t3code#7941 * fix(claude): preview images read from the workspace by @t3dotgg in pingdotgg/t3code#9119 * fix(web): keep generated muted foreground dimmer than entered text by @flamboh in pingdotgg/t3code#9113 * fix(clients): stop repeating expanded commands by @t3dotgg in pingdotgg/t3code#9120 * fix(grok): health check, model selection, and stop all work against the real CLI by @t3dotgg in pingdotgg/t3code#9154 * perf(web): halve the cold-start bundle by splitting Clerk and cold routes by @StiensWout in pingdotgg/t3code#9058 * feat(desktop): update the desktop app on remote Macs from the Update button by @t3dotgg in pingdotgg/t3code#6554 * test(server): measure shell, second client, and reconnect transfer by @t3dotgg in pingdotgg/t3code#9157 * fix(web): project default model works on the hosted app by @juliusmarminge in pingdotgg/t3code#9142 * fix(web): darken neutral control surfaces by @maria-rcks in pingdotgg/t3code#9064 * fix(web): preserve panel state across workspace refreshes by @maria-rcks in pingdotgg/t3code#8968 * feat(files): open markdown, HTML, and PDF files outside the workspace by @juliusmarminge in pingdotgg/t3code#9140 * feat(web): render HTML and PDF files in the file viewer by @juliusmarminge in pingdotgg/t3code#9143 * fix(web): compact project settings actions by @maria-rcks in pingdotgg/t3code#9160 * fix(web): browse folders from file breadcrumbs by @404khai in pingdotgg/t3code#8910 ## New Contributors * @404khai made their first contribution in pingdotgg/t3code#8910 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1252...v0.0.39-nightly.20260902.1253 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260902.1253
Workspace refreshes no longer reset collapsed diff files or rebuild the file tree. The diff now separates stable file identity from per-file content versions, while the file browser applies incremental path changes so unchanged elements stay mounted.
Verified with 12 focused tests, targeted lint and formatting, web typecheck, and the matched UI evidence below.
Evidence
Watch the real-app agent edit test
Real app flow: the branch diff stays open while GPT-5.6-Sol edits the expanded file; the other files remain collapsed through the live refresh.
Written with gpt-5.6-sol in the Codex harness.
Note
Low Risk
UI state and reconciliation logic only; no auth, data persistence, or API contract changes. Risk is mainly regressions in diff rendering or file tree sync after refresh.
Overview
Workspace refreshes no longer wipe collapsed diff files or rebuild the entire file tree from scratch. The diff panel now tracks each file with a stable identity key (previous + current paths) separate from a per-file content version, so unchanged files keep collapse state and only edited files get a new render version in
AnnotatableCodeView.DiffPanelalso exposesloadDiffFilesthrough a stable ref-backed callback so CodeView options do not churn when the git loader is recreated on refresh.The file browser applies incremental path add/remove batches via
buildFileTreePathUpdatesinstead ofresetPathson every entry refresh; the first successful load still resets the tree. It skips reconciliation until entries have loaded (entriesQuery.data !== null).Reviewed by Cursor Bugbot for commit 6ead33d. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Preserve diff panel and file tree state across workspace refreshes
DiffPanelnow identifies diff files by previous/current path viabuildFileDiffIdentityKeyinstead of the cache key, and computes a per-file content version withbuildFileDiffContentVersionso only changed files re-render.AnnotatableCodeViewprependsfileVersioninto its item version hash, limiting reconciliation to files whose diff content actually changed.FileBrowserPanelreplaces full tree resets with incremental batched updates: newbuildFileTreePathUpdatescomputes a minimal set of add/remove operations, collapsing deleted subtrees into a single recursive remove.previousTreePathsRefin FileBrowserPanel.tsx now starts asnull; first population callsmodel.resetPathswhile subsequent updates rely onbuildFileTreePathUpdatescorrectness — any path-order mismatch could produce stale tree nodes.Macroscope summarized 6ead33d.
Summary by CodeRabbit
Bug Fixes
Tests