Uh oh!
There was an error while loading. Please reload this page.
Expose react_render_textlayoutmanager via prefab - #43381
Closed
tomekzaw wants to merge 1 commit into
Closed
Conversation
facebook-github-bot
commented
Mar 8, 2024
Contributor
@cortinico has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cortinico
approved these changes
Mar 8, 2024
analysis-bot
commented
Mar 8, 2024
Base commit: 5126bac |
cortinico
commented
Mar 8, 2024
Contributor
@tomekzaw can you add a pick request here for 0.74? |
facebook-github-bot
commented
Mar 8, 2024
Contributor
@cortinico merged this pull request in 642b4e5. |
huntie pushed a commit
that referenced
this pull request
Mar 11, 2024
Summary: The `react_render_textlayoutmanager` was not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166. ## Changelog: <!-- Help reviewers and the release process by writing your own changelog entry. Pick one each for the category and type tags: [ANDROID|GENERAL|IOS|INTERNAL] [BREAKING|ADDED|CHANGED|DEPRECATED|REMOVED|FIXED|SECURITY] - Message For more details, see: https://reactnative.dev/contributing/changelogs-in-pull-requests --> [ANDROID] [CHANGED] - Expose `react_render_textlayoutmanager` via prefab. Pull Request resolved: #43381 Reviewed By: javache Differential Revision: D54676207 Pulled By: cortinico fbshipit-source-id: 90e3b90ff842250bf1e3abcc0c54f057b68a82fd
This was referenced Apr 5, 2024
This was referenced Jun 28, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The
react_render_textlayoutmanagerwas not exposed via prefab. I'm adding it to make possible for react-native-live-markdown to integrate on top of React Native via prefab. Based on #36166.Changelog:
[ANDROID] [CHANGED] - Expose
react_render_textlayoutmanagervia prefab.Test Plan: