Skip to content

[rn][ios][0.74][RC6] decouple RCTBridge+Private from jsinspector-modern - #43708

Merged
huntie merged 1 commit into
react:0.74-stablefrom
philIip:fixing-shit
Apr 2, 2024
Merged

[rn][ios][0.74][RC6] decouple RCTBridge+Private from jsinspector-modern#43708
huntie merged 1 commit into
react:0.74-stablefrom
philIip:fixing-shit

Conversation

@philIip

@philIipphilIip commented Mar 29, 2024

Copy link
Copy Markdown
Contributor

Changelog: [Internal]

Summary

new debugger logic added in 0.74 implicitly imported a C++ library depending on boost into the public headers for anyone importing RCTBridge+Private, which is a common header imported by libraries. boost is hard to link correctly, so this has caused issues with libraries such as OP-SQLite (#43204).

this must be picked directly against 0.74 instead of off master because PageTarget was renamed to HostTarget after the 0.74 cut.

do not pick into master!!!

Test Plan

build passes

@facebook-github-botfacebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels Mar 29, 2024
@analysis-bot

analysis-bot commented Mar 29, 2024

Copy link
Copy Markdown
PlatformEngineArchSize (bytes)Diff
androidhermesarm64-v8a17,820,386-1,056,580
androidhermesarmeabi-v7an/a--
androidhermesx86n/a--
androidhermesx86_64n/a--
androidjscarm64-v8a21,178,700-1,071,322
androidjscarmeabi-v7an/a--
androidjscx86n/a--
androidjscx86_64n/a--

Base commit: f7ec469
Branch: main

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA SignedThis label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.p: FacebookPartner: FacebookPartnerPick Request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@philIip@analysis-bot@huntie@facebook-github-bot