Migrate ast lowering to session diagnostic by JeanCASPAR · Pull Request #100724 · rust-lang/rust

JeanCASPAR · 2022-08-18T18:40:52Z

I migrated the whole rustc_ast_lowering crate to session diagnostic except the for the use of span_fatal at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because #[fatal(...)] is not yet supported (see #100694).

rust-highfive · 2022-08-18T18:40:55Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-08-18T18:40:56Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

davidtwco · 2022-08-19T09:49:34Z

r? @davidtwco

davidtwco

This is really great, thanks for working on it. I've left a few comments.

davidtwco · 2022-08-19T14:14:15Z

@bors r+

bors · 2022-08-19T14:14:17Z

📌 Commit e34da16 has been approved by davidtwco

It is now in the queue for this repository.

…-session-diagnostic, r=davidtwco Migrate ast lowering to session diagnostic I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).

davidtwco · 2022-08-22T16:22:58Z

Could you remove the merge commits? We have a no merge policy - thanks!

davidtwco · 2022-08-22T16:24:06Z

r=me after merge commits removed

JeanCASPAR · 2022-08-22T20:55:10Z

@bors r=davidtwco

bors · 2022-08-22T20:55:11Z

@JeanCASPAR: 🔑 Insufficient privileges: Not in reviewers

JeanCASPAR · 2022-08-22T20:57:16Z

Don't know if this intended, @davidtwco ?

davidtwco · 2022-08-23T09:02:53Z

Don't know if this intended, @davidtwco ?

It is, only approved reviewers can r+, I just left that comment in case another reviewer looked at the PR and saw that they could approve on my behalf after you resolved the comment.

@bors r+

bors · 2022-08-23T09:02:55Z

📌 Commit 5fef1b8 has been approved by davidtwco

It is now in the queue for this repository.

…-session-diagnostic, r=davidtwco Migrate ast lowering to session diagnostic I migrated the whole rustc_ast_lowering crate to session diagnostic *except* the for the use of `span_fatal` at /compiler/rustc_ast_lowering/src/expr.rs#L1268 because `#[fatal(...)]` is not yet supported (see rust-lang#100694).

compiler-errors · 2022-08-26T22:55:42Z

@bors rollup

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#100724 (Migrate ast lowering to session diagnostic) - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`) - rust-lang#100738 (Diagnostics migr const eval) - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs) - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`) - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword) - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics) - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic) - rust-lang#100900 (on `region_errors.rs`) Failed merges: - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned petrochenkov Aug 18, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022

rust-highfive assigned davidtwco and unassigned petrochenkov Aug 19, 2022

davidtwco requested changes Aug 19, 2022
View reviewed changes

Comment threadcompiler/rustc_ast_lowering/src/lib.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/lib.rs
Comment threadcompiler/rustc_ast_lowering/src/errors.rs Outdated
Comment threadcompiler/rustc_ast_lowering/src/errors.rs Outdated

davidtwco approved these changes Aug 19, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022

ChrisDenton mentioned this pull request Aug 20, 2022
Rollup of 8 pull requests #100785
Closed

Dylan-DPC mentioned this pull request Aug 20, 2022
Rollup of 7 pull requests #100794
Closed

This comment was marked as resolved.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2022

This comment has been minimized.
Sign in to view

This comment was marked as resolved.
Sign in to view

JeanCASPAR force-pushed the migrate-ast_lowering-to-session-diagnostic branch from b4a8f2f to 1a4ee21Compare August 22, 2022 12:32

JeanCASPAR added 2 commits August 22, 2022 19:19

Migrate ast_lowering::path to SessionDiagnostic
73ae38b

Migrate ast_lowering::lib and ast_lowering::item to SessionDiagnostic
0043d10

JeanCASPAR added 6 commits August 22, 2022 19:21

Migrate ast_lowering::expr to SessionDiagnostic
1382d30

Migrate ast_lowering::ast to SessionDiagnostic
d75fd91

Migrate ast_lowering::pat to SessionDiagnostic
5164966

Migrate all span_err(...) in ast_lowering to SessionDiagnostic
e701c72

Changes made in response to feedback
9472df1

Resolve conflicts
5fef1b8

JeanCASPAR force-pushed the migrate-ast_lowering-to-session-diagnostic branch from 9736e72 to 5fef1b8Compare August 22, 2022 19:58

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 23, 2022

davidtwco mentioned this pull request Aug 23, 2022
Diagnostic Translation #100717
Open
84 tasks

Dylan-DPC mentioned this pull request Aug 26, 2022
Rollup of 8 pull requests #101026
Closed

Dylan-DPC mentioned this pull request Aug 26, 2022
Rollup of 9 pull requests #101032
Closed

Dylan-DPC mentioned this pull request Aug 26, 2022
Rollup of 9 pull requests #101033
Closed

Dylan-DPC mentioned this pull request Aug 26, 2022
Rollup of 9 pull requests #101052
Closed

compiler-errors mentioned this pull request Aug 26, 2022
Rollup of 9 pull requests #101064
Merged

bors merged commit bc1d205 into rust-lang:masterAug 27, 2022

rustbot added this to the 1.65.0 milestone Aug 27, 2022

Uh oh!

Uh oh!

Conversation

JeanCASPAR commented Aug 18, 2022

Uh oh!

rust-highfive commented Aug 18, 2022

Uh oh!

rustbot commented Aug 18, 2022

Uh oh!

davidtwco commented Aug 19, 2022

Uh oh!

davidtwco left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

davidtwco commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

This comment was marked as resolved.

This comment has been minimized.

This comment was marked as resolved.

davidtwco commented Aug 22, 2022

Uh oh!

davidtwco commented Aug 22, 2022

Uh oh!

JeanCASPAR commented Aug 22, 2022

Uh oh!

bors commented Aug 22, 2022

Uh oh!

JeanCASPAR commented Aug 22, 2022

Uh oh!

davidtwco commented Aug 23, 2022

Uh oh!

bors commented Aug 23, 2022

Uh oh!

compiler-errors commented Aug 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants