Skip to content

Migrate rustc_mir_dataflow to diagnostic structs - #100744

Merged
bors merged 3 commits into
masterfrom
unknown repository
Aug 27, 2022
Merged

Migrate rustc_mir_dataflow to diagnostic structs#100744
bors merged 3 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghostghost commented Aug 19, 2022•
edited by ghost
Loading

Copy link
Copy Markdown

No description provided.

@rust-highfive

rust-highfive commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

r? @michaelwoerister

(rust-highfive has picked a reviewer for you, use r? to override)

@rustbotrustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
@ghost

ghost commented Aug 19, 2022

Copy link
Copy Markdown
Author

@rustbot blocked

@rustbotrustbot added S-blocked Status: Blocked on something else such as an RFC or other implementation work. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022
@michaelwoerister

michaelwoerister commented Aug 19, 2022

Copy link
Copy Markdown
Member

r? diagnostics

@ghost

ghost commented Aug 23, 2022

Copy link
Copy Markdown
Author

@rustbot review

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-blocked Status: Blocked on something else such as an RFC or other implementation work. labels Aug 23, 2022
@ghost
ghost marked this pull request as ready for review August 23, 2022 11:34
@rustbot

rustbot commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

@ghostghost changed the title Migrate rustc_mir_dataflow (WIP, blocked on fatal support)Migrate rustc_mir_dataflow to diagnostic structsAug 23, 2022
JohnTitor
JohnTitor reviewed Aug 23, 2022
View reviewed changes
Comment threadcompiler/rustc_error_messages/locales/en-US/rustc_mir_dataflow.ftl Outdated
davidtwco
davidtwco requested changes Aug 23, 2022
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small change then r=me

Comment threadcompiler/rustc_error_messages/src/lib.rs Outdated
@davidtwco

davidtwco commented Aug 23, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 23, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit f20cc9a has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 23, 2022
@davidtwcodavidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
@compiler-errors

compiler-errors commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

@bors rollup

@compiler-errorscompiler-errors mentioned this pull request Aug 26, 2022
Merged
klensy
klensy reviewed Aug 26, 2022
View reviewed changes
Comment threadcompiler/rustc_mir_dataflow/Cargo.toml
rustc_macros = { path = "../rustc_macros" }
rustc_middle = { path = "../rustc_middle" }
rustc_serialize = { path = "../rustc_serialize" }
rustc_session = { path = "../rustc_session" }

@klensyklensyAug 26, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't see where rustc_session used :-(

Probably SessionDiagnostic.

bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2022
@bors
Auto merge ofrust-lang#101064- compiler-errors:rollup-fwm5m5f, r=co…
bb8a08f
…mpiler-errors
Rollup of 9 pull requests
Successful merges:
- rust-lang#100724 (Migrate ast lowering to session diagnostic)
- rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`)
- rust-lang#100738 (Diagnostics migr const eval)
- rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs)
- rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`)
- rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
- rust-lang#100836 (Migrate `rustc_attr` crate diagnostics)
- rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic)
- rust-lang#100900 (on `region_errors.rs`)
Failed merges:
- rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 93b2acd into rust-lang:masterAug 27, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@compiler-errorscompiler-errors

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

8 participants

@rust-highfive@michaelwoerister@rustbot@davidtwco@bors@compiler-errors@klensy@JohnTitor