Skip to content

Diagnostics migr const eval - #100738

Merged
bors merged 10 commits into
rust-lang:masterfrom
nidnogg:diagnostics_migr_const_eval
Aug 27, 2022
Merged

Diagnostics migr const eval#100738
bors merged 10 commits into
rust-lang:masterfrom
nidnogg:diagnostics_migr_const_eval

Conversation

@nidnogg

@nidnoggnidnogg commented Aug 19, 2022

Copy link
Copy Markdown
Contributor

This PR should eventually contain all diagnostic migrations for the rustc_const_eval crate.

r? @davidtwco
@rustbot label +A-translation

@rustbotrustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 19, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 19, 2022
compiler-errors
compiler-errors reviewed Aug 19, 2022
View reviewed changes
Comment threadcompiler/rustc_const_eval/src/errors.rs Outdated
compiler-errors
compiler-errors reviewed Aug 19, 2022
View reviewed changes
Comment threadcompiler/rustc_const_eval/src/errors.rs Outdated
@davidtwco

davidtwco commented Aug 19, 2022

Copy link
Copy Markdown
Member

r? @compiler-errors

@nidnogg

nidnogg commented Aug 19, 2022

Copy link
Copy Markdown
ContributorAuthor

I added in some more migrations but I'm struggling a bit with their test passes - if anyone could give me some pointers that'd be really appreciated!

@rust-log-analyzer

This comment has been minimized.

Sign in to view
Xiretza
Xiretza reviewed Aug 20, 2022
View reviewed changes

@XiretzaXiretza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create_feature_err() does not automatically assign error code E0658 like feature_err() does - maybe that should be changed there (with a check that the diagnostic that's passed in does not already have an error code set)?

Comment threadcompiler/rustc_const_eval/src/errors.rs Outdated
Comment threadcompiler/rustc_const_eval/src/errors.rs Outdated
@nidnogg
nidnogg marked this pull request as ready for review August 20, 2022 22:29
@rustbot

rustbot commented Aug 20, 2022

Copy link
Copy Markdown
Collaborator

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank, @TaKO8Ki

jeffparsons
jeffparsons reviewed Aug 20, 2022
View reviewed changes
Comment threadcompiler/rustc_const_eval/src/errors.rs Outdated
Xiretza
Xiretza reviewed Aug 21, 2022
View reviewed changes
Comment threadcompiler/rustc_session/src/session.rs Outdated
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nidnogg
nidnoggforce-pushed the diagnostics_migr_const_eval branch from 63c2f86 to 13abae2CompareAugust 22, 2022 03:03
@nidnogg
nidnogg requested review from davidtwco and removed request for compiler-errorsAugust 22, 2022 11:54
davidtwco
davidtwco approved these changes Aug 22, 2022
View reviewed changes

@davidtwcodavidtwco left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r=me once remaining comments addressed

@nidnogg

nidnogg commented Aug 22, 2022

Copy link
Copy Markdown
ContributorAuthor

r? @davidtwco

@davidtwco

davidtwco commented Aug 22, 2022

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Aug 22, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit 5101688 has been approved by davidtwco

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 22, 2022
@davidtwcodavidtwco mentioned this pull request Aug 23, 2022
Open
84 tasks
@compiler-errors

compiler-errors commented Aug 26, 2022

Copy link
Copy Markdown
Contributor

@bors rollup

@compiler-errorscompiler-errors mentioned this pull request Aug 26, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 27, 2022
@bors
Auto merge ofrust-lang#101064- compiler-errors:rollup-fwm5m5f, r=co…
bb8a08f
…mpiler-errors
Rollup of 9 pull requests
Successful merges:
- rust-lang#100724 (Migrate ast lowering to session diagnostic)
- rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`)
- rust-lang#100738 (Diagnostics migr const eval)
- rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs)
- rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`)
- rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword)
- rust-lang#100836 (Migrate `rustc_attr` crate diagnostics)
- rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic)
- rust-lang#100900 (on `region_errors.rs`)
Failed merges:
- rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit b543444 into rust-lang:masterAug 27, 2022
@rustbotrustbot added this to the 1.65.0 milestone Aug 27, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidtwcodavidtwcodavidtwco approved these changes
+3 more reviewers
@jeffparsonsjeffparsonsjeffparsons left review comments
@XiretzaXiretzaXiretza left review comments
@compiler-errorscompiler-errorscompiler-errors left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@davidtwcodavidtwco

Labels

A-translationArea: Translation infrastructure, and migrating existing diagnostics to SessionDiagnosticS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.65.0

Development

Successfully merging this pull request may close these issues.

9 participants

@nidnogg@davidtwco@rust-log-analyzer@rustbot@bors@compiler-errors@jeffparsons@Xiretza@rust-highfive