Migrate `rustc_ty_utils` to `SessionDiagnostic` by petermused · Pull Request #100735 · rust-lang/rust

petermused · 2022-08-18T23:32:42Z

I have migrated the rustc_ty_utils crate to use SessionDiagnostic, motivated by the recent blog post about the diagnostic translation effort.

This is my first PR to the Rust repository, so if I have missed anything, or anything needs to be changed, please let me know! 😄

@rustbot label +A-translation

rust-highfive · 2022-08-18T23:32:45Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @fee1-dead (or someone else) soon.

Please see the contribution instructions for more information.

rustbot · 2022-08-18T23:32:46Z

rustc_error_messages was changed

cc @davidtwco, @compiler-errors, @JohnTitor, @estebank

fee1-dead · 2022-08-19T05:11:52Z

r? @davidtwco

davidtwco · 2022-08-19T08:49:34Z

@bors r+

bors · 2022-08-19T08:49:35Z

📌 Commit c817dc30cfd464a8a1e3121d2dcd06a61be1461f has been approved by davidtwco

It is now in the queue for this repository.

davidtwco · 2022-08-19T10:46:12Z

@bors r-

petermused · 2022-08-19T10:58:02Z

I have moved the deny attributes to the root of the crate

davidtwco · 2022-08-19T11:12:10Z

@bors r+

bors · 2022-08-19T11:12:11Z

📌 Commit 8028ec186e8dcb583c6e9740e26863378da5d0dd has been approved by davidtwco

It is now in the queue for this repository.

bors · 2022-08-22T16:20:34Z

📌 Commit 7affbb0f163f24033161ae38c8038cf667c20282 has been approved by davidtwco

It is now in the queue for this repository.

davidtwco · 2022-08-25T10:25:14Z

Re-request a review once you've resolved the conflicts so that I can re-approve.

petermused · 2022-08-25T22:34:06Z

r? @davidtwco

davidtwco · 2022-08-26T09:10:32Z

@bors r+

bors · 2022-08-26T09:10:34Z

📌 Commit 7754ab1441b43663ddbf3fa576ad75d0c744d475 has been approved by davidtwco

It is now in the queue for this repository.

petermused · 2022-08-26T14:06:53Z

Fixed some more merge conficts

r? @davidtwco

davidtwco · 2022-08-26T14:22:47Z

@bors r+

bors · 2022-08-26T14:22:49Z

📌 Commit 01c1616 has been approved by davidtwco

It is now in the queue for this repository.

compiler-errors · 2022-08-26T22:54:23Z

@bors rollup

…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#100724 (Migrate ast lowering to session diagnostic) - rust-lang#100735 (Migrate `rustc_ty_utils` to `SessionDiagnostic`) - rust-lang#100738 (Diagnostics migr const eval) - rust-lang#100744 (Migrate rustc_mir_dataflow to diagnostic structs) - rust-lang#100776 (Migrate `rustc_lint` errors to `SessionDiagnostic`) - rust-lang#100817 (sugg: suggest the usage of boolean value when there is a typo in the keyword) - rust-lang#100836 (Migrate `rustc_attr` crate diagnostics) - rust-lang#100890 (Migrate rustc_driver to SessionDiagnostic) - rust-lang#100900 (on `region_errors.rs`) Failed merges: - rust-lang#100831 (Migrate `symbol_mangling` module to new diagnostics structs) r? `@ghost` `@rustbot` modify labels: rollup

rust-highfive assigned fee1-dead Aug 18, 2022

rustbot added A-translation Area: Translation infrastructure, and migrating existing diagnostics to SessionDiagnostic T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 18, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 18, 2022

rust-highfive assigned davidtwco and unassigned fee1-dead Aug 19, 2022

estebank approved these changes Aug 19, 2022
View reviewed changes

davidtwco reviewed Aug 19, 2022
View reviewed changes

Comment threadcompiler/rustc_ty_utils/src/consts.rs Outdated

davidtwco approved these changes Aug 19, 2022
View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 19, 2022

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 19, 2022

petermused force-pushed the ty-utils-translation branch from c817dc3 to 8028ec1Compare August 19, 2022 10:56

davidtwco mentioned this pull request Aug 19, 2022
Diagnostic Translation #100717
Open
84 tasks

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 19, 2022

This comment was marked as resolved.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 22, 2022

petermused force-pushed the ty-utils-translation branch from 8028ec1 to 2957815Compare August 22, 2022 15:23

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 22, 2022

This comment was marked as resolved.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 25, 2022

petermused force-pushed the ty-utils-translation branch from 7affbb0 to 7754ab1Compare August 25, 2022 22:33

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2022

This comment was marked as resolved.
Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Aug 26, 2022

Migrate rustc_ty_utils to use SessionDiagnostic
01c1616

petermused force-pushed the ty-utils-translation branch from 7754ab1 to 01c1616Compare August 26, 2022 14:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Aug 26, 2022

compiler-errors mentioned this pull request Aug 26, 2022
Rollup of 9 pull requests #101064
Merged

bors merged commit 181b041 into rust-lang:masterAug 27, 2022

rustbot added this to the 1.65.0 milestone Aug 27, 2022

petermused deleted the ty-utils-translation branch August 27, 2022 21:48

Uh oh!

Uh oh!

Conversation

petermused commented Aug 18, 2022

Uh oh!

rust-highfive commented Aug 18, 2022

Uh oh!

rustbot commented Aug 18, 2022

Uh oh!

fee1-dead commented Aug 19, 2022

Uh oh!

Uh oh!

davidtwco commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

davidtwco commented Aug 19, 2022

Uh oh!

petermused commented Aug 19, 2022

Uh oh!

davidtwco commented Aug 19, 2022

Uh oh!

bors commented Aug 19, 2022

Uh oh!

This comment was marked as resolved.

bors commented Aug 22, 2022

Uh oh!

This comment was marked as resolved.

davidtwco commented Aug 25, 2022

Uh oh!

petermused commented Aug 25, 2022

Uh oh!

davidtwco commented Aug 26, 2022

Uh oh!

bors commented Aug 26, 2022

Uh oh!

This comment was marked as resolved.

petermused commented Aug 26, 2022

Uh oh!

davidtwco commented Aug 26, 2022

Uh oh!

bors commented Aug 26, 2022

Uh oh!

compiler-errors commented Aug 26, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants