Skip to content

Support using #[unstable_feature_bound] on trait - #145251

Merged
bors merged 3 commits into
rust-lang:masterfrom
tiif:support_trait
Aug 12, 2025
Merged

Support using #[unstable_feature_bound] on trait#145251
bors merged 3 commits into
rust-lang:masterfrom
tiif:support_trait

Conversation

@tiif

@tiiftiif commented Aug 11, 2025

Copy link
Copy Markdown
Member

This is needed to unblock #145095

r? @BoxyUwU

@rustbotrustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 11, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

@rustbotrustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Aug 11, 2025
@rustbot

Copy link
Copy Markdown
Collaborator

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@BoxyUwU

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Aug 11, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit bcf87e4 has been approved by BoxyUwU

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025
fmease added a commit to fmease/rust that referenced this pull request Aug 11, 2025
Support using #[unstable_feature_bound] on trait
This is needed to unblock rust-lang#145095
r? `@BoxyUwU`
@fmeasefmease mentioned this pull request Aug 11, 2025
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
Support using #[unstable_feature_bound] on trait
This is needed to unblock rust-lang#145095
r? ``@BoxyUwU``
@fmeasefmease mentioned this pull request Aug 12, 2025
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
Support using #[unstable_feature_bound] on trait
This is needed to unblock rust-lang#145095
r? ```@BoxyUwU```
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
Support using #[unstable_feature_bound] on trait
This is needed to unblock rust-lang#145095
r? ````@BoxyUwU````
@fmeasefmease mentioned this pull request Aug 12, 2025
bors added a commit that referenced this pull request Aug 12, 2025
Rollup of 15 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144542 (Stabilize `sse4a` and `tbm` target features)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
r? `@ghost`
`@rustbot` modify labels: rollup
fmease added a commit to fmease/rust that referenced this pull request Aug 12, 2025
Support using #[unstable_feature_bound] on trait
This is needed to unblock rust-lang#145095
r? `````@BoxyUwU`````
@fmeasefmease mentioned this pull request Aug 12, 2025
bors added a commit that referenced this pull request Aug 12, 2025
Rollup of 14 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144210 (std: thread: Return error if setting thread stack size fails)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
r? `@ghost`
`@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 12, 2025
Support using #[unstable_feature_bound] on trait
This is needed to unblock rust-lang#145095
r? ``````@BoxyUwU``````
@ZalatharZalathar mentioned this pull request Aug 12, 2025
bors added a commit that referenced this pull request Aug 12, 2025
Rollup of 17 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144210 (std: thread: Return error if setting thread stack size fails)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- #145283 (Make I-miscompile imply I-prioritize)
- #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Aug 12, 2025
bors added a commit that referenced this pull request Aug 12, 2025
Rollup of 17 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- #145283 (Make I-miscompile imply I-prioritize)
- #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- #145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 42af95b into rust-lang:masterAug 12, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 12, 2025
rust-timer added a commit that referenced this pull request Aug 12, 2025
Rollup merge of #145251 - tiif:support_trait, r=BoxyUwU
Support using #[unstable_feature_bound] on trait
This is needed to unblock #145095
r? ```````@BoxyUwU```````
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 13, 2025
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time)
- rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR)
- rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- rust-lang/rust#145214 (fix: re-enable self-assignment)
- rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display)
- rust-lang/rust#145238 (Tweak invalid builtin attribute output)
- rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`)
- rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait)
- rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator)
- rust-lang/rust#145263 (Update books)
- rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- rust-lang/rust#145283 (Make I-miscompile imply I-prioritize)
- rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- rust-lang/rust#145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 18, 2025
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time)
- rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR)
- rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- rust-lang/rust#145214 (fix: re-enable self-assignment)
- rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display)
- rust-lang/rust#145238 (Tweak invalid builtin attribute output)
- rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`)
- rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait)
- rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator)
- rust-lang/rust#145263 (Update books)
- rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- rust-lang/rust#145283 (Make I-miscompile imply I-prioritize)
- rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- rust-lang/rust#145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributesArea: Attributes (`#[…]`, `#![…]`)A-rustc-dev-guideArea: rustc-dev-guideS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tiif@rustbot@BoxyUwU@bors