Document compiler and stdlib in stage1 in `pr-check-2` CI job by Kobzol · Pull Request #145253 · rust-lang/rust

Kobzol · 2025-08-11T14:18:37Z

This restores the original behavior pre-#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad).

Let's see what will be the "new" duration, it should be ~55 minutes.

r? @jieyouxu

jieyouxu · 2025-08-11T14:21:12Z

Thanks, you can r=me if it takes the expect amount of time.

Kobzol · 2025-08-11T15:40:21Z

... Right, CI uses the dist profile, which has doc-stage set to 2 by default. Let's try again with explicit stage 1..

Kobzol · 2025-08-11T16:32:27Z

Ok, good!

@bors r=jieyouxu rollup

bors · 2025-08-11T16:32:29Z

📌 Commit 79a134a has been approved by jieyouxu

It is now in the queue for this repository.

see rust-lang/rust#145253 for reference.

…ieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-rust-lang#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? `@jieyouxu`

…ieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-rust-lang#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? ``@jieyouxu``

…ieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-rust-lang#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? ```@jieyouxu```

…ieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-rust-lang#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? ````@jieyouxu````

Rollup of 15 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144386 (Extract TraitImplHeader in AST/HIR) - #144542 (Stabilize `sse4a` and `tbm` target features) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145260 (Make explicit guarantees about `Vec`’s allocator) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-rust-lang#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? `````@jieyouxu`````

Rollup of 14 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144210 (std: thread: Return error if setting thread stack size fails) - #144386 (Extract TraitImplHeader in AST/HIR) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) r? `@ghost` `@rustbot` modify labels: rollup

…ieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-rust-lang#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? ``````@jieyouxu``````

Rollup of 17 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144210 (std: thread: Return error if setting thread stack size fails) - #144386 (Extract TraitImplHeader in AST/HIR) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145260 (Make explicit guarantees about `Vec`’s allocator) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) - #145283 (Make I-miscompile imply I-prioritize) - #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 17 pull requests Successful merges: - #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - #139806 (std: sys: pal: uefi: Overhaul Time) - #144386 (Extract TraitImplHeader in AST/HIR) - #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - #145214 (fix: re-enable self-assignment) - #145216 (rustdoc: correct negative-to-implicit discriminant display) - #145238 (Tweak invalid builtin attribute output) - #145249 (Rename entered trace span variables from `_span` to `_trace`) - #145251 (Support using #[unstable_feature_bound] on trait) - #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - #145260 (Make explicit guarantees about `Vec`’s allocator) - #145263 (Update books) - #145273 (Account for new `assert!` desugaring in `!condition` suggestion) - #145283 (Make I-miscompile imply I-prioritize) - #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc) - #145292 (Fix a typo in range docs) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #145253 - Kobzol:pr-check-2-doc-stage-1, r=jieyouxu Document compiler and stdlib in stage1 in `pr-check-2` CI job This restores the original behavior pre-#145011 (I thought that stage 2 makes more sense here, but it made the job ~30m slower, which is bad). Let's see what will be the "new" duration, it should be ~55 minutes. r? ```````@jieyouxu```````

Rollup of 17 pull requests Successful merges: - rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var) - rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time) - rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR) - rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`) - rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2)) - rust-lang/rust#145214 (fix: re-enable self-assignment) - rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display) - rust-lang/rust#145238 (Tweak invalid builtin attribute output) - rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`) - rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait) - rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job) - rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator) - rust-lang/rust#145263 (Update books) - rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion) - rust-lang/rust#145283 (Make I-miscompile imply I-prioritize) - rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc) - rust-lang/rust#145292 (Fix a typo in range docs) r? `@ghost` `@rustbot` modify labels: rollup

see rust-lang#145253 for reference.

rustbot assigned jieyouxu Aug 11, 2025

jieyouxu approved these changes Aug 11, 2025
View reviewed changes

Kobzol mentioned this pull request Aug 11, 2025
Enforce in bootstrap that doc must have stage at least 1 #145011
Merged

Document compiler and stdlib in stage1 in pr-check-2 CI job
79a134a

Kobzol force-pushed the pr-check-2-doc-stage-1 branch from 1f3ca0a to 79a134aCompare August 11, 2025 15:39

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 11, 2025

lolbinarycat added a commit to lolbinarycat/rustc-dev-guide that referenced this pull request Aug 11, 2025
Update bootstrapping docs to account for new stage meanings
d32f336
see rust-lang/rust#145253 for reference.

lolbinarycat mentioned this pull request Aug 11, 2025
Update bootstrapping docs to account for new stage meanings rust-lang/rustc-dev-guide#2546
Merged

fmease mentioned this pull request Aug 11, 2025
Rollup of 16 pull requests #145280
Closed

fmease mentioned this pull request Aug 12, 2025
Rollup of 15 pull requests #145281
Closed

fmease mentioned this pull request Aug 12, 2025
Rollup of 15 pull requests #145282
Closed

fmease mentioned this pull request Aug 12, 2025
Rollup of 14 pull requests #145285
Closed

Zalathar mentioned this pull request Aug 12, 2025
Rollup of 17 pull requests #145293
Closed

Zalathar mentioned this pull request Aug 12, 2025
Rollup of 17 pull requests #145300
Merged

bors merged commit 1c38519 into rust-lang:masterAug 12, 2025
10 checks passed

rustbot added this to the 1.91.0 milestone Aug 12, 2025

Kobzol deleted the pr-check-2-doc-stage-1 branch August 12, 2025 16:16

tshepang pushed a commit to tshepang/rust that referenced this pull request Aug 25, 2025
Update bootstrapping docs to account for new stage meanings
f486a6f
see rust-lang#145253 for reference.

Navigation Menu

Uh oh!

Uh oh!

Document compiler and stdlib in stage1 in `pr-check-2` CI job - #145253

Document compiler and stdlib in stage1 in `pr-check-2` CI job#145253
bors merged 1 commit into
rust-lang:masterfrom
Kobzol:pr-check-2-doc-stage-1

Kobzol commented Aug 11, 2025

Uh oh!

jieyouxu commented Aug 11, 2025

Uh oh!

Kobzol commented Aug 11, 2025

Uh oh!

Kobzol commented Aug 11, 2025

Uh oh!

bors commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Kobzol commented Aug 11, 2025

Uh oh!

jieyouxu commented Aug 11, 2025

Uh oh!

Kobzol commented Aug 11, 2025

Uh oh!

Kobzol commented Aug 11, 2025

Uh oh!

bors commented Aug 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants