Skip to content

bootstrap: Only warn about rust.debug-assertions if downloading rustc - #145291

Merged
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:no-warning
Aug 12, 2025
Merged

bootstrap: Only warn about rust.debug-assertions if downloading rustc#145291
bors merged 1 commit into
rust-lang:masterfrom
Zalathar:no-warning

Conversation

@Zalathar

@ZalatharZalathar commented Aug 12, 2025•
edited by rustbot
Loading

Copy link
Copy Markdown
Member

The changes in #145149 had the unwanted side-effect of causing bootstrap to always warn about rust.debug-assertions = true, even if rustc isn't going to be downloaded anyway.

cc @Shourya742 @Kobzol

@ZalatharZalathar added the A-contributor-roadblock Area: Makes things more difficult for new or seasoned contributors to Rust label Aug 12, 2025
@rustbot

rustbot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Aug 12, 2025
@rustbot

rustbot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.

@Kobzol

Kobzol commented Aug 12, 2025

Copy link
Copy Markdown
Member

Good catch, thanks! Btw the alt builds do have debug assertions now, so we could remove it entirely xD But it's better to leave download-ci-rustc be for now..

@bors r+ rollup

@bors

bors commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit e454022 has been approved by Kobzol

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
@ZalatharZalathar mentioned this pull request Aug 12, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 12, 2025
@Zalathar
Rollup merge ofrust-lang#145291- Zalathar:no-warning, r=Kobzol
3755901
bootstrap: Only warn about `rust.debug-assertions` if downloading rustc
The changes in rust-lang#145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway.
cc `@Shourya742` `@Kobzol`
@ZalatharZalathar mentioned this pull request Aug 12, 2025
Closed
bors added a commit that referenced this pull request Aug 12, 2025
@bors
Auto merge of#145293- Zalathar:rollup-rsp9t9l, r=Zalathar
1c7121c
Rollup of 17 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144210 (std: thread: Return error if setting thread stack size fails)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- #145283 (Make I-miscompile imply I-prioritize)
- #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Aug 12, 2025
Merged
bors added a commit that referenced this pull request Aug 12, 2025
@bors
Auto merge of#145300- Zalathar:rollup-0eqbt6a, r=Zalathar
d9dba3a
Rollup of 17 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- #145283 (Make I-miscompile imply I-prioritize)
- #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- #145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 04f29fd into rust-lang:masterAug 12, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 12, 2025
rust-timer added a commit that referenced this pull request Aug 12, 2025
@rust-timer
Unrolled build for#145291
2d614ac
Rollup merge of #145291 - Zalathar:no-warning, r=Kobzol
bootstrap: Only warn about `rust.debug-assertions` if downloading rustc
The changes in #145149 had the unwanted side-effect of causing bootstrap to *always* warn about `rust.debug-assertions = true`, even if rustc isn't going to be downloaded anyway.
cc ``@Shourya742`` ``@Kobzol``
@Zalathar
Zalathar deleted the no-warning branch August 12, 2025 23:16
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 13, 2025
@bors
Auto merge of #145300 - Zalathar:rollup-0eqbt6a, r=Zalathar
f393c32
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time)
- rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR)
- rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- rust-lang/rust#145214 (fix: re-enable self-assignment)
- rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display)
- rust-lang/rust#145238 (Tweak invalid builtin attribute output)
- rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`)
- rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait)
- rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator)
- rust-lang/rust#145263 (Update books)
- rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- rust-lang/rust#145283 (Make I-miscompile imply I-prioritize)
- rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- rust-lang/rust#145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 18, 2025
@bors
Auto merge of #145300 - Zalathar:rollup-0eqbt6a, r=Zalathar
7978029
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time)
- rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR)
- rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- rust-lang/rust#145214 (fix: re-enable self-assignment)
- rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display)
- rust-lang/rust#145238 (Tweak invalid builtin attribute output)
- rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`)
- rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait)
- rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator)
- rust-lang/rust#145263 (Update books)
- rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- rust-lang/rust#145283 (Make I-miscompile imply I-prioritize)
- rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- rust-lang/rust#145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@clubby789clubby789

Labels

A-contributor-roadblockArea: Makes things more difficult for new or seasoned contributors to RustS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Zalathar@rustbot@Kobzol@bors@clubby789