Skip to content

Make I-miscompile imply I-prioritize - #145283

Merged
bors merged 1 commit into
rust-lang:masterfrom
theemathas:patch-1
Aug 12, 2025
Merged

Make I-miscompile imply I-prioritize#145283
bors merged 1 commit into
rust-lang:masterfrom
theemathas:patch-1

Conversation

@theemathas

@theemathastheemathas commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

Since I-unsound already implies I-prioritize, it makes sense that I-miscompile should do the same.

@theemathas
Make I-miscompile imply I-prioritize
f336cc7
Since I-unsound already implies I-prioritize, it makes sense that I-miscompile should do the same.
@rustbot

rustbot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

rustbot commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

triagebot.toml has been modified, there may have been changes to the review queue.

cc @davidtwco, @wesleywiser

@rustbotrustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
@Noratrieb

Noratrieb commented Aug 12, 2025

Copy link
Copy Markdown
Member

sounds good
@bors r+

@bors

bors commented Aug 12, 2025

Copy link
Copy Markdown
Collaborator

📌 Commit f336cc7 has been approved by Noratrieb

It is now in the queue for this repository.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 12, 2025
@Noratrieb

Noratrieb commented Aug 12, 2025

Copy link
Copy Markdown
Member

@bors rollup

Zalathar added a commit to Zalathar/rust that referenced this pull request Aug 12, 2025
@Zalathar
Rollup merge ofrust-lang#145283- theemathas:patch-1, r=Noratrieb
6c9c053
Make I-miscompile imply I-prioritize
Since I-unsound already implies I-prioritize, it makes sense that I-miscompile should do the same.
@ZalatharZalathar mentioned this pull request Aug 12, 2025
Closed
bors added a commit that referenced this pull request Aug 12, 2025
@bors
Auto merge of#145293- Zalathar:rollup-rsp9t9l, r=Zalathar
1c7121c
Rollup of 17 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144210 (std: thread: Return error if setting thread stack size fails)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- #145283 (Make I-miscompile imply I-prioritize)
- #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
r? `@ghost`
`@rustbot` modify labels: rollup
@ZalatharZalathar mentioned this pull request Aug 12, 2025
Merged
bors added a commit that referenced this pull request Aug 12, 2025
@bors
Auto merge of#145300- Zalathar:rollup-0eqbt6a, r=Zalathar
d9dba3a
Rollup of 17 pull requests
Successful merges:
- #131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- #139806 (std: sys: pal: uefi: Overhaul Time)
- #144386 (Extract TraitImplHeader in AST/HIR)
- #144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- #145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- #145214 (fix: re-enable self-assignment)
- #145216 (rustdoc: correct negative-to-implicit discriminant display)
- #145238 (Tweak invalid builtin attribute output)
- #145249 (Rename entered trace span variables from `_span` to `_trace`)
- #145251 (Support using #[unstable_feature_bound] on trait)
- #145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- #145260 (Make explicit guarantees about `Vec`’s allocator)
- #145263 (Update books)
- #145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- #145283 (Make I-miscompile imply I-prioritize)
- #145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- #145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit dcc0b6b into rust-lang:masterAug 12, 2025
10 checks passed
@rustbotrustbot added this to the 1.91.0 milestone Aug 12, 2025
rust-timer added a commit that referenced this pull request Aug 12, 2025
@rust-timer
Unrolled build for#145283
07808c5
Rollup merge of #145283 - theemathas:patch-1, r=Noratrieb
Make I-miscompile imply I-prioritize
Since I-unsound already implies I-prioritize, it makes sense that I-miscompile should do the same.
github-actionsBot pushed a commit to rust-lang/miri that referenced this pull request Aug 13, 2025
@bors
Auto merge of #145300 - Zalathar:rollup-0eqbt6a, r=Zalathar
f393c32
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time)
- rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR)
- rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- rust-lang/rust#145214 (fix: re-enable self-assignment)
- rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display)
- rust-lang/rust#145238 (Tweak invalid builtin attribute output)
- rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`)
- rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait)
- rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator)
- rust-lang/rust#145263 (Update books)
- rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- rust-lang/rust#145283 (Make I-miscompile imply I-prioritize)
- rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- rust-lang/rust#145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 18, 2025
@bors
Auto merge of #145300 - Zalathar:rollup-0eqbt6a, r=Zalathar
7978029
Rollup of 17 pull requests
Successful merges:
- rust-lang/rust#131477 (Apple: Always pass SDK root when linking with `cc`, and pass it via `SDKROOT` env var)
- rust-lang/rust#139806 (std: sys: pal: uefi: Overhaul Time)
- rust-lang/rust#144386 (Extract TraitImplHeader in AST/HIR)
- rust-lang/rust#144921 (Don't emit `rustdoc::broken_intra_doc_links` for GitHub-flavored Markdown admonitions like `[!NOTE]`)
- rust-lang/rust#145155 (Port `#[allow_internal_unsafe]` to the new attribute system (attempt 2))
- rust-lang/rust#145214 (fix: re-enable self-assignment)
- rust-lang/rust#145216 (rustdoc: correct negative-to-implicit discriminant display)
- rust-lang/rust#145238 (Tweak invalid builtin attribute output)
- rust-lang/rust#145249 (Rename entered trace span variables from `_span` to `_trace`)
- rust-lang/rust#145251 (Support using #[unstable_feature_bound] on trait)
- rust-lang/rust#145253 (Document compiler and stdlib in stage1 in `pr-check-2` CI job)
- rust-lang/rust#145260 (Make explicit guarantees about `Vec`’s allocator)
- rust-lang/rust#145263 (Update books)
- rust-lang/rust#145273 (Account for new `assert!` desugaring in `!condition` suggestion)
- rust-lang/rust#145283 (Make I-miscompile imply I-prioritize)
- rust-lang/rust#145291 (bootstrap: Only warn about `rust.debug-assertions` if downloading rustc)
- rust-lang/rust#145292 (Fix a typo in range docs)
r? `@ghost`
`@rustbot` modify labels: rollup
@theemathas
theemathas deleted the patch-1 branch November 14, 2025 13:43
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Mark-SimulacrumMark-Simulacrum

Labels

A-metaArea: Issues & PRs about the rust-lang/rust repository itselfS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.91.0

Development

Successfully merging this pull request may close these issues.

5 participants

@theemathas@rustbot@Noratrieb@bors@Mark-Simulacrum