Uh oh!
There was an error while loading. Please reload this page.
Rollup of 11 pull requests - #154559
Merged
Merged
Conversation
Co-authored-by: stifskere <esteve@memw.es>
Similar to the existing `IoLines` item. It will be used in Clippy to detect uses of `Split` leading to infinite loops similar to the existing lint for `Lines`.
This is now exposed via `sysctl` as of macOS "Tahoe" 26.4 (or possibly earlier).
#docs doesn't seem to exist anymore, so point people to `t-libs`. Also include direct link to topic since Zulip is world-viewable now.
Exercises a self-referencing type alias with lazy_type_alias and min_generic_const_args, which previously caused an ICE during normalization.
…ulacrum don't drop arguments' temporaries in `dbg!` Fixesrust-lang#153850 Credit to @theemathas for help with macro engineering ^^ r? libs
…inarycat
rustdoc: add missing {os,target,target_env} values for cfg pretty printer…ble-path-suggestion, r=estebank Fix invalid type suggestion for item nested in function Fixesrust-lang#146786 I also tried to add the `omit_parent` logic in pretty formatter here: https://github.com/chenyukang/rust/blob/69b6d26d05006dca7556abc555fb0e029ecf1f4e/compiler/rustc_middle/src/ty/print/pretty.rs#L2240-L2295 so that we don't need to add `should_omit_parent_def_path` and `reset_path`. but seems there will be duplicate print code with `default_print_def_path`. maybe r? @estebank
…henyukang Add regression test for recursive lazy type alias normalization ICE Regression test for rust-lang#152633. The normalization ICE with recursive lazy_type_alias + min_generic_const_args was fixed by rust-lang#152040 but didn't get a test. Compiler now reports E0275 instead of crashing. Closesrust-lang#152633
…alueFormat-powerpc, r=marcoieni Fix LegacyKeyValueFormat report from docker build: powerpc Part of rust-lang#152305 r? @marcoieni
…Simulacrum feat: reimplement `hash_map!` macro originally implemented in rust-lang#144070, this had to be reverted in rust-lang#148049 due to name ambiguity, as the macro was automatically put into the prelude. now, that rust-lang#139493 has landed, it is possible to have a top-level macro, that is not exported by default, which should make it possible to reland this again. implements rust-lang#144032 implementation from rust-lang#144070, original author has been added as co-author effectively reverts rust-lang#148049
Add `IoSplit` diagnostic item for `std::io::Split` Similar to the existing `IoLines` item. It will be used in Clippy to detect uses of `Split` leading to infinite loops similar to the existing lint for `Lines`.
…ulacrum std_detect on AArch64 Darwin: Detect FEAT_SVE_B16B16 This is now exposed via `sysctl` as of macOS "Tahoe" 26.4 (or possibly earlier).
…e, r=jieyouxu Fix ambiguous parsing in bootstrap.py Noticed this while trying to produce rustdoc-json for std and saw JSON output from the bootstrap.py build of bootstrap's Rust code. This is technically a breaking change, but I think the fix should be simple and arguably an improvement in future compatibility if/when the flag set changes.
…mulacrum Panic in Hermit clock_gettime Follow-up to rust-lang#154234. r? @Mark-Simulacrum
…l, r=Noratrieb update zulip link in `std` documentation #docs doesn't seem to exist anymore, so point people to `t-libs`. Also include direct link to topic since Zulip is world-viewable now.
JonathanBrouwer
commented
Mar 29, 2026
MemberAuthor
@bors r+ rollup=never p=5 |
Contributor
JonathanBrouwer
commented
Mar 29, 2026
MemberAuthor
Trying commonly failed jobs |
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
Mar 29, 2026
Rollup of 11 pull requests try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
Uh oh!
There was an error while loading. Please reload this page.
rust-timer
commented
Mar 30, 2026
Collaborator
📌 Perf builds for each rolled up PR:
previous master: a25435bcf7 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing a25435b (parent) -> 80ad557 (this PR) Test differencesShow 84 test diffsStage 1
Stage 2
Additionally, 76 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 80ad55752e5ae6c2d1bc143b819eb8d1c00167d1 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Mar 30, 2026
Collaborator
Finished benchmarking commit (80ad557): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (secondary -2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 16.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 486.086s -> 490.149s (0.84%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
dbg!#154074 (don't drop arguments' temporaries indbg!)hash_map!macro #154322 (feat: reimplementhash_map!macro)IoSplitdiagnostic item forstd::io::Split#154416 (AddIoSplitdiagnostic item forstd::io::Split)stddocumentation #154530 (update zulip link instddocumentation)r? @ghost
Create a similar rollup