Skip to content

Refactor: shrink region ext traits - #160220

Merged
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Jamesbarford:chore/shrink-region-ext-triats
Jul 31, 2026
Merged

Refactor: shrink region ext traits#160220
rust-bors[bot] merged 2 commits into
rust-lang:mainfrom
Jamesbarford:chore/shrink-region-ext-triats

Conversation

@Jamesbarford

@JamesbarfordJamesbarford commented Jul 30, 2026

Copy link
Copy Markdown
Contributor
  • Removes RegionUtilitiesExt.
  • Ports, where trivially simple, methods from the extension traits to rustc_type_ir.
  • Cleans up imported crates where possible.

It seems EarlyParamRegion could possibly move to rust_type_ir?

r? @lcnr

@rustbot

rustbot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

clippy is developed in its own repository. If possible, consider making this change to rust-lang/rust-clippy instead.

cc @rust-lang/clippy

HIR ty lowering was modified

cc @fmease

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2026
@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jul 30, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Jamesbarford
Jamesbarfordforce-pushed the chore/shrink-region-ext-triats branch from ef6ce70 to edb5a64CompareJuly 30, 2026 14:46
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@JamesbarfordJamesbarford changed the title Chore/shrink region ext triatsChore/shrink region ext traitsJul 30, 2026
@JamesbarfordJamesbarford changed the title Chore/shrink region ext traitsRefactor: shrink region ext traitsJul 30, 2026
@Jamesbarford
Jamesbarfordforce-pushed the chore/shrink-region-ext-triats branch from edb5a64 to 6638f42CompareJuly 30, 2026 16:02
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@ChayimFriedman2

ChayimFriedman2 commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Moving methods is good, but I don't want to move EarlyParamRegion. rust-analyzer uses a different representation (a def id instead of Symbol name), and we'd like to change it further (only an index).

@Jamesbarford
Jamesbarfordforce-pushed the chore/shrink-region-ext-triats branch from 6638f42 to 543a403CompareJuly 31, 2026 07:35
@lcnr

lcnr commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup=iffy (lots of changes to imports)

@rust-bors

rust-borsBot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 543a403 has been approved by lcnr

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 31, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of#160284- JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
ad3d0bc
…uwer
Rollup of 22 pull requests
Successful merges:
- #160100 (Add "system" option to `override-allocator` directive)
- #160220 (Refactor: shrink region ext traits)
- #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- #154202 (rustfmt: Format `cfg_select!`)
- #159520 (Suggest `Vec<T>` instead of `[T]`)
- #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- #160066 (rustc_middle: lint attribute cleanups)
- #160085 (Remove various superfluous lint attributes)
- #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- #160157 (Remove outdated comments from `va_list.rs`)
- #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- #160244 (Rename splat to rustc_splat in error messages)
- #160246 (dont fire `unused_mut` on `&pin mut self`)
- #160247 (Configure backport nominations for rustfmt)
- #160274 (renovate: update lock files weekly)
@rust-bors
rust-borsBot merged commit 1488342 into rust-lang:mainJul 31, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 31, 2026
rust-timer added a commit that referenced this pull request Jul 31, 2026
@rust-timer
Unrolled build for#160220
31c55dc
Rollup merge of #160220 - Jamesbarford:chore/shrink-region-ext-triats, r=lcnr
Refactor: shrink region ext traits
- Removes `RegionUtilitiesExt`.
- Ports, where trivially simple, methods from the extension traits to `rustc_type_ir`.
- Cleans up imported crates where possible.
It seems `EarlyParamRegion` could possibly move to `rust_type_ir`?
r? @lcnr
flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 1, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160220- Jamesbarford:chore/shrink-region-e…
b075ea3
…xt-triats, r=lcnr
Refactor: shrink region ext traits
- Removes `RegionUtilitiesExt`.
- Ports, where trivially simple, methods from the extension traits to `rustc_type_ir`.
- Cleans up imported crates where possible.
It seems `EarlyParamRegion` could possibly move to `rust_type_ir`?
r? @lcnr
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 3, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
531cd3b
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
- rust-lang/rust#160220 (Refactor: shrink region ext traits)
- rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
- rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
- rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
- rust-lang/rust#160085 (Remove various superfluous lint attributes)
- rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
- rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
- rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
- rust-lang/rust#160247 (Configure backport nominations for rustfmt)
- rust-lang/rust#160274 (renovate: update lock files weekly)
@ChayimFriedman2ChayimFriedman2 mentioned this pull request Aug 12, 2026
Merged
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
7a86b4e
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
- rust-lang/rust#160220 (Refactor: shrink region ext traits)
- rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
- rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
- rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
- rust-lang/rust#160085 (Remove various superfluous lint attributes)
- rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
- rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
- rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
- rust-lang/rust#160247 (Configure backport nominations for rustfmt)
- rust-lang/rust#160274 (renovate: update lock files weekly)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lcnrlcnr

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-clippyRelevant to the Clippy team.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Jamesbarford@rustbot@rust-log-analyzer@ChayimFriedman2@lcnr