Skip to content

Bubble bad path error while parsing field to avoid unecessary second error - #160233

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:issue-92685
Jul 31, 2026
Merged

Bubble bad path error while parsing field to avoid unecessary second error#160233
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
estebank:issue-92685

Conversation

@estebank

@estebankestebank commented Jul 30, 2026•
edited by rustbot
Loading

Copy link
Copy Markdown
Contributor

Noticed while looking at #92685. Add test for the case in that ticket.

@rustbotrustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 30, 2026
@estebank
estebank marked this pull request as ready for review July 30, 2026 19:42
@rustbotrustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2026
@rustbot

rustbot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

The parser was modified, potentially altering the grammar of (stable) Rust
which would be a breaking change.

cc @fmease

@rustbotrustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 30, 2026
@rustbot

rustbot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 75 candidates
  • Random selection from 17 candidates

JohnTitor
JohnTitor approved these changes Jul 31, 2026
View reviewed changes

@JohnTitorJohnTitor left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @bors r+

View changes since this review

@rust-bors

rust-borsBot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 791e56a has been approved by JohnTitor

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160233- estebank:issue-92685, r=JohnTitor
741bba2
Bubble bad path error while parsing field to avoid unecessary second error
Noticed while looking at rust-lang#92685. Add test for the case in that ticket.
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 31, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of#160283- JonathanBrouwer:rollup-DJjXn4s, r=JonathanBro…
71a03d3
…uwer
Rollup of 21 pull requests
Successful merges:
- #160100 (Add "system" option to `override-allocator` directive)
- #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- #154202 (rustfmt: Format `cfg_select!`)
- #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
- #159520 (Suggest `Vec<T>` instead of `[T]`)
- #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- #160066 (rustc_middle: lint attribute cleanups)
- #160085 (Remove various superfluous lint attributes)
- #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- #160157 (Remove outdated comments from `va_list.rs`)
- #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- #160244 (Rename splat to rustc_splat in error messages)
- #160246 (dont fire `unused_mut` on `&pin mut self`)
- #160247 (Configure backport nominations for rustfmt)
- #160274 (renovate: update lock files weekly)
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 31, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of#160284- JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
ad3d0bc
…uwer
Rollup of 22 pull requests
Successful merges:
- #160100 (Add "system" option to `override-allocator` directive)
- #160220 (Refactor: shrink region ext traits)
- #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- #154202 (rustfmt: Format `cfg_select!`)
- #159520 (Suggest `Vec<T>` instead of `[T]`)
- #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- #160066 (rustc_middle: lint attribute cleanups)
- #160085 (Remove various superfluous lint attributes)
- #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- #160157 (Remove outdated comments from `va_list.rs`)
- #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- #160244 (Rename splat to rustc_splat in error messages)
- #160246 (dont fire `unused_mut` on `&pin mut self`)
- #160247 (Configure backport nominations for rustfmt)
- #160274 (renovate: update lock files weekly)
@rust-bors
rust-borsBot merged commit 239ab02 into rust-lang:mainJul 31, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 31, 2026
rust-timer added a commit that referenced this pull request Jul 31, 2026
@rust-timer
Unrolled build for#160233
1441f43
Rollup merge of #160233 - estebank:issue-92685, r=JohnTitor
Bubble bad path error while parsing field to avoid unecessary second error
Noticed while looking at #92685. Add test for the case in that ticket.
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 3, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
531cd3b
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
- rust-lang/rust#160220 (Refactor: shrink region ext traits)
- rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
- rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
- rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
- rust-lang/rust#160085 (Remove various superfluous lint attributes)
- rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
- rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
- rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
- rust-lang/rust#160247 (Configure backport nominations for rustfmt)
- rust-lang/rust#160274 (renovate: update lock files weekly)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
7a86b4e
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
- rust-lang/rust#160220 (Refactor: shrink region ext traits)
- rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
- rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
- rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
- rust-lang/rust#160085 (Remove various superfluous lint attributes)
- rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
- rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
- rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
- rust-lang/rust#160247 (Configure backport nominations for rustfmt)
- rust-lang/rust#160274 (renovate: update lock files weekly)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JohnTitorJohnTitorJohnTitor approved these changes

Assignees

@JohnTitorJohnTitor

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

3 participants

@estebank@rustbot@JohnTitor