Uh oh!
There was an error while loading. Please reload this page.
Rollup of 22 pull requests - #160284
Merged
Merged
Conversation
…arts of the compiler
`cfg_select!` parsing needs to be implemented in rustfmt right now because there's no good way to call `rustc_attr_parsing::parse_cfg_select`.
The plan is to leverage `rewrite_match_body` to help with `cfg_select!` formatting.
This allows a per-target `override-allocator` to revert to the system allocator even if there is a global rule specifying a different allocator. Remap `jemalloc = false` to `override-allocator = "system"` instead of mapping it to "override-allocator is unset"; this restores the correct precedence behaviour of this setting. This also allows `Config::override_allocator()` to always resolve the directive to a definite value, rather than needing it to be wrapped in an `Option`, which simplifies some other code. Finally, print a more specific warning when `jemalloc` is set, telling users the appropriate setting to use for `override-allocator` depending on whether `jemalloc` is set to true or false. Fixesrust-lang#160084
…n download rustc from CI
JonathanBrouwer
commented
Jul 31, 2026
MemberAuthor
Contributor
This comment has been minimized.
This comment has been minimized.
rust-borsBot
pushed a commit
that referenced
this pull request
Jul 31, 2026
Rollup of 22 pull requests try-job: dist-various-1 try-job: test-various try-job: x86_64-gnu-aux try-job: x86_64-gnu-llvm-21-3 try-job: x86_64-msvc-1 try-job: aarch64-apple try-job: x86_64-mingw-1 try-job: i686-msvc-*
Contributor
This comment has been minimized.
This comment has been minimized.
Contributor
Contributor
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 64af19d (parent) -> ad3d0bc (this PR) Test differencesShow 1047 test diffsStage 1
Stage 2
(and 53 additional test diffs) Additionally, 894 doctest diffs were found. These are ignored, as they are noisy. Job group index
Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard ad3d0bc141a02cf446e384136d250a1f6950fed5 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
rust-timer
commented
Jul 31, 2026
Collaborator
📌 Perf builds for each rolled up PR:
previous master: 64af19d44c In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
rust-timer
commented
Jul 31, 2026
Collaborator
Finished benchmarking commit (ad3d0bc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 2.6%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (primary 0.3%, secondary 0.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: 492.106s -> 495.641s (0.72%) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
override-allocatordirective #160100 (Add "system" option tooverride-allocatordirective)--jobsoptions for limiting parallelism in various parts of the compiler #159675 (rustc: Support--jobsoptions for limiting parallelism in various parts of the compiler)rustc_codegen_ssa#160272 (rustc_metadata: Move native library search code torustc_codegen_ssa)cfg_select!#154202 (rustfmt: Formatcfg_select!)Vec<T>instead of[T]#159520 (SuggestVec<T>instead of[T])#[allow_internal_unsafe/unstable]to attribute parser #160034 (Move "macro only" check for#[allow_internal_unsafe/unstable]to attribute parser)rustc_on_unimplementedattributes and lint malformed filters #160113 (Coalescerustc_on_unimplementedattributes and lint malformed filters)coroutine_hidden_typesfor the next solver #160119 (fix query cycle incoroutine_hidden_typesfor the next solver)-Zthreadsoptions from tests inui/parallel-rustc#160147 (tests: Remove-Zthreadsoptions from tests inui/parallel-rustc)va_list.rs#160157 (Remove outdated comments fromva_list.rs)invalid_reference_castinglint #160159 (More accurately check for interior mutability ininvalid_reference_castinglint)unused_muton&pin mut self#160246 (dont fireunused_muton&pin mut self)r? @ghost
Create a similar rollup