Skip to content

dont fire unused_mut on &pin mut self - #160246

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Albab-Hasan:pin-ergonomics-unused-mut
Jul 31, 2026
Merged

dont fire unused_mut on &pin mut self#160246
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
Albab-Hasan:pin-ergonomics-unused-mut

Conversation

@Albab-Hasan

@Albab-HasanAlbab-Hasan commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

SelfKind::Pinned in Param::from_self was setting the binding mutability to mutbl, so &pin mut self produced a mutable binding and triggered unused_mut spuriously. the mut qualifies the pin reference, not the binding. same as SelfKind::Region which uses Mutability::Not.

fixes#142077

r? @petrochenkov

@Albab-Hasan
don't fire unused_mut on &pin mut self
7f51ec6
`SelfKind::Pinned` in `Param::from_self` was setting the binding mutability
to `mutbl`, so `&pin mut self` produced a mutable binding and triggered
`unused_mut` spuriously. the `mut` qualifies the pin reference, not the
binding -- same as `SelfKind::Region` which uses `Mutability::Not`.
fixesrust-lang#142077
@rustbotrustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 31, 2026
@petrochenkov

petrochenkov commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-borsBot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 7f51ec6 has been approved by petrochenkov

It is now in the queue for this repository.

@rust-borsrust-borsBot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 31, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160246- Albab-Hasan:pin-ergonomics-unused-…
771a7b3
…mut, r=petrochenkov
dont fire `unused_mut` on `&pin mut self`
`SelfKind::Pinned` in `Param::from_self` was setting the binding mutability to `mutbl`, so `&pin mut self` produced a mutable binding and triggered `unused_mut` spuriously. the `mut` qualifies the pin reference, not the binding. same as `SelfKind::Region` which uses `Mutability::Not`.
fixesrust-lang#142077
r? @petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 31, 2026
Closed
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Jul 31, 2026
@JonathanBrouwer
Rollup merge ofrust-lang#160246- Albab-Hasan:pin-ergonomics-unused-…
9ed0bea
…mut, r=petrochenkov
dont fire `unused_mut` on `&pin mut self`
`SelfKind::Pinned` in `Param::from_self` was setting the binding mutability to `mutbl`, so `&pin mut self` produced a mutable binding and triggered `unused_mut` spuriously. the `mut` qualifies the pin reference, not the binding. same as `SelfKind::Region` which uses `Mutability::Not`.
fixesrust-lang#142077
r? @petrochenkov
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 31, 2026
Closed
rust-borsBot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of#160283- JonathanBrouwer:rollup-DJjXn4s, r=JonathanBro…
71a03d3
…uwer
Rollup of 21 pull requests
Successful merges:
- #160100 (Add "system" option to `override-allocator` directive)
- #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- #154202 (rustfmt: Format `cfg_select!`)
- #158835 (rustc_passes: lint unused `#[path]` attributes on inline modules)
- #159520 (Suggest `Vec<T>` instead of `[T]`)
- #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- #160066 (rustc_middle: lint attribute cleanups)
- #160085 (Remove various superfluous lint attributes)
- #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- #160157 (Remove outdated comments from `va_list.rs`)
- #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- #160244 (Rename splat to rustc_splat in error messages)
- #160246 (dont fire `unused_mut` on `&pin mut self`)
- #160247 (Configure backport nominations for rustfmt)
- #160274 (renovate: update lock files weekly)
@JonathanBrouwerJonathanBrouwer mentioned this pull request Jul 31, 2026
Merged
rust-borsBot pushed a commit that referenced this pull request Jul 31, 2026
@bors
Auto merge of#160284- JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
ad3d0bc
…uwer
Rollup of 22 pull requests
Successful merges:
- #160100 (Add "system" option to `override-allocator` directive)
- #160220 (Refactor: shrink region ext traits)
- #159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- #159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- #160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- #160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- #154202 (rustfmt: Format `cfg_select!`)
- #159520 (Suggest `Vec<T>` instead of `[T]`)
- #159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- #160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- #160066 (rustc_middle: lint attribute cleanups)
- #160085 (Remove various superfluous lint attributes)
- #160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- #160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- #160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- #160157 (Remove outdated comments from `va_list.rs`)
- #160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- #160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- #160244 (Rename splat to rustc_splat in error messages)
- #160246 (dont fire `unused_mut` on `&pin mut self`)
- #160247 (Configure backport nominations for rustfmt)
- #160274 (renovate: update lock files weekly)
@rust-bors
rust-borsBot merged commit 718c55f into rust-lang:mainJul 31, 2026
13 checks passed
@rustbotrustbot added this to the 1.99.0 milestone Jul 31, 2026
rust-timer added a commit that referenced this pull request Jul 31, 2026
@rust-timer
Unrolled build for#160246
9e6b9e0
Rollup merge of #160246 - Albab-Hasan:pin-ergonomics-unused-mut, r=petrochenkov
dont fire `unused_mut` on `&pin mut self`
`SelfKind::Pinned` in `Param::from_self` was setting the binding mutability to `mutbl`, so `&pin mut self` produced a mutable binding and triggered `unused_mut` spuriously. the `mut` qualifies the pin reference, not the binding. same as `SelfKind::Region` which uses `Mutability::Not`.
fixes#142077
r? @petrochenkov
github-actionsBot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Aug 3, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
531cd3b
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
- rust-lang/rust#160220 (Refactor: shrink region ext traits)
- rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
- rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
- rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
- rust-lang/rust#160085 (Remove various superfluous lint attributes)
- rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
- rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
- rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
- rust-lang/rust#160247 (Configure backport nominations for rustfmt)
- rust-lang/rust#160274 (renovate: update lock files weekly)
flip1995 pushed a commit to flip1995/rust-clippy that referenced this pull request Aug 17, 2026
@bors
Auto merge of #160284 - JonathanBrouwer:rollup-Jwar7OO, r=JonathanBro…
7a86b4e
…uwer
Rollup of 22 pull requests
Successful merges:
- rust-lang/rust#160100 (Add "system" option to `override-allocator` directive)
- rust-lang/rust#160220 (Refactor: shrink region ext traits)
- rust-lang/rust#159675 (rustc: Support `--jobs` options for limiting parallelism in various parts of the compiler)
- rust-lang/rust#159999 (Fix invalidation of stdlib in bootstrap when using non-LLVM codegen backends)
- rust-lang/rust#160233 (Bubble bad path error while parsing field to avoid unecessary second error)
- rust-lang/rust#160272 (rustc_metadata: Move native library search code to `rustc_codegen_ssa`)
- rust-lang/rust#154202 (rustfmt: Format `cfg_select!`)
- rust-lang/rust#159520 (Suggest `Vec<T>` instead of `[T]`)
- rust-lang/rust#159710 (Add rustdoc/cargo PGO profiles to reproducible artifacts)
- rust-lang/rust#160034 (Move "macro only" check for `#[allow_internal_unsafe/unstable]` to attribute parser)
- rust-lang/rust#160066 (rustc_middle: lint attribute cleanups)
- rust-lang/rust#160085 (Remove various superfluous lint attributes)
- rust-lang/rust#160113 (Coalesce `rustc_on_unimplemented` attributes and lint malformed filters)
- rust-lang/rust#160119 (fix query cycle in `coroutine_hidden_types` for the next solver)
- rust-lang/rust#160147 (tests: Remove `-Zthreads` options from tests in `ui/parallel-rustc`)
- rust-lang/rust#160157 (Remove outdated comments from `va_list.rs`)
- rust-lang/rust#160159 (More accurately check for interior mutability in `invalid_reference_casting` lint)
- rust-lang/rust#160208 (rustdoc: Fix crash when trying to list attributes on an opaque type)
- rust-lang/rust#160244 (Rename splat to rustc_splat in error messages)
- rust-lang/rust#160246 (dont fire `unused_mut` on `&pin mut self`)
- rust-lang/rust#160247 (Configure backport nominations for rustfmt)
- rust-lang/rust#160274 (renovate: update lock files weekly)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.99.0

Development

Successfully merging this pull request may close these issues.

diagnostics: pin_ergonomics: unused_mut spans are wrong, would destroy code

3 participants

@Albab-Hasan@petrochenkov@rustbot