Uh oh!
There was an error while loading. Please reload this page.
Add common macros to TRPL - #24516
Merged
Merged
Conversation
rust-highfive
commented
Apr 17, 2015
Contributor
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
Member
There was a problem hiding this comment.
Could these be tagged with no_run instead of ignore wherever possible?
steveklabnik
commented
Apr 20, 2015
ContributorAuthor
@alexcrichton updated! |
alexcrichton
commented
Apr 20, 2015
Member
bors
commented
Apr 20, 2015
Collaborator
⌛ Testing commit b4dc187 with merge a0369bd... |
Contributor
There was a problem hiding this comment.
why ignore here but no_run elsewhere?
ContributorAuthor
There was a problem hiding this comment.
you're right, this can be no_run too
steveklabnik
commented
Apr 20, 2015
ContributorAuthor
oh, huh |
steveklabnik
commented
Apr 20, 2015
ContributorAuthor
@bors: r=alexcrichton rollup |
bors
commented
Apr 20, 2015
Collaborator
📌 Commit 1e29abe has been approved by |
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 20, 2015
steveklabnik added a commit
to steveklabnik/rust
that referenced
this pull request
Apr 21, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#22621