Uh oh!
There was an error while loading. Please reload this page.
Refocus unsafe code chapter on unsafe itself. - #24640
Conversation
rust-highfive
commented
Apr 20, 2015
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
brson
commented
Apr 20, 2015
@bors r+ rollup |
bors
commented
Apr 20, 2015
📌 Commit e7111e7 has been approved by |
huonw
commented
Apr 20, 2015
I assume you're intending to spread the content here into other sections? I feel like having a focused sub-guide for unsafe code (i.e. some organisation beyond just a pile of chapters mixed in with the rest of Syntax and Semantics or whatever) is useful: it is hard enough to write Maybe the organisation could be using this section as a landing page that links to all the other related sections? |
bors
commented
Apr 21, 2015
⌛ Testing commit e7111e7 with merge a3bb026... |
bors
commented
Apr 21, 2015
💔 Test failed - auto-win-32-nopt-t |
steveklabnik
commented
Apr 21, 2015
@bors: r=brson rollup |
bors
commented
Apr 21, 2015
📌 Commit e7111e7 has been approved by |
steveklabnik
commented
Apr 21, 2015
@huonw yes, a "Writing Safe Abstractions" chapter would be awesome in Effective Rust, but after moving most of what was in the unsafe guide to the unstable section, looking at this chapter, there's basically raw pointer stuff, and some comments about making unsafe things safer. In the new, semantics-oriented layout of these chapters, raw pointers deserve their own intro, and so does |
e7111e7 to
9cc0af8Comparesteveklabnik
commented
Apr 21, 2015
@bors: r=brson rollup |
bors
commented
Apr 21, 2015
📌 Commit 9cc0af8 has been approved by |
huonw
commented
Apr 21, 2015
@steveklabnik as long as you have a plan! (That plan sounds good to me.) |
rust-lang#24631 is related, as it will delete this from the TOC, but I want to keep it here.
#24631 is related, as it will delete this from the TOC, but I want to keep it here.