Skip to content

TRPL: if let - #24643

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:doc_if_let
Apr 21, 2015
Merged

TRPL: if let#24643
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:doc_if_let

Conversation

@steveklabnik

@steveklabniksteveklabnik commented Apr 20, 2015

Copy link
Copy Markdown
Contributor

and while let

@rust-highfive

rust-highfive commented Apr 20, 2015

Copy link
Copy Markdown
Contributor

r? @pcwalton

(rust_highfive has picked a reviewer for you, use r? to override)

ghost
ghost reviewed Apr 20, 2015
View reviewed changes
Comment threadsrc/doc/trpl/if-let.md Outdated

@ghostghostApr 20, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

“things” seems too colloquial to my taste.

@steveklabniksteveklabnikApr 20, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure what word to use exactly, suggestions welcome :)

@ghostghostApr 20, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, maybe “binds any appropriate parts of the value to the identifiers in the pattern”? subvalues or substructures seem too jargony on the contrary.

@steveklabniksteveklabnikApr 20, 2015

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ghost
ghost reviewed Apr 20, 2015
View reviewed changes
Comment threadsrc/doc/trpl/if-let.md Outdated

@ghostghostApr 20, 2015

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here. It's not clear what is meant by “result of a pattern” since that's not a term we seem to use at all. Maybe:

In a similar fashion, while let can be used when you want to conditionally loop as long as a value matches a certain pattern. It turns code like this:

@steveklabnik
TRPL: if let
570b250
and while let
@steveklabnik

steveklabnik commented Apr 20, 2015

Copy link
Copy Markdown
ContributorAuthor

@jakub- thanks! Addressed on all fronts, and better for it. 😄

@ghost

ghost commented Apr 21, 2015

Copy link
Copy Markdown

Sweet!

@bors r+ 570b250 rollup

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 21, 2015
@steveklabnik
Rollup merge ofrust-lang#24643- steveklabnik:doc_if_let, r=jakub-
1d082de
and while let
@steveklabniksteveklabnik mentioned this pull request Apr 21, 2015
Merged
bors added a commit that referenced this pull request Apr 21, 2015
@bors
Auto merge of#24648- steveklabnik:rollup, r=steveklabnik
21c48c3
- Successful merges: #24514, #24516, #24571, #24577, #24625, #24627, #24628, #24629, #24630, #24631, #24632, #24642, #24643, #24647
- Failed merges: #24640
@bors
bors merged commit 570b250 into rust-lang:masterApr 21, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichtonalexcrichton

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@steveklabnik@rust-highfive@alexcrichton@pcwalton@bors