Uh oh!
There was an error while loading. Please reload this page.
Remove feature gated examples from the reference - #24577
Conversation
rust-highfive
commented
Apr 18, 2015
r? @pcwalton (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
commented
Apr 19, 2015
I can see where we may want to remove as many feature-gated examples as possible, but some of these seem like they may still be useful? For example the one showing off slice patterns is probably good to keep. |
pnkfelix
commented
Apr 19, 2015
maybe we should move them to an isolated section of the documentation? That way the examples are preserved, without having them in the middle of the text that users on the beta or release channels are reading? |
steveklabnik
commented
Apr 20, 2015
Yes, so the reason I just killed these examples is that we have a specific unstable section of the book for describing unstable features. And I'm not sure it's worth time finding alternate examples of things when the reference needs a general cleaning up anyway, which is where I'd go over things like 'does this deserve an example' |
alexcrichton
commented
Apr 20, 2015
Ok, but some of these I believe can be updated to not use feature gates, so perhaps they could be tweaked to stay wherever possible? |
1966ca3 to
0f20c9dCompareThe slice patterns example was nice, so let's put it with the other slice pattern feature gate documentation. Fixesrust-lang#24573
steveklabnik
commented
Apr 20, 2015
@alexcrichton seems legit. I've fixed up the examples, and moved the slice patterns one out. Only one or two got totally axed, because they were about box patterns, primarily. |
Fixes#24573