Uh oh!
There was an error while loading. Please reload this page.
Change build helper to modify suffix - #32729
Conversation
This should help avoid issues when using tools like ccache.
rust-highfive
commented
Apr 4, 2016
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
alexcrichton
commented
Apr 4, 2016
bors
commented
Apr 6, 2016
⌛ Testing commit 0fe1359 with merge 3950cd0... |
bors
commented
Apr 6, 2016
⛄ The build was interrupted to prioritize another pull request. |
…=alexcrichton Change build helper to modify suffix The current implementation of [gcc](https://crates.io/crates/gcc) defaults to using the ```CC``` environment variable to determine the compiler. The current global-find-replace in ```build_helper``` causes issues for projects using tools like ```ccache``` if they try to integrate libstd into their build system. Almost all cross-compiler toolchains have the tool name as a suffix of the filename, so changing this to suffix-replacement instead of global-replacement should be fine.
…=alexcrichton Change build helper to modify suffix The current implementation of [gcc](https://crates.io/crates/gcc) defaults to using the ```CC``` environment variable to determine the compiler. The current global-find-replace in ```build_helper``` causes issues for projects using tools like ```ccache``` if they try to integrate libstd into their build system. Almost all cross-compiler toolchains have the tool name as a suffix of the filename, so changing this to suffix-replacement instead of global-replacement should be fine.
The current implementation of gcc defaults to using the
CCenvironment variable to determine the compiler. The current global-find-replace inbuild_helpercauses issues for projects using tools likeccacheif they try to integrate libstd into their build system.Almost all cross-compiler toolchains have the tool name as a suffix of the filename, so changing this to suffix-replacement instead of global-replacement should be fine.