Skip to content

Add mention to RFC 940 in the Rust Reference. - #33362

Merged
bors merged 2 commits into
rust-lang:masterfrom
andradei:master
Jul 17, 2016
Merged

Add mention to RFC 940 in the Rust Reference.#33362
bors merged 2 commits into
rust-lang:masterfrom
andradei:master

Conversation

@andradei

@andradeiandradei commented May 2, 2016

Copy link
Copy Markdown

This PR adds a mention to hyphens in Cargo package names being replaced by underscores when used as a crate, as per RFC 940

It also formats the RFCs consistently as RFC XXX instead of RFCXXX.

Isaac Andrade
Add mention to RFC 940 in the Rust Reference.
8f76f93
- It also keeps mentions to RFCs consistent with the format "RFC XXX"
@rust-highfive

rust-highfive commented May 2, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Manishearth
Manishearth reviewed May 3, 2016
View reviewed changes
Comment threadsrc/doc/reference.md Outdated
```

When naming Rust crates, hyphens are disallowed. However, Cargo packages may
make use of them. In such case, when `cargo.toml` doesn't specify a crate name,

@ManishearthManishearthMay 3, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cargo.toml is has a capital c

@Manishearth

Manishearth commented May 3, 2016

Copy link
Copy Markdown
Member

lgtm, one nit

birkenfeld
birkenfeld reviewed May 3, 2016
View reviewed changes
Comment threadsrc/doc/reference.md Outdated

```{.ignore}
// Importing the Cargo package hello-world/
extern crate hello_world; // The crate name replaced the hyphen

@birkenfeldbirkenfeldMay 3, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • trailing / looks suspicious?
  • did you mean "The underscore replaced the hyphen"?

@andradei

andradei commented May 3, 2016

Copy link
Copy Markdown
Author

Thanks for catching the discrepancies. I hope the changes are better phrased now.

@apasel422

apasel422 commented Jul 15, 2016

Copy link
Copy Markdown
Contributor

Ping @Manishearth.

@Manishearth

Manishearth commented Jul 16, 2016

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Jul 16, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit ba6ce12 has been approved by Manishearth

@GuillaumeGomezGuillaumeGomez mentioned this pull request Jul 16, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 16, 2016
@GuillaumeGomez
Rollup merge ofrust-lang#33362- andradei:master, r=Manishearth
1fb707d
Add mention to RFC 940 in the Rust Reference.
This PR adds a mention to hyphens in Cargo package names being replaced by underscores when used as a crate, as per [RFC 940](https://github.com/rust-lang/rfcs/blob/master/text/0940-hyphens-considered-harmful.md)
It also formats the RFCs consistently as RFC XXX instead of RFCXXX.
bors added a commit that referenced this pull request Jul 17, 2016
@bors
Auto merge of#34852- GuillaumeGomez:rollup, r=GuillaumeGomez
103e5c9
Rollup of 7 pull requests
- Successful merges: #33362, #34768, #34837, #34838, #34847, #34848, #34849
- Failed merges: #33951, #34850
@bors
bors merged commit ba6ce12 into rust-lang:masterJul 17, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ManishearthManishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andradei@rust-highfive@Manishearth@apasel422@bors@birkenfeld