Uh oh!
There was an error while loading. Please reload this page.
Rollup of 7 pull requests - #34852
Merged
Merged
Conversation
GuillaumeGomez
commented
Jul 16, 2016
Member
- Successful merges: Add mention to RFC 940 in the Rust Reference. #33362, std: Correct tracking issue for SipHash{13,24} #34768, Improve float number example #34837, Fix up documentation around no_std #34838, Add missing inline code delimiters around Vec<T> #34847, doc: remove stray comma #34848, doc: remove extraneous word #34849
- Failed merges: run rustfmt on librustc_passes folder #33951, doc: add missing pause #34850
- It also keeps mentions to RFCs consistent with the format "RFC XXX"
The referenced tracking issue was closed and was actually about changing the algorithm. cc rust-lang#34767
1. Fix the sections in the book to have the correct signatures. I've also marked them as `ignore`; there's no way to set the `no_std` feature for libc, so it pulls in the stdlib, so this wasn't even testing the actual thing it was testing. Better to just ignore. 2. Correcting libcore's docs for factual inaccuracy, and add a note about language items. Fixesrust-lang#33677
Add mention to RFC 940 in the Rust Reference. This PR adds a mention to hyphens in Cargo package names being replaced by underscores when used as a crate, as per [RFC 940](https://github.com/rust-lang/rfcs/blob/master/text/0940-hyphens-considered-harmful.md) It also formats the RFCs consistently as RFC XXX instead of RFCXXX.
std: Correct tracking issue for SipHash{13,24}
The referenced tracking issue was closed and was actually about changing the
algorithm.
cc rust-lang#34767…gisa Improve float number example r? @nagisa
Fix up documentation around no_std 1. Fix the sections in the book to have the correct signatures. I've also marked them as `ignore`; there's no way to set the `no_std` feature for libc, so it pulls in the stdlib, so this wasn't even testing the actual thing it was testing. Better to just ignore. 2. Correcting libcore's docs for factual inaccuracy, and add a note about language items. Fixesrust-lang#33677 r? @alexcrichton
Add missing inline code delimiters around Vec<T> r? @steveklabnik
doc: remove stray comma
doc: remove extraneous word
rust-highfive
commented
Jul 16, 2016
Contributor
r? @Manishearth (rust_highfive has picked a reviewer for you, use r? to override) |
GuillaumeGomez
commented
Jul 16, 2016
MemberAuthor
@bors: r+ p=1 |
bors
commented
Jul 16, 2016
Collaborator
📌 Commit 45f8427 has been approved by |
bors
commented
Jul 16, 2016
Collaborator
⌛ Testing commit 45f8427 with merge 0b8db7b... |
bors
commented
Jul 16, 2016
Collaborator
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
Contributor
bors
commented
Jul 17, 2016
Collaborator
bors added a commit
that referenced
this pull request
Jul 17, 2016
bors
commented
Jul 17, 2016
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.