Uh oh!
There was an error while loading. Please reload this page.
Fix up documentation around no_std - #34838
Conversation
alexcrichton
commented
Jul 15, 2016
I wonder if we can also make sure these is all plastered with "zomg this is unstable"? Documenting things like symbol names makes me a little queasy as I don't want anyone relying on that ever basically |
There was a problem hiding this comment.
Whoops, this was just the previous text.
steveklabnik
commented
Jul 15, 2016
So, the book part is explicitly in "unstable rust", but making it more clear in libcore's docs is something I can do! |
alexcrichton
commented
Jul 15, 2016
Ok! Sounds good to me, looks like travis failure is legit though: r=me other than that though |
1. Fix the sections in the book to have the correct signatures. I've also marked them as `ignore`; there's no way to set the `no_std` feature for libc, so it pulls in the stdlib, so this wasn't even testing the actual thing it was testing. Better to just ignore. 2. Correcting libcore's docs for factual inaccuracy, and add a note about language items. Fixesrust-lang#33677
steveklabnik
commented
Jul 15, 2016
Whoops, I was checking as I wrote it, but missed it in the end. Should be good now, let's see what travis says. |
alexcrichton
commented
Jul 15, 2016
GuillaumeGomez
commented
Jul 16, 2016
@bors: rollup |
Fix up documentation around no_std 1. Fix the sections in the book to have the correct signatures. I've also marked them as `ignore`; there's no way to set the `no_std` feature for libc, so it pulls in the stdlib, so this wasn't even testing the actual thing it was testing. Better to just ignore. 2. Correcting libcore's docs for factual inaccuracy, and add a note about language items. Fixesrust-lang#33677 r? @alexcrichton
also marked them as
ignore; there's no way to set theno_stdfeature for libc, so it pulls in the stdlib, so this wasn't even
testing the actual thing it was testing. Better to just ignore.
about language items.
Fixes#33677
r? @alexcrichton