Skip to content

A disclaimer about keywords. - #34370

Merged
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:keyword-ref-mention
Aug 17, 2016
Merged

A disclaimer about keywords.#34370
bors merged 1 commit into
rust-lang:masterfrom
steveklabnik:keyword-ref-mention

Conversation

@steveklabnik

@steveklabniksteveklabnik commented Jun 19, 2016

Copy link
Copy Markdown
Contributor

Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.

@rust-highfive

rust-highfive commented Jun 19, 2016

Copy link
Copy Markdown
Contributor

r? @Manishearth

(rust_highfive has picked a reviewer for you, use r? to override)

@durka

durka commented Jun 19, 2016

Copy link
Copy Markdown
Contributor

Can we italicize (or something) the ones that are reserved yet unused?

@killercup

killercup commented Jun 20, 2016

Copy link
Copy Markdown
Contributor

Did you mean to add the grammar/verify file?

@Manishearth

Manishearth commented Jun 20, 2016

Copy link
Copy Markdown
Member

r=me with the bin file removed and possible italicization

@matklad

matklad commented Jun 20, 2016

Copy link
Copy Markdown
Contributor

Can we italicize (or something) the ones that are reserved yet unused?

Perhaps just use two alphabetically sorted tables: reserved words and keywords?

@alexcrichton

alexcrichton commented Jul 19, 2016

Copy link
Copy Markdown
Member

@steveklabnik ping on this review comment

@dns2utf8

dns2utf8 commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

I think the grammar/verify should not be in the commit, as it is generated on demand (#34994) and in the grammar/.gitignore

@steveklabnik
A disclaimer about keywords.
85bbbad
Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
@steveklabnik

steveklabnik commented Aug 15, 2016

Copy link
Copy Markdown
ContributorAuthor

@bors: r=Manishearth rollup

I want to land this patch without worrying about "how are we gonna keep the reference up to date with keywords being implemented," and they have fantastic error messages at the moment.

@bors

bors commented Aug 15, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 85bbbad has been approved by Manishearth

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Jonathan Turner
Rollup merge ofrust-lang#34370- steveklabnik:keyword-ref-mention, r…
5c940b1
…=Manishearth
A disclaimer about keywords.
Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
@sophiajtsophiajt mentioned this pull request Aug 17, 2016
Closed
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of#35743- jonathandturner:rollup, r=jonathandturner
b28ffa5
Rollup of 24 pull requests
- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35691, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Jonathan Turner
Rollup merge ofrust-lang#34370- steveklabnik:keyword-ref-mention, r…
e83bff9
…=Manishearth
A disclaimer about keywords.
Some people cite this list as "zomg Rust has so many keywords," so make
it clear that these aren't all used by the language today.
@sophiajtsophiajt mentioned this pull request Aug 17, 2016
Merged
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of#35747- jonathandturner:rollup, r=jonathandturner
7ac11ca
Rollup of 23 pull requests
- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
@bors
bors merged commit 85bbbad into rust-lang:masterAug 17, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ManishearthManishearth

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@steveklabnik@rust-highfive@durka@killercup@Manishearth@matklad@alexcrichton@dns2utf8@bors