Skip to content

Update error E0365 to new format - #35670

Merged
bors merged 1 commit into
rust-lang:masterfrom
Xinayder:e0365
Aug 17, 2016
Merged

Update error E0365 to new format#35670
bors merged 1 commit into
rust-lang:masterfrom
Xinayder:e0365

Conversation

@Xinayder

@XinayderXinayder commented Aug 14, 2016

Copy link
Copy Markdown
Contributor

Fixes#35633 as part of #35233.

r? @jonathandturner

@rust-highfive

rust-highfive commented Aug 14, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt

sophiajt commented Aug 14, 2016

Copy link
Copy Markdown
Contributor

Thanks for the PR!

Looks good so far. The next step you'll need to do is to run this through tidy and fix any warnings tidy gives you.

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

@sophiajt

sophiajt commented Aug 14, 2016

Copy link
Copy Markdown
Contributor

Actually, this looks like it might be clean. Let's give it a try.

@bors r+ rollup

@bors

bors commented Aug 14, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit a026e2c has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 15, 2016
Jonathan Turner
Rollup merge ofrust-lang#35670- RockyTV:e0365, r=jonathandturner
cf2a53a
Update error E0365 to new format
Fixesrust-lang#35633 as part of rust-lang#35233.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 15, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Jonathan Turner
Rollup merge ofrust-lang#35670- RockyTV:e0365, r=jonathandturner
5b6e6dc
Update error E0365 to new format
Fixesrust-lang#35633 as part of rust-lang#35233.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 17, 2016
Closed
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of#35743- jonathandturner:rollup, r=jonathandturner
b28ffa5
Rollup of 24 pull requests
- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35691, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Jonathan Turner
Rollup merge ofrust-lang#35670- RockyTV:e0365, r=jonathandturner
02a8e2c
Update error E0365 to new format
Fixesrust-lang#35633 as part of rust-lang#35233.
r? @jonathandturner
@sophiajtsophiajt mentioned this pull request Aug 17, 2016
Merged
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of#35747- jonathandturner:rollup, r=jonathandturner
7ac11ca
Rollup of 23 pull requests
- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
@bors
bors merged commit a026e2c into rust-lang:masterAug 17, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sophiajtsophiajt

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Xinayder@rust-highfive@sophiajt@bors