Uh oh!
There was an error while loading. Please reload this page.
Rollup of 24 pull requests - #35743
Closed
sophiajt wants to merge 53 commits into
Closed
Conversation
Explain why Rust does not implement traits for large arrays. Explain why most methods are implemented on slices rather than arrays.
The spacing seems inconsistent with existing style conventions.
Some people cite this list as "zomg Rust has so many keywords," so make it clear that these aren't all used by the language today.
Instead of listing every field it will now show missing `a`, `z`, `b`, and 1 other field
I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.
Display all the remaining items of the iterator, similar to the `Debug` implementation for `core::slice::Iter`: https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937 Using the `as_slice` method that was added in: rust-lang#35447
…=Manishearth A disclaimer about keywords. Some people cite this list as "zomg Rust has so many keywords," so make it clear that these aren't all used by the language today.
added 19 commits
August 16, 2016 22:19
…=nikomatsakis run rustfmt on libsyntax_ext folder
…schkaj Add doc example for `std::ffi::CString::from_vec_unchecked`. None
Update E0207 label to report parameter type Fixesrust-lang#35642. r? @jonathandturner (Is this okay? I tagged you since it's a simple error fix similar to the other update ones.)
Improve `No stdlib` and related Documentation This renames all lang item function names to the ones used in `libstd` and `libpanic_unwind`. It also explains the `eh_unwind_resume` lang item in the `libcore` documentation, where it was missing. A third function is also needed on certain compilation targets, so this was also added to the `No stdlib` documentation.
Update error E0365 to new format Fixesrust-lang#35633 as part of rust-lang#35233. r? @jonathandturner
Update E0392 to new error format Fixesrust-lang#35631. Part of rust-lang#35233 r? @jonathandturner or @GuillaumeGomez
Update E0322 to new format Fixesrust-lang#35323. Part of rust-lang#35233. r? @GuillaumeGomez
Fix spacing in code of closures.md The spacing seems inconsistent with existing style conventions.
update E0375 to new format fixesrust-lang#35635 as part of rust-lang#35233. r? @jonathandturner
…ed, r=steveklabnik expound on limitations of Rust's trait-based operator overloading Part of rust-lang#29330
…dturner Update the wording for E0063. This will truncate the fields to 3. Instead of listing every field it will now show missing `a`, `z`, `b`, and 1 other field This is for rust-lang#35218 as part of rust-lang#35233 r? @jonathandturner
…tln, r=GuillaumeGomez accumulate into vector and assert, instead of printing I'm only making this change in one place so that people can express their preferences for this stylistic change. If/when this change is approved I'll go ahead and translate the rest of the `std::ops` examples.
…xcrichton Implement `Debug` for `std::vec::IntoIter`. Display all the remaining items of the iterator, similar to the `Debug` implementation for `core::slice::Iter`: https://github.com/rust-lang/rust/blob/f0bab98695f0a4877daabad9a5b0ba3e66121392/src/libcore/slice.rs#L930-L937 Using the `as_slice` method that was added in: rust-lang#35447
…sakis RUST_NEW_ERROR_FORMAT is no more So stop setting the environment variable.
Use UI test to test spans, instead of forced line break There must be lots more, but these are what I could easily find.
…andturner Updated E0394 & E0422 to new format Fixesrust-lang#35692 and rust-lang#35700, as part of rust-lang#35233. r? @jonathandturner
Bump version to 1.13
update E0409 to new error format fixesrust-lang#35699 as part of rust-lang#35233. r? @jonathandturner
Update E0005 to use a label Fixesrust-lang#35192 as Part of rust-lang#35233 r? @jonathandturner
rust-highfive
commented
Aug 17, 2016
Contributor
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
sophiajt
commented
Aug 17, 2016
ContributorAuthor
@bors r+ p=1 |
bors
commented
Aug 17, 2016
Collaborator
📌 Commit 11be7c0 has been approved by |
TimNN
commented
Aug 17, 2016
Contributor
#35691 has a legit travis failure, failing this pr (in a local build) as well. |
bors
commented
Aug 17, 2016
Collaborator
bors
commented
Aug 17, 2016
Collaborator
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
std::ffi::CString::from_vec_unchecked. #35621, Update E0207 label to report parameter type #35660, ImproveNo stdliband related Documentation #35663, Update error E0365 to new format #35670, Update E0392 to new error format #35671, Update E0322 to new format #35672, Fix spacing in code of closures.md #35681, update E0375 to new format #35686, expound on limitations of Rust's trait-based operator overloading #35690, Update the wording for E0063. This will truncate the fields to 3. #35691, accumulate into vector and assert, instead of printing #35695, ImplementDebugforstd::vec::IntoIter. #35707, RUST_NEW_ERROR_FORMAT is no more #35708, Use UI test to test spans, instead of forced line break #35713, Updated E0394 & E0422 to new format #35722, Bump version to 1.13 #35725, update E0409 to new error format #35726, Update E0005 to use a label #35731