Skip to content

expound on limitations of Rust's trait-based operator overloading - #35690

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthew-piziak:op-overloading-limited
Aug 17, 2016
Merged

expound on limitations of Rust's trait-based operator overloading#35690
bors merged 1 commit into
rust-lang:masterfrom
matthew-piziak:op-overloading-limited

Conversation

@matthew-piziak

@matthew-piziakmatthew-piziak commented Aug 15, 2016

Copy link
Copy Markdown
Contributor

Part of #29330

@rust-highfive

rust-highfive commented Aug 15, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@matthew-piziak

matthew-piziak commented Aug 15, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @steveklabnik

@steveklabnik

steveklabnik commented Aug 15, 2016

Copy link
Copy Markdown
Contributor

Looks great, thanks a ton!

@bors: r+ rollup

@bors

bors commented Aug 15, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 18edae4 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Jonathan Turner
Rollup merge ofrust-lang#35690- matthew-piziak:op-overloading-limit…
e20915f
…ed, r=steveklabnik
expound on limitations of Rust's trait-based operator overloading
Part of rust-lang#29330
@sophiajtsophiajt mentioned this pull request Aug 17, 2016
Closed
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of#35743- jonathandturner:rollup, r=jonathandturner
b28ffa5
Rollup of 24 pull requests
- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35691, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 17, 2016
Jonathan Turner
Rollup merge ofrust-lang#35690- matthew-piziak:op-overloading-limit…
49a2873
…ed, r=steveklabnik
expound on limitations of Rust's trait-based operator overloading
Part of rust-lang#29330
@sophiajtsophiajt mentioned this pull request Aug 17, 2016
Merged
bors added a commit that referenced this pull request Aug 17, 2016
@bors
Auto merge of#35747- jonathandturner:rollup, r=jonathandturner
7ac11ca
Rollup of 23 pull requests
- Successful merges: #34370, #35415, #35595, #35610, #35613, #35614, #35621, #35660, #35663, #35670, #35671, #35672, #35681, #35686, #35690, #35695, #35707, #35708, #35713, #35722, #35725, #35726, #35731
- Failed merges: #35395
@bors
bors merged commit 18edae4 into rust-lang:masterAug 17, 2016
@matthew-piziak
matthew-piziak deleted the op-overloading-limited branch August 17, 2016 20:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matthew-piziak@rust-highfive@steveklabnik@bors@alexcrichton