Skip to content

Ignore VS Code settings directory - #35358

Merged
bors merged 1 commit into
rust-lang:masterfrom
vadimcn:vscode
Aug 12, 2016
Merged

Ignore VS Code settings directory#35358
bors merged 1 commit into
rust-lang:masterfrom
vadimcn:vscode

Conversation

@vadimcn

@vadimcnvadimcn commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

@killercup

killercup commented Aug 5, 2016

Copy link
Copy Markdown
Contributor

Just fyi, this should probably (also) be in your system-wide gitignore.

@retep998

retep998 commented Aug 8, 2016

Copy link
Copy Markdown
Contributor

I am opposed to system specific gitignores. If you have something platform or IDE specific, then it really only belongs in your personal gitignore. In my opinion the only stuff that should be in a project's gitignore are things produced normally as a result of building and running that project.

@vadimcn

vadimcn commented Aug 8, 2016

Copy link
Copy Markdown
ContributorAuthor

That's fine by me, but in that case rust's .gitignore could use some serious cleaning...

@steveklabnik

steveklabnik commented Aug 8, 2016

Copy link
Copy Markdown
Contributor

I personally prefer to put them all in the project, but let's make this a @rust-lang/compiler decision, not mine.

What do you all want?

@alexcrichton

alexcrichton commented Aug 8, 2016•
edited
Loading

Copy link
Copy Markdown
Member

Oh I've always felt the ship has long since sailed on this, there's no way our .gitignore is "clean", so no need to have a big decision on new items, seems good to just let anything reasonable sail through at this point

@nikomatsakis

nikomatsakis commented Aug 9, 2016

Copy link
Copy Markdown
Contributor

seems fine.

@steveklabnik

steveklabnik commented Aug 10, 2016

Copy link
Copy Markdown
Contributor

@bors: r+ rollup

@bors

bors commented Aug 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit 751d43a has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge ofrust-lang#35358- vadimcn:vscode, r=steveklabnik
0996264
Ignore VS Code settings directory
r? @steveklabnik
@steveklabniksteveklabnik mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
Jonathan Turner
Rollup merge ofrust-lang#35358- vadimcn:vscode, r=steveklabnik
5933c01
Ignore VS Code settings directory
r? @steveklabnik
@sophiajtsophiajt mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
Jonathan Turner
Rollup merge ofrust-lang#35358- vadimcn:vscode, r=steveklabnik
0fecdc5
Ignore VS Code settings directory
r? @steveklabnik
@sophiajtsophiajt mentioned this pull request Aug 11, 2016
Merged
bors added a commit that referenced this pull request Aug 11, 2016
@bors
Auto merge of#35592- jonathandturner:rollup, r=jonathandturner
8787a12
Rollup of 23 pull requests
- Successful merges: #35279, #35331, #35358, #35375, #35445, #35448, #35482, #35486, #35505, #35528, #35530, #35532, #35536, #35537, #35541, #35552, #35554, #35555, #35557, #35562, #35565, #35569, #35576
- Failed merges: #35395, #35415, #35563
@bors
bors merged commit 751d43a into rust-lang:masterAug 12, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabniksteveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vadimcn@killercup@retep998@steveklabnik@alexcrichton@nikomatsakis@bors