Skip to content

Update E0008 and E0007 to new format - #35530

Merged
bors merged 2 commits into
rust-lang:masterfrom
srdja:master
Aug 12, 2016
Merged

Update E0008 and E0007 to new format#35530
bors merged 2 commits into
rust-lang:masterfrom
srdja:master

Conversation

@srdja

@srdjasrdja commented Aug 8, 2016

Copy link
Copy Markdown

Part of #35233
A fix for #35496

r? @jonathandturner

@rust-highfive

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@arielb1

Copy link
Copy Markdown
Contributor

Could you also change the 2 nearby errors?

@srdja

srdja commented Aug 8, 2016

Copy link
Copy Markdown
Author

@arielb1

Sure, I can fix E0007 (@devshep is working on E0009), but I'd like to get some feedback from @jonathandturner first.

@sophiajt

Copy link
Copy Markdown
Contributor

@srdja - I'll sign you up for E0007 so you can fix that one. @devshep can fix E0009. They're close together, but it's okay for multiple people to work on different ones.

@srdjasrdja changed the title Update E0008 to new formatUpdate E0008 and E0007 to new formatAug 9, 2016
@srdja

srdja commented Aug 9, 2016

Copy link
Copy Markdown
Author

@jonathandturner - I've updated E0007.

@sophiajt

Copy link
Copy Markdown
Contributor

Looks good!

@bors r+ rollup

@bors

bors commented Aug 9, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit aa40ec7 has been approved by jonathandturner

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
@sophiajtsophiajt mentioned this pull request Aug 10, 2016
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
@sophiajtsophiajt mentioned this pull request Aug 11, 2016
bors added a commit that referenced this pull request Aug 11, 2016
@bors
bors merged commit aa40ec7 into rust-lang:masterAug 12, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@srdja@rust-highfive@arielb1@sophiajt@bors