Skip to content

Remove unnecessary main functions in doc examples. - #35482

Merged
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:patch-31
Aug 12, 2016
Merged

Remove unnecessary main functions in doc examples.#35482
bors merged 1 commit into
rust-lang:masterfrom
frewsxcv:patch-31

Conversation

@frewsxcv

@frewsxcvfrewsxcv commented Aug 8, 2016

Copy link
Copy Markdown
Contributor

No description provided.

@rust-highfive

rust-highfive commented Aug 8, 2016

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv

frewsxcv commented Aug 8, 2016

Copy link
Copy Markdown
ContributorAuthor

r? @GuillaumeGomez

@GuillaumeGomez

GuillaumeGomez commented Aug 9, 2016

Copy link
Copy Markdown
Member

Having the main function allows sometimes to avoid some bad automatic test wrapping. If travis says ok, then it's all good but just in case I prefer wait and see.

@frewsxcv

frewsxcv commented Aug 9, 2016

Copy link
Copy Markdown
ContributorAuthor

Travis already finished for this.

@frewsxcv

frewsxcv commented Aug 9, 2016

Copy link
Copy Markdown
ContributorAuthor

For the record, use and extern can be used inside functions, so they aren't going to be extracted out of the generated main.

@GuillaumeGomez

GuillaumeGomez commented Aug 10, 2016

Copy link
Copy Markdown
Member

Normally yes but sometimes we have weird behaviors. Anyway, travis is happy so I am!

@bors: r+ rollup

@bors

bors commented Aug 10, 2016

Copy link
Copy Markdown
Collaborator

📌 Commit e28521e has been approved by GuillaumeGomez

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 10, 2016
@steveklabnik
Rollup merge ofrust-lang#35482- frewsxcv:patch-31, r=GuillaumeGomez
3d5fe6b
Remove unnecessary `main` functions in doc examples.
@steveklabniksteveklabnik mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 10, 2016
Jonathan Turner
Rollup merge ofrust-lang#35482- frewsxcv:patch-31, r=GuillaumeGomez
18ca9dc
Remove unnecessary `main` functions in doc examples.
@sophiajtsophiajt mentioned this pull request Aug 10, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 11, 2016
Jonathan Turner
Rollup merge ofrust-lang#35482- frewsxcv:patch-31, r=GuillaumeGomez
d423c25
Remove unnecessary `main` functions in doc examples.
@sophiajtsophiajt mentioned this pull request Aug 11, 2016
Merged
bors added a commit that referenced this pull request Aug 11, 2016
@bors
Auto merge of#35592- jonathandturner:rollup, r=jonathandturner
8787a12
Rollup of 23 pull requests
- Successful merges: #35279, #35331, #35358, #35375, #35445, #35448, #35482, #35486, #35505, #35528, #35530, #35532, #35536, #35537, #35541, #35552, #35554, #35555, #35557, #35562, #35565, #35569, #35576
- Failed merges: #35395, #35415, #35563
@bors
bors merged commit e28521e into rust-lang:masterAug 12, 2016
@frewsxcv
frewsxcv deleted the patch-31 branch October 2, 2016 23:06
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@GuillaumeGomezGuillaumeGomez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@frewsxcv@rust-highfive@GuillaumeGomez@bors@alexcrichton